Repository navigation
Swap AI Rules badge from New feature to Beta - #93319
Conversation
Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
I'm going to go ahead and merge this to try and have it live by David's presentation on Sunday. But @dubielzyk-expensify can you let us know if you are good with how it looks? We can address in follow-up if not. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Swap AI Rules badge from New feature to Beta (cherry picked from commit 90e4a46) (cherry-picked to staging by Julesssss)
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.5-5 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. This PR is a purely cosmetic UI change — it swaps the badge on the AI Rules workspace section from New feature to Beta ( I searched I did not create a draft docs PR because no documentation change is warranted. @NicolasBonet, please confirm this assessment. If you'd like a help article created (or an existing one updated) to document the AI Rules feature itself, let me know and I'll open a draft docs PR. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.6-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.6-4 🚀
|
Explanation of Change
The "AI Rules" section in workspace settings displayed a New feature badge. Per the discussion on the linked issue, this should communicate that the feature is still in an early/beta stage, so the badge is swapped to Beta.
This is a one-line change in
AIRulesSection.tsx, switching the badge text from the existingcommon.newFeaturetranslation to the existingcommon.betatranslation. Both keys already exist across all locale files, so no new copy is introduced.Fixed Issues
$ #93313
PROPOSAL: $ #93313
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari