Repository navigation
Remove broken-card task and RBR after a 90-day grace period while keeping the error #93523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MariaHCD
merged 21 commits into
Expensify:main
from
wildan-m:wildan/91451-broken-card-90-day-grace
Jul 10, 2026
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f3de12d
Stop surfacing broken card task and RBR after 90 days while keeping t…
wildan-m 99591aa
Merge remote-tracking branch 'upstream/main' into wildan/91451-broken…
wildan-m 9df0102
Add unit tests for the broken-connection 90-day grace period
wildan-m 4551c82
Merge remote-tracking branch 'upstream/main' into wildan/91451-broken…
wildan-m 34bbf11
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 4966465
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m c074a83
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 3d10c4d
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 1d3ba67
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 78b7495
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m bc3bc01
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 35f445c
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 85431d7
fix: re-derive card feed errors at day rollover for 90-day broken-con…
wildan-m d535e91
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 9609644
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 6f25cba
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 1969d61
fix: parse lastScrape with explicit DB format for cross-engine safety
wildan-m 00765f5
test: use full DB datetime format in grace-period fixtures
wildan-m 8f31c5b
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m 9f0029e
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m e2295b6
Merge remote-tracking branch 'upstream/main' into HEAD
wildan-m File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
CURRENT_DATEdependency only advances wheresetCurrentDateis actually called; I checked the wiring and it is started from the web platform setup, whilesrc/setup/platformSetup/index.native.tsis a no-op. On iOS/Android, if a broken card crosses the 90-day boundary while the app remains open and no card/feed data changes, the derived value never recomputes, so the Home task and RBR can persist until a restart or unrelated data update.Useful? React with 👍 / 👎.