Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
2f6ce38 to
cca40dd
Compare
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cca40dd454
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@WojtekBoman can you update the fixed issue and assign the c+ for review? |
|
|
||
| const TRANSPARENT_BACKGROUND = {backgroundColor: 'transparent'} as const; | ||
|
|
||
| const {HOVER_ZOOM_SCALE} = CONST.RECEIPT; |
There was a problem hiding this comment.
Do we need this format? 😅
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
| * amount + waypoints) should be shown. A merged distance expense can be typed `distance-manual` yet | ||
| * still carry waypoints, so the presence of waypoints keeps those included. | ||
| */ | ||
| function isMapBasedDistanceRequest(transaction: OnyxEntry<Transaction>): boolean { |
There was a problem hiding this comment.
Let's add tests for this
This comment has been minimized.
This comment has been minimized.
cca40dd to
024c390
Compare
|
But only one comment 2026-06-16.11.39.12.mov |
|
@ZhenjaHorbach I'll take a look at these issues 👀 |
|
@ZhenjaHorbach Can you check how the same PDF behaves in OldDot? I agree that we might not be able to make this super smooth for large PDF |
|
We just have a delay after hovering / before zooming in OD 2026-06-16.23.00.52.mov |
trjExpensify
left a comment
There was a problem hiding this comment.
Nice improvement. 👍
|
@WojtekBoman How its looking? |
|
There are 4 problems found by @ZhenjaHorbach:
I think this one is worth to check before we merge it, but I'd like to confirm it's a problem:
Should this be adjusted in this PR? Should any of the other issues be addressed in this PR? cc: @mountiny @ZhenjaHorbach |
Yes But regarding the last issue, we need to decide how best to fix it first
And this issue we have in staging also
|
So it does not zoom until the pdf is scanned and synced with the server? |
Yes, but already changed that, now it's allowed to zoom while scanning, it was easy and safe change so added it. @ZhenjaHorbach Could you check if it's ok now? |
By the way
vs
But yes |
mountiny
left a comment
There was a problem hiding this comment.
Sounds like we can move this ahead now then
By the way, we can now also zoom images while scanning |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.10-0 🚀
Bundle Size Analysis (Sentry): |
Help site review — no docs changes requiredI reviewed the changes in this PR against the help articles under Why: This PR is a behind-the-scenes rendering-quality improvement. It adds a web-only
The hover-zoom magnification behavior itself is not documented in the help site today, and a sharpness/quality fix to an existing visual interaction isn't the kind of change that warrants a help article. The closest article — Attach-and-edit-receipts-on-expenses.md — describes attaching, cropping, and rotating receipts, none of which are affected by this change. Since no docs changes are required, I have not created a draft PR. @WojtekBoman, please confirm you agree no help-site changes are needed here. If you think a particular article should still be updated, let me know which one and I'll open a draft PR. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.12-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 I reviewed the changes and no help site updates are required under Why: This PR is an under-the-hood rendering-quality improvement. It adds a web-only I checked the help articles (including No draft PR was created since no documentation changes are needed. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.14-0 🚀
Bundle Size Analysis (Sentry): |
|
Hi @WojtekBoman. Can it be tested on the Native apps? |
|
@IuliiaHerets No, native apps aren't supported for this. I will update the PR description! |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀
|


Explanation of Change
PDF receipts are served as low-resolution JPG thumbnails by the server. When hover-zoomed, these thumbnails blur because the zoom is applied to an upscaled raster. This PR adds
ReceiptZoomablePDF— a web-only component that renders the actual PDF at 2.5× its on-screen size (then scales it back down with CSS), so the hover-zoom layer reveals real PDF pixels. A native no-op stub keeps bundling clean.HOVER_ZOOM_SCALEis extracted toCONST.RECEIPTso both components share the value.Screen.Recording.2026-06-15.at.14.50.47.mov
Fixed Issues
$ #93627
PROPOSAL:
Tests
Tests should be performed on web platforms
Offline tests
This component fetches the PDF via the server URL. Offline behavior is covered in test 2 above: when the PDF URL is unreachable,
onLoadErrorfires,hasFailedis set totrue, andReceiptZoomablePDFrendersnull, revealing the pre-loaded JPG thumbnail underneath. No new Onyx writes are involved.QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari