Repository navigation
Send policyAccountID instead of workspaceAccountID for ToggleCardCashbackToBill - #93663
Conversation
…backToBill Rename the legacy wire key workspaceAccountID to policyAccountID for the ToggleCardCashbackToBill command, completing the App->server migration off the marketing term. Web-Expensify's api.php already accepts both keys. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@truph01 Can you review this? |
|
@ShridharGoel Sure, I can review it |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-06-17.at.16.39.17.mov |
|
Proceeding to merge. Not waiting for flavia cause there are no UI changes. |
|
🚧 @chiragsalian has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.4.10-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no changes required. This PR is a purely internal API wire-key rename — it changes the parameter the App sends for the
There are no user-facing changes: no UI text, feature names, tab labels, settings, or buttons were added or modified, and the Cashback to Bill behavior is unchanged. Help site articles document user-facing product behavior, so a server-bound parameter rename has no impact on anything under No draft PR was created. |
|
🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.4.12-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. This PR is a purely internal API wire-key rename — the App now sends
The help articles that mention cashback (e.g. @ShridharGoel — since no help site changes are required, there's no linked docs PR to review. If you believe a user-facing behavior did change here, let me know and I'll draft the docs update. |
|
🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.4.14-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀
|
Explanation of Change
The App still sent the legacy wire key
workspaceAccountIDfor the ToggleCardCashbackToBill command, even though the rest of the App was migrated topolicyAccountIDin #86365. This was the last remaining App→server spot still using the marketing term.This PR renames the param to
policyAccountIDin both spots so the App sendspolicyAccountIDfor ToggleCardCashbackToBill:src/libs/API/parameters/ToggleCardCashbackToBillParams.ts—workspaceAccountID: number→policyAccountID: numbersrc/libs/actions/Card.ts— the params object now sendspolicyAccountID(policyAccountID: workspaceAccountID), matching the existing pattern used elsewhere in the file.Parent tracking issue: https://github.com/Expensify/Expensify/issues/604128
Fixed Issues
$ #93619
Tests
ToggleCardCashbackToBillrequest and verify the request payload containspolicyAccountID(and no longerworkspaceAccountID).Offline tests
policyAccountIDand the setting is saved.QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari