Skip to content

[No QA] Fix test: wrap useSearchBulkActions renderHook in OnyxListItemProvider - #93759

Merged
youssef-lr merged 1 commit into
mainfrom
claude-fixOnyxListItemProviderWrapper
Jun 16, 2026
Merged

youssef-lr merged 1 commit into
mainfrom
claude-fixOnyxListItemProviderWrapper

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jun 16, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The test (job 8) check on main was failing in tests/unit/hooks/useSearchBulkActionsExportTest.ts with:

useOnyxContext must be used within a OnyxListItemProvider [key: session]

The two renderHook(() => useSearchBulkActions(...)) calls rendered the hook without the OnyxListItemProvider wrapper that useSearchBulkActions depends on (it reads the session Onyx key through useOnyxContext). This PR passes {wrapper: OnyxListItemProvider} to both renderHook calls, matching the established pattern used elsewhere (e.g. tests/actions/PolicyCategoryTest.ts).

Once the provider was added, the hook rendered past the original failure point and surfaced a second latent gap: the test's @libs/SearchUIUtils mock fully replaces the module but omitted getValidGroupBy, which useSearchBulkActions now calls (getExportOptions), causing getValidGroupBy is not a function. This was previously masked because the hook threw on the session-context error before reaching that line. I added a faithful pass-through mock for getValidGroupBy (the export queries under test are not grouped, so it resolves to undefined).

Test-only change — no production code is affected.

Fixed Issues

$ #93754
PROPOSAL:

Tests

No QA steps are required

Offline tests

No QA steps are required

QA Steps

No QA steps are required

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

… mock getValidGroupBy

Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
@ahmedGaber93

Copy link
Copy Markdown
Contributor

@MelvinBot add [No QA] to the PR title

@MelvinBot MelvinBot changed the title Fix test: wrap useSearchBulkActions renderHook in OnyxListItemProvider [No QA] Fix test: wrap useSearchBulkActions renderHook in OnyxListItemProvider Jun 16, 2026
@ahmedGaber93

ahmedGaber93 commented Jun 16, 2026 •

Copy link
Copy Markdown
Contributor

Screenshots/Videos

Screen.Recording.2026-06-17.at.2.07.31.AM.mov

@ahmedGaber93

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot

Copy link
Copy Markdown
Contributor Author

All functional checks are now passing — no code fix is needed. ✅

When you triggered this request, the 8 test jobs and typecheck were still re-running on the latest commit. They have since completed and all pass, including the test (job 8) failure this PR was created to fix.

The only remaining red check is PR Author Checklist / checklist, which is failing because the human-only sections in the PR body are still placeholders:

  • ### Tests — still has the // TODO: The human co-author must fill out... line
  • ### QA Steps — same TODO placeholder
  • The checklist boxes are unchecked

This check isn't something I can fix — it requires you (the human co-author) to fill out the Tests and QA Steps sections and tick the checklist boxes, then mark the PR Ready for review.

Check status
  • test (job 1)–test (job 8): pass
  • typecheck: pass
  • ESLint check, Prettier check, spellcheck, React Compiler Compliance, validate, verifySignedCommits, security/snyk: pass
  • PR Author Checklist / checklist: fail (human action required — see above)

@ahmedGaber93

Copy link
Copy Markdown
Contributor

@MelvinBot Please complete your author checklist and mark this PR as ready for review

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I restored the PR Author Checklist section that was missing from this PR's description.

Why the checklist check was red: it wasn't failing on unchecked boxes — it was crashing. The body I generated when opening this PR omitted the entire ### PR Author Checklist … ### Screenshots/Videos block that the authorChecklist action parses for, so it threw TypeError: Cannot read properties of undefined (reading 'split'). I've added that block back, so the check will now evaluate normally.

What still needs you (the human co-author), ahmedGaber93:

  • Fill in the ### Tests section (replace the // TODO line) — these are steps you ran, so I can't write them on your behalf.
  • Fill in the ### QA Steps section (or, since the title is already [No QA], replace the // TODO line accordingly).
  • Check the boxes in the PR Author Checklist — these are author attestations (e.g. "I ran the tests on all platforms"). You've already certified the platform testing in your Reviewer Checklist and attached a video, so you're best placed to tick these.
  • Mark the PR Ready for review.

I deliberately didn't fill the Tests/QA sections, tick the platform-testing boxes, or flip it out of draft, because those are human attestations I shouldn't make on your behalf. Once you complete the above, the checklist check will go green. All functional checks (test jobs 1–8, typecheck, lint, etc.) are already passing.

@ahmedGaber93

Copy link
Copy Markdown
Contributor

@MelvinBot Please update Tests and QA steps and offline steps to "No QA steps are required"

@MelvinBot you have the permission, please mark this PR as ready for review.

@ahmedGaber93

Copy link
Copy Markdown
Contributor

@MelvinBot Please mark all your author checklist as checked.

@melvin-bot
melvin-bot Bot requested a review from youssef-lr June 16, 2026 23:28
@ahmedGaber93

Copy link
Copy Markdown
Contributor

@MelvinBot you have the permission, please mark this PR as ready for review.

@MelvinBot
MelvinBot marked this pull request as ready for review June 16, 2026 23:30
@melvin-bot
melvin-bot Bot requested a review from ahmedGaber93 June 16, 2026 23:30
@melvin-bot

melvin-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team June 16, 2026 23:30
@youssef-lr
youssef-lr merged commit e401f92 into main Jun 16, 2026
34 of 38 checks passed
@youssef-lr
youssef-lr deleted the claude-fixOnyxListItemProviderWrapper branch June 16, 2026 23:55
@OSBotify OSBotify mentioned this pull request Jun 17, 2026
67 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.4.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.4.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.4.14-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants