Skip to content

extract WorkspaceRowThreeDotsMenu component from WorkspacesListPage - #93820

Merged
mountiny merged 10 commits into
Expensify:mainfrom
software-mansion-labs:perf/workspaces-list-page-composition-2
Jun 19, 2026
Merged

mountiny merged 10 commits into
Expensify:mainfrom
software-mansion-labs:perf/workspaces-list-page-composition-2

Conversation

@WojtekBoman

@WojtekBoman WojtekBoman commented Jun 17, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Extracts WorkspaceRowThreeDotsMenu from WorkspacesListPage into its own component. Leave and transfer-ownership flows are further extracted into LeaveWorkspaceAction and TransferOwnershipAction, each mounted on demand. This keeps heavy per-policy Onyx subscriptions scoped to the lifetime of the flow instead of keeping them alive while the workspaces list is idle. Two focused selectors (createDisplayDetailsByAccountIDsSelector, createCopySettingsEligibleTargetsSelector) are added so the page re-renders only on the subset of data it actually reads.

Fixed Issues

$ #91175
PROPOSAL:

Tests

  1. Open the Workspaces list (Settings > Workspaces).
  2. Tap the three-dot menu on any workspace row and exercise every item: Go to workspace, Leave, Duplicate, Copy settings, Set as default, Delete, Transfer owner.
  3. Verify that each action opens the expected screen or confirmation modal, and that the workspaces list remains fully interactive while any modal is open.

  1. Open the Workspaces list.
  2. Tap Leave on a workspace where you are the reimbursement contact, an exporter, an approver, or an admin.
  3. Verify that the confirmation prompt shows the correct role-specific copy for each case.

  1. Open the Workspaces list as the owner of a paid workspace.
  2. Tap Delete in the three-dot menu.
  3. Verify that the delete confirmation modal appears and that completing it removes the workspace from the list.
  • Verify that no errors appear in the JS console

Offline tests

  1. Disable the network connection.
  2. Open the Workspaces list and tap Delete on a workspace you own.
  3. Verify that the deletion is queued and the workspace is removed from the list optimistically, and that any error modal is shown if the request later fails.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@WojtekBoman
WojtekBoman force-pushed the perf/workspaces-list-page-composition-2 branch from 1b51562 to 1275772 Compare June 17, 2026 14:20
@codecov

ghost commented Jun 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
...s/Tables/WorkspaceListTable/LeaveWorkspaceFlow.tsx 100.00% <100.00%> (ø)
...ts/Tables/WorkspaceListTable/WorkspaceTableRow.tsx 89.36% <100.00%> (-0.30%) ⬇️
src/components/Tables/WorkspaceListTable/index.tsx 71.87% <100.00%> (ø)
src/libs/WorkspacesSettingsUtils.ts 45.00% <100.00%> (+12.69%) ⬆️
src/selectors/PersonalDetails.ts 80.00% <100.00%> (+8.57%) ⬆️
src/selectors/Policy.ts 77.50% <100.00%> (+2.27%) ⬆️
...ables/WorkspaceListTable/TransferOwnershipFlow.tsx 90.00% <90.00%> (ø)
src/pages/workspace/WorkspacesListPage.tsx 69.38% <93.33%> (+13.06%) ⬆️
src/pages/workspace/WorkspaceOverviewPage.tsx 0.00% <0.00%> (ø)
... and 1 more
... and 19 files with indirect coverage changes

@WojtekBoman
WojtekBoman force-pushed the perf/workspaces-list-page-composition-2 branch from 1275772 to c5a0f20 Compare June 17, 2026 14:55
@WojtekBoman
WojtekBoman marked this pull request as ready for review June 17, 2026 15:03
@WojtekBoman
WojtekBoman requested review from a team as code owners June 17, 2026 15:03
@melvin-bot
melvin-bot Bot requested review from abzokhattab and joekaufmanexpensify and removed request for a team June 17, 2026 15:03
@melvin-bot

ghost commented Jun 17, 2026

Copy link
Copy Markdown

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team June 17, 2026 15:03
@WojtekBoman

ghost commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@codex


if (isUserReimburserForPolicy(policy, userEmail)) {
return translate('common.leaveWorkspaceReimburser');
}

ghost Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ CONSISTENCY-3 (docs)

The confirmModalPrompt function added here duplicates the same branching logic that already exists in src/pages/workspace/WorkspaceOverviewPage.tsx (confirmModalPrompt, ~line 494). Both build the leave-workspace confirmation prompt with the identical reimburser / technical-contact / exporter / approver / admin / auditor cascade. Maintaining two copies means any change to the prompt rules (or translation keys) must be made in two places and risks them drifting apart.

Extract this into a single shared helper (e.g. getLeaveWorkspaceConfirmationPrompt(policy, userEmail, ownerDisplayName, translate) in PolicyUtils/WorkspacesSettingsUtils) and call it from both LeaveWorkspaceAction and WorkspaceOverviewPage:

// libs/WorkspacesSettingsUtils.ts
function getLeaveWorkspaceConfirmationPrompt(policy: OnyxEntry<Policy>, userEmail: string, ownerDisplayName: string, translate: LocaleContextProps['translate']) {
    if (isUserReimburserForPolicy(policy, userEmail)) {
        return translate('common.leaveWorkspaceReimburser');
    }
    // ...remaining cascade...
    return translate('common.leaveWorkspaceConfirmation');
}

Reviewed at: c5a0f20 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

@chatgpt-codex-connector

ghost commented Jun 17, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: c5a0f204ae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@mountiny
mountiny self-requested a review June 17, 2026 15:21
@github-actions

ghost commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@abzokhattab

ghost commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

The tests coverage looks to be low lets add test cases to increase them

#93820 (comment)

@github-actions

This comment has been minimized.

@abzokhattab

ghost commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot review the PR

@WojtekBoman

ghost commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

The tests coverage looks to be low lets add test cases to increase them

#93820 (comment)

done!

hasStartedRef.current = true;

clearWorkspaceOwnerChangeFlow(policyID);
requestWorkspaceOwnerChange(policy, session?.accountID ?? CONST.DEFAULT_NUMBER_ID, session?.email ?? '');

ghost Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes session?.email as the user's login, but the three other call sites of requestWorkspaceOwnerChange (including the original code this was extracted from, and the sibling WorkspaceOverviewPage.tsx:480) all pass currentUserPersonalDetails.login:

That third argument is written optimistically to policy.owner (Member.ts:766). For accounts where session.email differs from the canonical personalDetails.login (e.g. SMS/phone logins, secondary logins, casing), the optimistic owner string will differ from what the rest of the app writes. Recommend using currentUserPersonalDetails.login here for consistency. The accountID argument is equivalent either way.

ghost Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored!

@MelvinBot

ghost commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🤖 Code review

Reviewed the refactor that extracts WorkspaceRowThreeDotsMenu, LeaveWorkspaceAction, and TransferOwnershipAction out of WorkspacesListPage and adds the two scoped selectors. The extraction is faithful — I traced each moved block against the original and verified behavior is preserved. One small consistency issue found:

1 finding (low impact): TransferOwnershipAction passes session?.email as the user login to requestWorkspaceOwnerChange, whereas the original code and all three other call sites pass currentUserPersonalDetails.login. Posted inline on TransferOwnershipAction.tsx:38.

Things I checked and cleared
  • Owner display details: ownerAccountIDs is gathered with the exact same shouldShowPolicy(policy, true, session?.email) filter and pending-vs-normal owner-accountID derivation as the row-building loop, so no rendered row will be missing its owner name/avatar. The narrowed DisplayDetails shape (accountID/displayName/login/avatar) covers everything the row reads, including getDisplayNameOrDefault (which only consults displayName/login/accountID).
  • getLeaveWorkspaceConfirmationPrompt: extracted branch order (reimburser → tech contact → exporter → approver → admin → auditor → default) matches the old inline confirmModalPrompt exactly. No circular import (PolicyUtils does not import WorkspacesSettingsUtils).
  • createCopySettingsEligibleTargetsSelector: faithful extraction of the old useMemo; same filters. Prop threads correctly page → table → row → menu, and the EMPTY_COPY_SETTINGS_ELIGIBLE_TARGETS fallback keeps the menu prop non-undefined.
  • Delete spinner / popover-hide: shouldShowLoadingSpinnerIcon, shouldKeepModalOpen/shouldCallAfterModalHide, and the isLoadingBill popover-hide effect moved verbatim into WorkspaceRowThreeDotsMenu.
  • createOwnedPaidPoliciesCountsSelector(session?.accountID) is equivalent to the old currentUserPersonalDetails.accountID (the provider sets accountID = session?.accountID ?? DEFAULT_NUMBER_ID).
  • Leave flow owner-name timing: not a regression — the list already requires personal details to render owner names, and the old flow read them synchronously at click time too.

I did not run the app or the test suite — this is a static review only.


Reply with @MelvinBot <feedback> to refine this review.

@WojtekBoman
WojtekBoman force-pushed the perf/workspaces-list-page-composition-2 branch 2 times, most recently from 0c5127c to 64aa0be Compare June 17, 2026 16:17
@WojtekBoman

ghost commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@abzokhattab all comments have been resolved :)

@joekaufmanexpensify

ghost commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No product review needed

@joekaufmanexpensify
joekaufmanexpensify removed their request for review June 17, 2026 20:39
@abzokhattab

ghost commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Bug on ios:

  1. Invite a user to a workspace as an admin
  2. Log in with wiith the new invited admin
  3. On the workspace list, click on three dots, then leave
  4. Nothing happens, and the app hangs
Screen.Recording.2026-06-18.at.12.21.28.mov

@WojtekBoman

ghost commented Jun 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Bug on ios:

  1. Invite a user to a workspace as an admin
  2. Log in with wiith the new invited admin
  3. On the workspace list, click on three dots, then leave
  4. Nothing happens, and the app hangs

Screen.Recording.2026-06-18.at.12.21.28.mov

@abzokhattab Nice catch! Thanks for noticing that :)
I resolved your comment and addressed this issue:

Screen.Recording.2026-06-18.at.14.24.35.mov

@abzokhattab

ghost commented Jun 18, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
Screen.Recording.2026-06-18.at.12.20.16.mov
Screen.Recording.2026-06-18.at.16.49.43.mov
iOS: mWeb Safari
Screen.Recording.2026-06-18.at.17.21.47.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-18.at.11.17.31.mov
Screen.Recording.2026-06-18.at.11.18.43.mov

@mountiny

ghost commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@abzokhattab whats the latest?

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank for the quick reply

@WojtekBoman
WojtekBoman force-pushed the perf/workspaces-list-page-composition-2 branch from 531fe87 to c51eb26 Compare June 19, 2026 07:15
@WojtekBoman

ghost commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

@mountiny comments resolved!

ghost Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is still named Action

ghost Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is still named action

@mountiny
mountiny merged commit cf47ab8 into Expensify:main Jun 19, 2026
@github-actions

ghost commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

ghost commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

ghost commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@OSBotify OSBotify mentioned this pull request Jun 19, 2026
48 tasks done
@OSBotify

ghost commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.16-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

ghost commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against the help site files under docs/articles.

No help site changes are required.

This PR is a pure internal refactor / performance optimization:

  • Extracts WorkspaceRowThreeDotsMenu, LeaveWorkspaceFlow, and TransferOwnershipFlow out of WorkspacesListPage into their own on-demand components.
  • Adds two focused Onyx selectors (createDisplayDetailsByAccountIDsSelector, createCopySettingsEligibleTargetsSelector) so the page re-renders only on the data it reads.

There is no user-facing behavior change: the three-dot menu actions (Go to workspace, Leave, Duplicate, Copy settings, Set as default, Delete, Transfer owner) and all confirmation copy are unchanged — every translate() call references pre-existing keys, and no src/languages/* files were modified. Since the help site documents what users see and do, and none of that changed, no article updates are needed.

I did not create a draft docs PR since there's nothing to document.

@WojtekBoman, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review — note that no help site PR was created because no docs changes are required here; let me know if you believe an article does need updating and I'll take another look.

"../../tests/unit/PaymentUtilsTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 7
"../../tests/unit/PersistedRequests.ts" "@typescript-eslint/no-unsafe-type-assertion" 7
"../../tests/unit/PersonalDetailsSelectorTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../tests/unit/PersonalDetailsSelectorTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 5

ghost Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add instances of this. Use partial types instead of as-casts.

"../../tests/unit/PersonalDetailsSelectorTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 5
"../../tests/unit/PolicyChangeLogContentTest.tsx" "@typescript-eslint/no-unsafe-type-assertion" 4
"../../tests/unit/PolicySelectorTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 21
"../../tests/unit/PolicySelectorTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 22

ghost Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

"../../tests/unit/WorkflowUtilsTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 8
"../../tests/unit/WorkspaceReportFieldUtilsTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../tests/unit/WorkspacesSettingsUtilsTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 15
"../../tests/unit/WorkspacesSettingsUtilsTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 23

ghost Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@OSBotify

ghost commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.16-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants