Repository navigation
[No QA] Fix flaky UnreadIndicatorsTest CI timeout - #93830
Merged
Merged
Conversation
Complete the PR #92587 waitFor pattern, avoid act() stalls during chat navigation, and raise the Jest timeout to 240s for loaded CI runners. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
madmax330
approved these changes
Jun 17, 2026
67 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.10-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.12-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.14-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
tests/ui/UnreadIndicatorsTest.tsx›Display bold in the LHN for unread chat and new line indicator above the chat message when we navigate to itintermittently times out at 120s on loaded CI runners (job 7).PR #92587 fixed the final scroll/badge assertion in this test, but it still timed out on main after that merge. This PR completes the stabilization work:
jest.setTimeoutfrom 120s to 240s — safety net for full<App />mount tests under CI load (same precedent as perf tests and proposed PaginationTest fix).waitFor(() => expect(isNewMessagesBadgeVisible())...)calls withwaitForBatchedUpdates()+ synchronous assertions to avoidwaitFor + acthangs when scroll/Reanimated effects drain under CPU contention.navigateToSidebarOptionWithoutAct()— usefireEvent+waitForBatchedUpdates()instead of TestHelper'swaitForBatchedUpdatesWithAct()for chat navigation in this file, reducing act()-drain stalls when opening chats with scroll tracking.Fixed Issues
$ #93829
PROPOSAL:
Tests
npx jest tests/ui/UnreadIndicatorsTest.tsx --testNamePattern="Display bold in the LHN"— passes in ~9–43s locally (ran 3 times).npx jest tests/ui/UnreadIndicatorsTest.tsx— verify no regressions in passing tests.Offline tests
N/A — test-only change; no offline behavior changed.
QA Steps
N/A — [No QA] test-only change; no production behavior changed.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Screenshots/Videos
Android: Native
N/A — test-only change
Android: mWeb Chrome
N/A — test-only change
iOS: Native
N/A — test-only change
iOS: mWeb Safari
N/A — test-only change
MacOS: Chrome / Safari
N/A — test-only change
Made with Cursor