Repository navigation
Refactor: remove deprecatedAllTransactions in getTransactionReportName - #94137
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-06-23.at.16.27.25.mov |
|
@linhvovan29546 Thanks. Great job 💯 |
|
🚧 Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.4.18-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 I reviewed the changes in this PR and no help site updates are required. Why: This is an internal code refactor — No draft PR was created since there are no documentation changes to make. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀
|
Explanation of Change
Refactors
getTransactionReportNameto accept a singlelinkedTransactionobject instead of atransactionsarray. This is part of the effort to removedeprecatedAllTransactions(issue #66418).Key changes:
getTransactionReportName: renamedtransactions?: Transaction[]→linkedTransaction: OnyxEntry<Transaction>. Removes the internal call togetLinkedTransaction()(which useddeprecatedAllTransactionsas fallback) since callers now pass the transaction directly.computeChatThreadReportName: madetransactionsparam required and moved it before optional params. The O(1) lookup (transactions?.[key]) was already happening at the call site — we now pass the result directly aslinkedTransactioninstead of wrapping it in an array.ComputeReportName.transactions: made required sincereportAttributes.tsalways provides it.Performance improvement: Previously,
computeChatThreadReportNamewrapped a single transaction into an array, passed it togetTransactionReportName, which then calledgetLinkedTransactionto.find()on that array — an unnecessary round-trip. Now it passes the transaction object directly.Fixed Issues
$ #66418
PROPOSAL: N/A
Tests
Test 1
Test 2
Create two similar expenses (same merchant or similar amount)
Navigate to merge transactions flow (select an expense > three-dot menu > Merge)
Check the transaction display name at the top of the merge list
Verify that the target transaction name displays correctly (e.g., "$25.00 for Coffee Shop")
Verify that no errors appear in the JS console
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Screen.Recording.2026-06-22.at.14.35.47.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-22.at.14.25.26.mov