Skip to content

[No QA] Add tax tracking articles - #94138

Merged
bfitzexpensify merged 7 commits into
mainfrom
helpsite-tax-articles
Jun 23, 2026
Merged

bfitzexpensify merged 7 commits into
mainfrom
helpsite-tax-articles

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Updated explanation of tax amount display in expenses.
@stephanieelliott stephanieelliott self-assigned this Jun 22, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f61528736

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions github-actions Bot changed the title Add tax tracking articles [No QA] Add tax tracking articles Jun 22, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott

Copy link
Copy Markdown
Contributor Author

@MelvinBot why didn't the help site QA review (github-actions[bot]) run on this PR?

@OSBotify

This comment has been minimized.

@MelvinBot

Copy link
Copy Markdown
Contributor

The help-site review did run when this PR was opened (run 27933682870) — but the docs step was skipped because the file was misnamed. When you opened the PR, the article was committed as Learn-About-Tracking-Taxesmd (no .md extension). The review's path filter only matches docs/**/*.md, so a file without a .md extension didn't match → the "Run Claude Code (docs)" step was skipped.

You fixed the name ~30 min later (commit 2596918304 "Rename Learn-About-Tracking-Taxesmd to Learn-About-Tracking-Taxes.md") and added Set-distance-rates.md, but those were pushes to an already-open PR. The workflow only triggers on opened and ready_for_review — not on subsequent pushes — so it never re-ran.

To re-trigger it: convert this PR to a draft, then mark it Ready for review. That fires the ready_for_review event and the help-site review will run against the now-correctly-named files.

Evidence from the run

The Filter paths step logged:

Fetching list of changed files for PR#94138 from Github API
[added] docs/articles/new-expensify/workspaces/Learn-About-Tracking-Taxesmd
Detected 1 changed files
Filter docs = false

Both the contributor-authorization gate and path filter ran successfully; only the docs filter evaluated to false because no .md file was present at open time. The Run Claude Code (docs) step is gated on steps.filter.outputs.docs == 'true', so it was skipped.

@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as draft June 22, 2026 22:37
@stephanieelliott
stephanieelliott marked this pull request as ready for review June 22, 2026 22:37
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new conceptual article (Learn-About-Tracking-Taxes.md) and restructures Set-distance-rates.md into a task-based format with a proper H1, ## headings, and a comprehensive FAQ. Both changes meaningfully improve structure and AI retrievability over the prior content. The restructure of the distance rates article is a strong step forward; the main gaps are UI-terminology casing consistency, a few small typos/missing periods, and trailing whitespace.

Scores Summary

  • Readability: 8/10 - Clear, well-sequenced steps and a thorough, genuinely useful FAQ. Minor typos ("Select each of rate", missing period after Selected) and trailing whitespace reduce polish.
  • AI Readiness: 9/10 - Both files use a single # title, task-based ## headings starting with How/What, and complete YAML including internalScope. The new article has strong keywords and scope. Distance rates now leads with a # Set Distance Rates H1 that previously was missing.
  • Style Compliance: 7/10 - Navigation phrasing follows the unified web/mobile standard correctly and buttons are bolded. The recurring issue is inconsistent feature-name casing: the UI tab/feature is Distance Rates but the body mixes "Distance rates" and "Distance Rates". Per Core UI Referencing Rules, match the UI capitalization exactly and consistently.

Key Findings

  • Positive: Distance rates article is correctly converted from multiple # section headings to a single # title plus task-based ## sections, with # FAQ used correctly (exempt). This aligns with Authoring Guidelines Sections 2 and 4.
  • Positive: The new tax article has complete, search-aligned metadata and a well-scoped internalScope that explicitly states exclusions.
  • Style: Inconsistent casing of "Distance rates" vs the UI's Distance Rates throughout both files; standardize to the exact UI label.
  • Quality: Small typos and formatting nits - "Select each of rate you want", Click **Selected** (missing period), and trailing whitespace/trailing periods after several links (e.g. Track-Taxes). ).
  • Cross-linking: All linked targets exist (Track-Taxes, Create-expense-categories, Distance-Expenses, Workspace-Merchant-Rules). The tax article's ## Related articles section lists four links; per Cross-Linking Standards, keep it limited to essential prerequisite/deep-dive workflows and avoid it reading as a directory.
  • Note: Learn-About-Tracking-Taxes.md includes extra frontmatter keys (contentType, platform) not defined in TEMPLATE.md - harmless but not part of the standard schema.

Recommendations

  • Standardize feature naming to the exact UI casing (Distance Rates, Taxes) consistently across body, steps, and FAQ.
  • Fix typos/punctuation: "Select each rate you want to disable or delete", add the period after Click **Selected**, and remove trailing whitespace and stray trailing periods after link sentences.
  • Trim the tax article's ## Related articles to only essential prerequisites/deep-dives to preserve retrieval precision.
  • Optional: align the new article's frontmatter to the TEMPLATE.md schema (drop non-standard keys unless intentionally supported by the build).

Files Reviewed

  • docs/articles/new-expensify/workspaces/Learn-About-Tracking-Taxes.md - New, well-structured conceptual article; minor cross-link trimming and casing.
  • docs/articles/new-expensify/workspaces/Set-distance-rates.md - Strong task-based restructure; fix casing consistency and small typos.

Note: Detailed line-by-line feedback has been provided as inline comments.

@OSBotify

This comment has been minimized.

@stephanieelliott

Copy link
Copy Markdown
Contributor Author

Applied all relevant QA comments

@stephanieelliott
stephanieelliott requested a review from a team June 23, 2026 01:31
@melvin-bot

melvin-bot Bot commented Jun 23, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

@melvin-bot
melvin-bot Bot requested a review from bfitzexpensify June 23, 2026 01:31
@melvin-bot
melvin-bot Bot removed the request for review from a team June 23, 2026 01:31
@melvin-bot

melvin-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://73c8d561.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 23, 2026
@bfitzexpensify
bfitzexpensify merged commit 852dc69 into main Jun 23, 2026
14 checks passed
@bfitzexpensify
bfitzexpensify deleted the helpsite-tax-articles branch June 23, 2026 09:42
@OSBotify OSBotify mentioned this pull request Jun 23, 2026
48 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/bfitzexpensify in version: 9.4.18-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants