Repository navigation
[NO QA] Filter UPDATE_REQUIRED from Sentry error reporting - #94203
Conversation
UPDATE_REQUIRED is thrown as control flow to route the error boundary to UpdateRequiredView when the client is below the minimum supported version. It is not a crash, so add it to ignoreErrors so it is not reported to Sentry.
Updated comment to clarify handling of UPDATE_REQUIRED error in Sentry.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @pecanoro has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.4.18-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 I reviewed this PR and no help site changes are required. This change only adds Since there is nothing customer-facing to document, I did not open a docs PR. @rlinoz, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀
|
Explanation of Change
UPDATE_REQUIREDis not a real error, but when we update the app min version it spikes and rate limits other errors in Sentry, so this PR ignores it.Fixed Issues
$
PROPOSAL:
Tests
Enable send data to sentry in troubleshoot
Force a higher version in Web-E
Reload App
Check no new event in sentry for this error
Verify that no errors appear in the JS console
Offline tests
Not applicable — this only affects which client-side errors are forwarded to Sentry.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari