Repository navigation
Fix regressions from [Rules Revamp] Release 1 - #94478
Conversation
…line layout. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ects. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
I am not able to reproduce #94352 on web.mov |
| <FixedFooter | ||
| addBottomSafeAreaPadding | ||
| addOfflineIndicatorBottomSafeAreaPadding | ||
| style={styles.ph5} |
There was a problem hiding this comment.
FixedFooter already has styles.ph5 so redundant
| style={styles.ph5} |
| <FixedFooter | ||
| addBottomSafeAreaPadding | ||
| addOfflineIndicatorBottomSafeAreaPadding | ||
| style={styles.ph5} |
|
@codex review |
|
🤖 Code review Overall the changes are clean and targeted, and all CI checks are green. The 1. const validExpenseDefaultKeys = new Set(expenseDefaultsTableData.filter((rule) => !rule.disabled).map((rule) => rule.keyForList));
const validSpendRuleKeys = new Set(spendRulesTableData.filter((rule) => !rule.disabled).map((rule) => rule.keyForList));This is the same 2. 3. Minor — toggle flash on 4. Minor — Verification
Next Steps: Reply with |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
|
@luacmartins over to you |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.20-0 🚀
|
|
|
|
Deploy Blocker #94641 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #94352
$ #94353
$ #94360
$ #94384
$ #94473
PROPOSAL:
Tests
Prerequisites
rulesRevampbeta enabled#94352 — Select-all shows pointer when not clickable
Setup: Enable Expensify Card (with bank account). Enable Rules. Do not create custom card spend rules (only the built-in default row).
Verify: Cursor is disabled (
not-allowed), not a hand/pointer. Checkbox is not clickable.#94353 — “1 selected” persists after deleting rule from edit page
Setup: Create an expense default rule (Add rule → Apply expense defaults).
Verify: “1 selected” bulk-actions dropdown is gone after returning to the table.
#94360 — “Custom rules” section splits when sorting by Card
Setup: Enable Expensify Card. Assign virtual cards to you and another member. Create two custom card spend rules (one per card).
Verify: “Custom rules” appears once as a section header (default row stays grouped; no extra “Custom rules” band in the middle of the list).
#94384 — Require fields Save needs two taps
Setup: Enable Tags in More features and add tags. Enable Rules.
Verify: Rule saves and you navigate back to the Rules page on the first tap (not a no-op, and not two screens back on a second tap).
Offline tests
#94473 — Offline indicator mid-screen on Add rule (mobile)
Setup: Enable Rules. Use iOS or Android app.
Verify: “You appear to be offline” is pinned to the bottom of the screen, not floating under the menu items.
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
bug_94473_android.mp4
Android: mWeb Chrome
iOS: Native
bug_94384.mp4
bug_94473_ios.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
bug_94352.mp4
bug_94353.mp4
bug_94360.mp4