Skip to content

Perf - lazy mount NavigateGlobalCreateProvider for faster scan camera - #94693

Merged
Julesssss merged 10 commits into
Expensify:mainfrom
callstack-internal:perf-scan-camera-lazy-mount
Jul 6, 2026
Merged

Julesssss merged 10 commits into
Expensify:mainfrom
callstack-internal:perf-scan-camera-lazy-mount

Conversation

@rinej

@rinej rinej commented Jun 26, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #95708
PROPOSAL: #83502 (comment)

Tests

  1. Default-policy path
  • Sign in as a user with a single default expense policy.
  • From the inbox, tap the FAB (+) → Create expense → Scan.
  • Verify the camera viewport appears quickly with no visible flicker or black flash after the first paint.
  • Capture a receipt.
  • Verify the confirmation page opens with the default policy's expense chat preselected as the target report.
  1. No-default-policy path
  • Sign in as a user with no default expense policy (personal account only).
  • FAB → Create expense → Scan, then capture a receipt.
  • Verify the participant picker opens.
  1. Multi-scan path
  • From the scan screen, enable multi-scan.
  • Capture 2+ receipts in sequence.
  • Tap submit.
  • Verify the confirmation page opens with all captured receipts attached and the correct target report.

Offline tests

QA Steps

  • Same as Tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
perfScanAndroid.mp4

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@rinej
rinej requested review from a team as code owners June 26, 2026 12:24
@melvin-bot
melvin-bot Bot requested review from brunovjk and removed request for a team June 26, 2026 12:24
@melvin-bot

melvin-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09648354c6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

if (!isReady) {
return <NavigateGlobalCreateContext.Provider value={NO_OP}>{props.children}</NavigateGlobalCreateContext.Provider>;
}
return <NavigateGlobalCreateProviderInner {...props} />;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the camera subtree mounted while enabling navigation

When isReady flips after the first effect, this branch changes the rendered root from NavigateGlobalCreateContext.Provider to NavigateGlobalCreateProviderInner, whose root is a different component type, so React unmounts and remounts props.children. In the scan flow that tears down and reinitializes ScanGlobalCreateInner/Camera immediately after the first paint, restarting the camera/media setup and causing the flicker or delay this change is trying to avoid; keep a stable provider subtree and only swap the context value/subscription component.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Jun 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...IOURequestStepScan/components/ScanGlobalCreate.tsx 3.22% <0.00%> (+1.00%) ⬆️
...tepScan/components/NavigateGlobalCreateContext.tsx 62.85% <62.85%> (ø)
... and 24 files with indirect coverage changes

@brunovjk

Copy link
Copy Markdown
Contributor

@rinej is the PR ready for review? Thanks

@rinej

rinej commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

@brunovjk yup, it is

@brunovjk

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
94693_android_native.mov
Android: mWeb Chrome
94693_android_web.mov
iOS: HybridApp
94693_android_native.mov
iOS: mWeb Safari
94693_android_web.mov
MacOS: Chrome / Safari

N/A

@brunovjk brunovjk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: I had one theoretical concern around fnRef.current starting as NO_OP before NavigateGlobalCreateSubscriber publishes the real callback. I tried to reproduce it by capturing/picking a receipt immediately after opening Scan, but couldn’t reproduce any lost navigation. What do you thunk @rinej? Thank you.

@rinej

rinej commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@brunovjk Good catch, in theory, there could be a small gap between the Camera's first paint and the subscriber's useEffect being committed.If that's the case, the gap is probably only around ~10ms, making it impossible to notice or to reproduce

We could eliminate that gap by moving the ref write from useEffect into the subscriber's render body. However, I'm not sure that's the right trade-off, as we might lose some of the performance gains from this refactor

cristipaval
cristipaval previously approved these changes Jul 1, 2026

@cristipaval cristipaval left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Left one NAB about a possible test.


useEffect(() => {
// eslint-disable-next-line react-hooks/set-state-in-effect -- intentional one-tick defer to keep heavy Onyx subscriptions off the camera-mount critical path
setIsReady(true);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: does it make sense to add a small render test here? The tricky part is the isReady flip + fnRef publish, and it could regress silently later. Something that checks the camera subtree stays mounted across the flip, and that navigateGlobalCreate still works once the subscriber is ready. Not blocking.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, it makes sense, I added tests

/**
* Owns the post-capture-only Onyx reads (default policy, self-DM report,
* billing grace periods) used by navigateGlobalCreate. Render-gated by a
* one-tick useEffect so the subscriptions don't block ManualEntryToScanReady.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but we could probably drop ...(default policy, self-DM report, * billing grace periods) as it isn't a full list and could easily become outdated.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I removed it

Julesssss
Julesssss previously approved these changes Jul 1, 2026
@rinej
rinej dismissed stale reviews from Julesssss and cristipaval via 908f88a July 2, 2026 12:34
@rinej

rinej commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @Julesssss @cristipaval for the review, I added the small requested changes

@rinej

rinej commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

There are some failed checks for Duplicate declaration "searchListContent", but ti seems it comes from main

@cristipaval

Copy link
Copy Markdown
Contributor

@rinej those checks should be passing in main now. Could you please pull main into this one?

cristipaval
cristipaval previously approved these changes Jul 2, 2026
@rinej

rinej commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Its all green now, also updated changes after prettier -> fmt migration

@Julesssss
Julesssss merged commit e8163d5 into Expensify:main Jul 6, 2026
36 checks passed
@OSBotify

OSBotify commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Jul 7, 2026
77 tasks done
@OSBotify

OSBotify commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.29-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no changes required.

I reviewed the changes in this PR against the help site articles under App/docs/articles.

This is a pure internal performance refactor — it extracts the post-capture Onyx reads into a lazy-mounted NavigateGlobalCreateProvider so heavy subscriptions stay off the camera-mount critical path, making the scan camera open faster. There is:

  • No change to user-facing behavior — the default-policy, no-default-policy, and multi-scan flows all behave exactly as before.
  • No new or renamed UI elements — no feature names, tab names, settings labels, or buttons are added or changed.
  • No workflow change — scanning a receipt, the confirmation page, and the participant picker are all unchanged.

The existing scan/SmartScan help articles document the receipt-capture feature at a user level and don't describe camera mount timing or the internal navigation logic this PR touches, so none of them go stale as a result of this change.

Since there are no user-observable changes, no draft help site PR was created.

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.31-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no changes required

I reviewed the changes in this PR against Expensify's help site articles under App/docs/articles, and no documentation updates are needed.

Why: This is a purely internal performance refactor. It introduces a lazy-mounted NavigateGlobalCreateProvider so that post-capture Onyx subscriptions load one tick after the camera mounts, keeping them off the camera-mount critical path (faster scan camera, no flicker). The user-facing scan flow — FAB (+) → Create expense → Scan → capture → confirmation page (with the default policy's expense chat preselected) or the participant picker — is behaviorally unchanged. No feature names, tab names, settings labels, buttons, or user workflows were added or altered.

Since nothing customer-facing changed, there's nothing in the help site to update, so I did not create a draft docs PR.

@rinej, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.31-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants