Repository navigation
Show New message marker when a user marks their own message as unread #95217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
c52f485
Show New marker when user marks their own message as unread
MelvinBot 669f3f5
Re-trigger CI (flaky iOS build)
MelvinBot 5f489a4
Anchor New marker on self-marked-unread action via stable reportActionID
MelvinBot 5513cf7
Fix: register manuallyMarkedUnreadReportActionID in Report key enumer…
MelvinBot 5e78e87
Fix: add manuallyMarkedUnreadReportActionID case to validateReportDra…
MelvinBot a973b57
Merge remote-tracking branch 'origin/main' into claude-selfAuthoredUn…
MelvinBot 233a43f
Restore prevUnreadMarkerReportActionID guard for self-authored actions
MelvinBot 8c48e50
Update unit test to assert self-authored cold-open guard
MelvinBot 4f7bc57
Only skip auto-read on reconnect when the marked action was previousl…
MelvinBot 601ef78
Revert "Only skip auto-read on reconnect when the marked action was p…
MelvinBot f76655a
Clear manuallyMarkedUnreadReportActionID when the current user sends …
MelvinBot 1b0eb1e
Skip reconnect auto-read only for an optimistic manually-unread action
MelvinBot efed22e
Revert "Skip reconnect auto-read only for an optimistic manually-unre…
MelvinBot 31cacdd
Revert "Clear manuallyMarkedUnreadReportActionID when the current use…
MelvinBot 5882567
Clear manually-unread marker by not bailing before readNewestAction
MelvinBot 6dfac6a
Keep unread marker on the marked message when a newer self-message is…
MelvinBot 79bdb15
Anchor manual-unread marker on the marked action regardless of adjace…
MelvinBot 0a8dfe8
Remove manuallyMarkedUnreadReportActionID guard from handleReportChan…
MelvinBot ecab87e
Retain new marker through auto-read and make manual-unread the sole m…
MelvinBot ff1c441
Clear manuallyMarkedUnreadReportActionID on completed openReport reload
MelvinBot d2af5d9
Reconcile manual unread marker only on genuine report reload, not eve…
MelvinBot d166efe
Clear manual unread marker on the second open of the report, not the …
MelvinBot de87a27
Clear manual unread marker on navigate-away-and-back, not on refresh …
MelvinBot 22e8fc7
Move manual unread marker clear from successData to optimisticData in…
MelvinBot 4d5e09d
Clear manuallyMarkedUnreadReportActionID on every openReport
MelvinBot a1d047d
Revert "Clear manuallyMarkedUnreadReportActionID on every openReport"
MelvinBot 3e501fc
Also clear manual unread marker on page refresh, not only navigate-back
MelvinBot bb823e6
Merge remote-tracking branch 'origin/main' into claude-selfAuthoredUn…
MelvinBot 825fb5e
Fix failing unread-marker tests: move marker when marked action is de…
MelvinBot 81fda36
Don't populate prevUnreadMarkerReportActionID from the manual-mark an…
MelvinBot 3dbc70c
Move self-message marker-hop guard into the display decision
MelvinBot 98a8e1d
Update readNewestAction comment to reflect the openReport clearing me…
MelvinBot 2657b78
Only suppress self-marker hop while previous anchor is still present
MelvinBot 162c775
Merge remote-tracking branch 'origin/main' into claude-selfAuthoredUn…
MelvinBot 5e43f7d
Discard ignored navigateToConciergeChat promise in fire-and-forget ca…
MelvinBot 01c8744
Don't reassert manuallyMarkedUnreadReportActionID in markAsUnread suc…
MelvinBot 16ac539
Apply review suggestions: trim marker comments; clear manual unread m…
MelvinBot 75b2104
Add readNewestAction coverage for manual unread mark clearing
MelvinBot b5b7c7a
Revert readNewestAction manual-unread clearing per review; keep marke…
MelvinBot 36a44ea
Roll back to 01c874428b96bca71d9f993d8662b679d824dea6
MelvinBot d3fe775
Trim the self-authored marker-hop comment per review
MelvinBot d1a2d52
Trim the prevUnreadMarkerReportActionID tracking comment per review
MelvinBot f03b445
Trim the readNewestAction manual-unread comment per review
MelvinBot 25eb162
Merge remote-tracking branch 'origin/main' into claude-selfAuthoredUn…
MelvinBot 3b117ad
Use connectWithoutView for the RAM-only report loading state to fix E…
MelvinBot c4a3edf
Pass hasOnceLoadedReportActions to openReport instead of reading it f…
MelvinBot c4a3e80
Merge remote-tracking branch 'origin/main' into claude-selfAuthoredUn…
MelvinBot 3e967d6
Make the unread-marker comments more concise
MelvinBot b62d637
Merge remote-tracking branch 'origin/main' into claude-selfAuthoredUn…
MelvinBot a1989f7
Merge remote-tracking branch 'origin/main' into claude-selfAuthoredUn…
MelvinBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We fixed an edge case in issue #103759 related to LHN not turning bold as we missed using the newly introduced
manuallyMarkedUnreadReportActionIDinisUnread.