Repository navigation
Update conciergeReportID to remove Onyx.connect - 30 - #95760
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d18b88fb3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
|
@cretadn22 Could you fix the failed check? |
|
@DylanDylann Updated as requested. Please check again when you have a moment |
…ensure proper handling of undefined values
|
@cretadn22 Could you add steps? |
…o streamline functionality and prepare for future refactoring.
|
@DylanDylann Mind taking another look when you get a chance? |
|
@codex review |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-15.at.14.50.41.mov |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc272d42ce
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| isSmallScreenWidth: boolean, | ||
| canUseDefaultRooms: boolean | undefined, | ||
| conciergeReportID: string, | ||
| conciergeReportID: string | undefined, |
There was a problem hiding this comment.
Guard undefined Concierge report before navigating
When conciergeReportID is allowed to be undefined, the mobile TRACK_EXPENSES_WITH_CONCIERGE path below can call ROUTES.REPORT_WITH_ID.getRoute(conciergeReportID) before the Onyx value has loaded. That route builder interpolates the value, so this navigates to r/undefined instead of Concierge or a safe fallback, leaving users who finish this onboarding variant on an invalid report route. Please keep a non-empty guard/fallback before taking that branch.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@cretadn22 Could you double-check this comment? In my opinion, this case wouldn't occur in practice
There was a problem hiding this comment.
conciergeReportID should always be loaded by the time this function runs. The | undefined type is purely added to satisfy the type check
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.36-0 🚀
|
|
🤖 I reviewed the changes in this PR and no help site changes are required under Why: This is a purely internal code refactor — part of deprecating There are no changes to user-facing behavior, UI, feature/tab/setting names, button labels, or copy — so nothing in the customer-facing help site is affected. Accordingly, I did not create a draft docs PR.
If you believe a specific behavior visible to users did change and should be documented, let me know which flow and I'll take another look. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.38-0 🚀
|
No help site changes requiredI reviewed the changes in this PR and no updates to Expensify's help site ( Why: This is a purely internal, non-user-facing refactor — part 30 of the conciergeReportID / remove
There are no new features, no UI/label/tab/button changes, and no copy changes — nothing that alters documented product behavior. Help site articles describe user-facing behavior, which is unchanged here.
@cretadn22, if you believe any user-facing behavior did change and warrants a docs update, let me know the specific flow and I'll draft the help site PR. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.40-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site articles in No help site changes are required, and no draft docs PR was created. This PR is a pure internal refactor (part of the There are no changes to features, UI, tab or settings labels, buttons, or any user-facing behavior. Help site articles document product behavior for end users, and nothing here alters that behavior, so there is nothing to update.
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.40-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66411
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-15.at.09.18.54.mov