Repository navigation
Fix filter pill overflow by restoring the 256px max width cap - #95943
Conversation
|
@ahmdshrif is this ready for review? |
fd5b8aa to
aaa30b5
Compare
|
it's ready now |
aaa30b5 to
07f71e7
Compare
|
Screenshots are looking pretty good to me |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb Chrome |
|
Same, looking good 👍 |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.36-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site articles under No help site changes are required. This PR is a purely cosmetic style fix: it removes There is no change to any user-facing feature, workflow, setting, label, or navigation path — nothing that the help site documents. The way users apply filters, the filter names, and the resulting behavior are all unchanged; only the visual rendering of an over-long pill label is corrected. Since no documented behavior changed, there are no articles to update and no draft docs PR was created. @ahmdshrif, since no docs changes are needed there is no linked help site PR to review. If you believe a documented behavior did change and a docs update is warranted, let me know and I'll create the draft PR. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.38-0 🚀
|
|
🤖 No help site changes required. This PR is a cosmetic, rendering-only fix: it restores a Expensify's help site ( @ahmdshrif, if you feel a specific article should still be touched here, let me know which one and I'll take another pass. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.40-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site articles under No help site changes are required. This PR is a purely visual style fix: it restores a There is no change to any feature name, workflow, setting, tab, or button label — nothing a customer-facing help article describes. Help site content documents product behavior and steps, not pixel-level rendering of a UI pill, so no article is affected and no draft docs PR was created. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.40-0 🚀
Bundle Size Analysis (Sentry): |



Explanation of Change
The selected filter pill in the Spend/Search filter bar is rendered by
DropdownButton. Its label is a single joined string (Category: A, B, C, …) that grows with every selected value. The pill is meant to be capped at256pxvia{maxWidth: 256}on the button'sinnerStyles, butstyles.mw100(maxWidth: '100%') was listed after it in the same style array. React Native flattens style arrays last-wins, so the effective cap became100%, which resolves against the growing content and never bounds the pill — so the label runs off the right edge and the filter bar overflows the viewport.This removes
styles.mw100from thatinnerStylesarray so the256pxcap wins again and the existingnumberOfLines={1}truncates the label with an ellipsis.Fixed Issues
$ #95850
PROPOSAL: #95850 (comment)
Tests
Offline tests
This is a UI-only style change with no network dependency, so it behaves identically offline. Same as the Tests above.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-13.at.3.14.38.PM.mov