Skip to content

Fix filter pill overflow by restoring the 256px max width cap - #95943

Merged
mountiny merged 1 commit into
Expensify:mainfrom
ahmdshrif:fix/95850-filter-pill-truncation
Jul 16, 2026
Merged

mountiny merged 1 commit into
Expensify:mainfrom
ahmdshrif:fix/95850-filter-pill-truncation

Conversation

@ahmdshrif

@ahmdshrif ahmdshrif commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The selected filter pill in the Spend/Search filter bar is rendered by DropdownButton. Its label is a single joined string (Category: A, B, C, …) that grows with every selected value. The pill is meant to be capped at 256px via {maxWidth: 256} on the button's innerStyles, but styles.mw100 (maxWidth: '100%') was listed after it in the same style array. React Native flattens style arrays last-wins, so the effective cap became 100%, which resolves against the growing content and never bounds the pill — so the label runs off the right edge and the filter bar overflows the viewport.

This removes styles.mw100 from that innerStyles array so the 256px cap wins again and the existing numberOfLines={1} truncates the label with an ellipsis.

Fixed Issues

$ #95850
PROPOSAL: #95850 (comment)

Tests

  1. Go to the Spend tab.
  2. Click Filters and open the Category filter.
  3. Select enough categories that the joined label is longer than the pill.
  4. Verify the Category pill truncates with an ellipsis at a fixed max width and does not overflow the viewport.
  5. Verify the filter bar stays within the page boundaries, and pills still wrap to a new line when several filters are applied.
  • Verify that no errors appear in the JS console

Offline tests

This is a UI-only style change with no network dependency, so it behaves identically offline. Same as the Tests above.

QA Steps

  1. Go to the Spend tab.
  2. Click Filters and open the Category filter.
  3. Select enough categories that the joined label is longer than the pill.
  4. Verify the Category pill truncates with an ellipsis at a fixed max width and does not overflow the viewport.
  5. Verify the filter bar stays within the page boundaries, and pills still wrap to a new line when several filters are applied.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native Screenshot 2026-07-14 at 6 51 55 PM
Android: mWeb Chrome Screenshot 2026-07-14 at 6 57 51 PM
iOS: Native Simulator Screenshot - iPhone 16 Pro - 2026-07-14 at 18 29 31
iOS: mWeb Safari simulator_screenshot_E8BD5825-7E6D-4173-AD37-593902CBDDC4
MacOS: Chrome / Safari
Screen.Recording.2026-07-13.at.3.14.38.PM.mov

@Pujan92

Pujan92 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@ahmdshrif is this ready for review?

@ahmdshrif
ahmdshrif force-pushed the fix/95850-filter-pill-truncation branch 3 times, most recently from fd5b8aa to aaa30b5 Compare July 14, 2026 16:02
@ahmdshrif
ahmdshrif marked this pull request as ready for review July 14, 2026 16:02
@ahmdshrif
ahmdshrif requested review from a team as code owners July 14, 2026 16:02
@melvin-bot
melvin-bot Bot requested review from Pujan92 and trjExpensify July 14, 2026 16:02
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team July 14, 2026 16:02
@ahmdshrif

Copy link
Copy Markdown
Contributor Author

it's ready now

@ahmdshrif
ahmdshrif force-pushed the fix/95850-filter-pill-truncation branch from aaa30b5 to 07f71e7 Compare July 14, 2026 16:15
@ahmdshrif
ahmdshrif requested a review from a team as a code owner July 14, 2026 16:15
@dannymcclain

Copy link
Copy Markdown
Contributor

Screenshots are looking pretty good to me

@Pujan92

Pujan92 commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp Simulator Screenshot - iPhone 15 Pro - 2026-07-15 at 00 32 15
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-07-15.at.00.30.38.mov
iOS: mWeb Safari Simulator Screenshot - iPhone 15 Pro - 2026-07-15 at 00 32 56
MacOS: Chrome / Safari Screenshot 2026-07-15 at 00 26 47

@Pujan92 Pujan92 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from mountiny July 14, 2026 19:03
@shawnborton

Copy link
Copy Markdown
Contributor

Same, looking good 👍

@mountiny
mountiny merged commit 84a4462 into Expensify:main Jul 16, 2026
35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Jul 16, 2026
53 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against the help site articles under docs/articles.

No help site changes are required.

This PR is a purely cosmetic style fix: it removes styles.mw100 from the filter pill's innerStyles array (and moves the 256px cap to a named filterPillMaxWidth variable) so the selected-filter pill in the Search/Spend filter bar respects its max-width cap and truncates a long label with an ellipsis instead of overflowing the viewport.

There is no change to any user-facing feature, workflow, setting, label, or navigation path — nothing that the help site documents. The way users apply filters, the filter names, and the resulting behavior are all unchanged; only the visual rendering of an over-long pill label is corrected. Since no documented behavior changed, there are no articles to update and no draft docs PR was created.

@ahmdshrif, since no docs changes are needed there is no linked help site PR to review. If you believe a documented behavior did change and a docs update is warranted, let me know and I'll create the draft PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.38-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is a cosmetic, rendering-only fix: it restores a 256px maxWidth cap on the Spend/Search filter pill (DropdownButton) so a long joined label truncates with an ellipsis instead of overflowing the filter bar. No user-facing feature, setting, tab name, button label, or workflow changes.

Expensify's help site (docs/articles) documents what features do and how to use them, not pixel-level styling of an individual UI element. There is nothing in the articles that describes filter-pill truncation or the filter bar's max width, so there's nothing to update. Since no changes are needed, I did not create a draft docs PR.

@ahmdshrif, if you feel a specific article should still be touched here, let me know which one and I'll take another pass.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against the help site articles under docs/articles.

No help site changes are required.

This PR is a purely visual style fix: it restores a 256px max-width cap on the Search/Spend filter pill (DropdownButton) so a long joined label (e.g. Category: A, B, C, …) truncates with an ellipsis instead of overflowing the viewport. It touches only src/components/Search/FilterDropdowns/DropdownButton.tsx and adds a filterPillMaxWidth token to src/styles/variables.ts.

There is no change to any feature name, workflow, setting, tab, or button label — nothing a customer-facing help article describes. Help site content documents product behavior and steps, not pixel-level rendering of a UI pill, so no article is affected and no draft docs PR was created.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants