Skip to content

[Payment due @abzokhattab] [Hold for Submit plan] [No QA] Docs updates for E/A#94319 Split track-expense Submit whisper into two options - #96048

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docs-submit-employer-92704
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docs-submit-employer-92704

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Docs updates for #94319

Expensify/App#94319 splits the track-expense Submit it to someone actionable whisper into two options on the Submit plan (behind the SUBMIT_2026 beta):

  • Submit to a friend – keeps the existing individual recipient picker.
  • Submit to my employer – routes the expense to a submit-enabled workspace, creating a Submit workspace if the user doesn't have one.

What changed in the docs

Updated Track-Expenses.md — the only help-site article that documents the track-expense actionable whisper options ("What you can do with tracked expenses"). It now notes that on the Submit plan the Submit it to someone option is replaced by Submit to a friend and Submit to my employer, with a short explanation of the employer flow (including auto-creating a Submit workspace).

Labels used are copied verbatim from src/languages/en.ts (actionableMentionTrackExpense.submitToFriend / submitToEmployer).

Notes for reviewer

  • This change is gated behind the SUBMIT_2026 beta and applies only to the Submit plan. When the beta is off, the single Submit it to someone option is unchanged, so the existing default behavior is preserved in the article.
  • Since the feature is not yet fully launched, please confirm the timing/wording reflects what users will actually see before publishing.

@abzokhattab, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 14, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#94319 Split track-expense Submit whisper into two options [No QA] Docs updates for E/A#94319 Split track-expense Submit whisper into two options Jul 14, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://7d071159.helpdot.pages.dev ⚡️

Updated articles:

@abzokhattab

abzokhattab commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

i think we should merge this documentation change after the release since the feature is guarded by the beta rn... What do you think @garrettmknight ?

@garrettmknight

Copy link
Copy Markdown
Contributor

Agreed

@stephanieelliott
stephanieelliott marked this pull request as ready for review July 24, 2026 00:42
@stephanieelliott
stephanieelliott self-requested a review as a code owner July 24, 2026 00:42
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, targeted addition to Track-Expenses.md. It adds 4 lines under the existing 'What you can do with tracked expenses' section, documenting how the Submit it to someone option behaves differently on the Submit plan (replaced by Submit to a friend and Submit to my employer). The change is scoped correctly and fits the article's single workflow. This review evaluates only the added lines.

Scores Summary

  • Readability: 8/10 - The new lines are clear, concise, and consistent with the surrounding bulleted list formatting. The auto-created workspace fallback behavior is easy to follow.
  • AI Readiness: 7/10 - The content sits under a compliant task-based heading and uses bolded option names, which aids retrieval. However, the YAML frontmatter keywords were not updated to reflect the new 'Submit plan', 'Submit to a friend', or 'Submit to my employer' search intents.
  • Style Compliance: 6/10 - Button/option names are correctly bolded, but terminology capitalization is inconsistent with governance: 'workspace' and 'Submit workspace' appear lowercase whereas the naming conventions treat Workspace as a proper product term.

Key Findings

  • Positive: The addition correctly bolds all UI option labels (Submit it to someone, Submit to a friend, Submit to my employer), matching the Button Naming Standards.
  • Positive: The change respects the one-workflow-per-article principle and slots cleanly into an existing task-based section without introducing new top-level headings or deeper heading depth.
  • Terminology: 'workspace' / 'Submit workspace' is lowercase in the added lines. Per governance the product term should be Workspace. The existing article already uses lowercase 'workspace' elsewhere, so full-doc consistency is a worthwhile follow-up.
  • Metadata gap: The frontmatter keywords were not updated to capture the new plan-specific search terms, limiting AI retrieval for queries like 'submit to my employer' or 'Submit plan track expense'.
  • Note: The pre-existing frontmatter lacks the internalScope field required by the authoring guidelines. This predates the PR and is not introduced by the diff, but is worth flagging for future cleanup.

Recommendations

  • Priority: Add plan/option terms to the frontmatter keywords (for example: Submit plan, submit to my employer, submit to a friend) so the new content is retrievable.
  • Priority: Standardize capitalization of Workspace in the added lines to match the product term convention.
  • Suggestion: Consider a brief cross-link to Submit plan or workspace-creation documentation if a dedicated article exists, per Cross-Linking Standards (only when a genuine prerequisite article is available).

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md - Small additive change; approvable with minor terminology and metadata follow-ups.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott marked this pull request as draft July 24, 2026 00:49
@stephanieelliott stephanieelliott changed the title [No QA] Docs updates for E/A#94319 Split track-expense Submit whisper into two options [Hold for feature] [No QA] Docs updates for E/A#94319 Split track-expense Submit whisper into two options Jul 24, 2026
@stephanieelliott stephanieelliott changed the title [Hold for feature] [No QA] Docs updates for E/A#94319 Split track-expense Submit whisper into two options [Hold for Submit plan] [No QA] Docs updates for E/A#94319 Split track-expense Submit whisper into two options Jul 30, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review July 30, 2026 23:55
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds 4 lines to Track-Expenses.md documenting that, on the Submit plan, the Submit it to someone actionable-whisper option is replaced by two choices: Submit to a friend and Submit to my employer. The addition is small, well-scoped, and slots cleanly into the existing ## What you can do with tracked expenses section. Labels are copied verbatim from en.ts, which is exactly the right practice for UI-exact terminology.

Scores Summary

  • Readability: 9/10 - Clear, concise sentences that mirror the existing bullet-and-bold pattern; the employer flow (auto-creating a Submit workspace) is explained in plain language.
  • AI Readiness: 8/10 - Uses full, UI-exact option names and lands under an existing task-based heading; no metadata or heading changes required. Slightly reduced only because the plan-conditional ("On the Submit plan") behavior isn't reinforced anywhere retrievable beyond this single sentence.
  • Style Compliance: 9/10 - Option labels are bolded, in sentence case, unquoted, and match the source strings exactly, per the naming conventions. Consistent with the surrounding article.

Key Findings

  • Positive: Labels sourced verbatim from en.ts (submitToFriend / submitToEmployer), satisfying the exact-UI-terminology rule.
  • Positive: Change is additive and preserves the existing default behavior described for the single Submit it to someone option.
  • Positive: New content reuses the established formatting (indented bullets, bold labels, en-dash descriptions) so it reads as a natural extension of the section.
  • Minor: "workspace" / "Submit workspace" are lowercase, whereas governance treats "Workspace" as a capitalized product term. This is consistent with the rest of this article, so no change is required here, but it is worth normalizing article-wide in a future pass.

Recommendations

  • Confirm the exact user-facing wording of "Submit to a friend" and "Submit to my employer" before publish, since the feature is gated behind the SUBMIT_2026 beta and not yet fully launched (as the PR notes).
  • Consider a brief inline note or cross-link clarifying what a "Submit workspace" is for readers unfamiliar with the auto-created workspace concept, if such an article exists.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md - Approved with minor notes; additive, style-compliant change.

Note: Detailed line-by-line feedback has been provided as inline comments.

@abzokhattab

Copy link
Copy Markdown
Contributor

This can be unheld now

@abzokhattab

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot melvin-bot Bot changed the title [Hold for Submit plan] [No QA] Docs updates for E/A#94319 Split track-expense Submit whisper into two options [Payment due @abzokhattab] [Hold for Submit plan] [No QA] Docs updates for E/A#94319 Split track-expense Submit whisper into two options Aug 17, 2026
@melvin-bot

melvin-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

🎯 @abzokhattab, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@stephanieelliott

Copy link
Copy Markdown
Contributor

Looks like this was already covered in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants