Repository navigation
Replace getDisplayNameOrDefault with temporaryGetDisplayNameOrDefault - batch 9 - #96113
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@shubham1206agra The PR is ready |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-15.at.11.40.20.PM.mov |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.36-0 🚀
|
|
🤖 No help site changes required. This PR is an internal code refactor — it threads a Nothing in If you believe a specific user-facing behavior did change and should be documented, let me know which one and I'll take another look. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.38-0 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site files under No help site changes are required. This PR is an internal code migration (batch 9 of replacing Because there is nothing to document, I did not create a draft docs PR. If you believe a specific article is affected, let me know which one and I'll take another look. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.40-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against the articles in This is a purely internal code refactor — part of deprecating There is no user-facing behavior change: display names, labels, flows, feature names, and buttons all render exactly as before. As a result, no HelpDot article documents this behavior and none needs to be created or updated, so I did not open a draft docs PR. @cretadn22, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.40-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66392
PROPOSAL: #66392
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-15.at.01.24.31.mov