Repository navigation
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@linhvovan29546 @NikkiWines @grgia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f47094fed3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@linhvovan29546 |
Prevents the preview from overflowing the right edge on narrow viewports where there's no room to the left and flipping right would run off-screen.
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@ZhenjaHorbach assigned you given this comment - are you able to review this one |
|
Will complete review today or tomorrow morning! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-07-21.10.38.53.movAndroid: mWeb Chrome2026-07-21.10.37.02.moviOS: HybridApp2026-07-21.10.38.53.moviOS: mWeb Safari2026-07-21.10.37.02.movMacOS: Chrome / Safari2026-07-21.10.29.31.mov |
|
LGTM! |
NikkiWines
left a comment
There was a problem hiding this comment.
one very small style request, otherwise looks good
…eviewPosition.ts Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
|
@grgia, what next? |
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.4.45-0 🚀
|
|
🤖 No help site changes required. This PR is a purely visual micro-adjustment to the receipt hover preview: it changes which side of the thumbnail the preview opens on (now prefers the left, flipping right only when there isn't room, with a clamp for narrow viewports). The only files touched are I searched @adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #95975
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-17.at.16.23.36.mov