Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
@shubham1206agra, Could you please take a look at this pr when you get a chance. thanks. |
|
@shubham1206agra, Gentle bump. thanks. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-23.at.4.02.43.PM.mov |
|
@danieldoglas, could you please take a look at this when you get a chance. thanks. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.45-0 🚀
|
Help site review: no changes requiredI reviewed the changes in this PR against the help site articles under Why: This is a purely internal code refactor. It swaps the deprecated Help articles document user-facing features, settings, and flows. Since nothing a user sees, clicks, or reads about has changed, there is no help site content to add or revise. No draft PR was created. @marufsharifi, since no help site changes are required, there is no linked help site PR to review here. If you believe a behavior change in this PR is user-facing and should be documented, reply with the specific behavior and I'll draft the docs PR. |
|
@marufsharifi This PR is failing because of a regression issue #97203 The issue is reproducible in: All environment Bug7219450_1785220484657.12.mp4 |
|
@mitarachim, Thanks for checking. I verified that the same issue is reproducible on production, where this PR is not deployed, so it doesn't appear to be related to the changes in this PR. Screencast.From.2026-07-28.15-19-09.webm |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR changes invoice creation to use the active
useLocalize().formatPhoneNumberformatter instead of importing the deprecatedLocalePhoneNumber.formatPhoneNumberdirectly.User-facing behavior should stay the same. The key thing to verify is that invoices still submit and phone-number receivers still display correctly.
Fixed Issues
$ #66327
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screencast.From.2026-07-18.10-52-05.webm