Repository navigation
Deferring & deprioritizing participant search render - #96485
mjasikowski merged 17 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 189d7f0915
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
I reviewed the PR, but I forgot to request 🤦 |
|
@jmgraa The Unit Tests failed |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApptelegram-cloud-document-5-6278352909478403655.mp4Android: mWeb Chrometelegram-cloud-document-5-6278352909478403656.mp4iOS: HybridAppScreen.Recording.2026-07-24.at.21.25.21.movScreen.Recording.2026-07-24.at.21.24.38.movScreen.Recording.2026-07-24.at.19.56.33.movScreen.Recording.2026-07-24.at.19.55.28.moviOS: mWeb SafariScreen.Recording.2026-07-24.at.21.40.07.movMacOS: Chrome / SafariScreen.Recording.2026-07-24.at.21.32.27.mov |
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.45-0 🚀
|
Help site review — no changes requiredI reviewed the changes in this PR against Expensify's help site articles under Why: This PR is a purely internal rendering-performance optimization. It defers and deprioritizes the render of
There is no change to user-facing behavior, features, flows, UI labels, tab names, settings, or buttons — the Share Extension Submit flow, Choose recipient step, Split expense, and confirmation participant picker all work exactly as before, just faster. Help site articles document what users can do and how, not the app's internal render scheduling, so nothing in Because no docs changes are needed, I did not create a draft help site PR. @jmgraa, if you believe any user-facing behavior actually did change here that should be documented, let me know what it is and I'll draft the corresponding help site PR. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |


Explanation of Change
In the Share Extension submit flow between
ShareTabParticipantsSelectorandSubmitDetailsPage,ParticipantSearchResultsis expensive to render and was competing with navigation transitions.We now treat that render as low priority. When going back from
SubmitDetailsPagetoShareTabParticipantsSelector, the navigation transition completes first, andParticipantSearchResultsmounts only once. That's done usinguseDeferVisibleUntilFocusTransitionEndto wait forTransitionTrackerbefore showing the search again.The same defer applies anywhere MoneyRequestParticipantsSelector is mounted: ShareTabParticipantsSelector, IOURequestStepParticipants, and the confirmation ParticipantPicker in IOURequestStepConfirmation.
DisplayContentsView (previously CustomViewWrapper) was also extracted from ScreenFreezeWrapper so we can reuse the same native underlay during swipe-back without a blank flash.
We didn’t use
ScreenFreezeWrapperhere. It’s been reverted a few times already and similar attempts haven’t worked out well, so we kept this change small and used the defer hook plus theDisplayContentsView.ShareTabParticipantsSelector (ParticipantSearchResults )->SubmitDetailsPageSelecting a recipient immediately triggers a high-priority blocking render of top-level navigation components. The remaining render of ParticipantSearchResults and DisplayContentsView is deferred as low-priority background work, executing within the Idle track after an interrupted render phase completes.
SubmitDetailsPage->ShareTabParticipantsSelector (ParticipantSearchResults )Navigating back executes initial layout and routing updates across the Blocking and Idle tracks. Once complete, a high-priority Blocking render task triggers to process and render the ParticipantSearchResults view.
Sentry ShareExtensionOpenSubmitFlow
Fixed Issues
$ #96613
PROPOSAL:
Tests
iOS Native – Share Extension Submit tab (
ShareTabParticipantsSelector)iOS Native – Choose recipient step + confirmation participant picker modal (
IOURequestStepParticipants+ParticipantPicker)iOS Native – DisplayContentsView swipe-back (
ScreenFreezeWrapper)Android Native – all three mount points
Web – Choose recipient step, split, and confirmation participant picker modal
Offline tests
Share Extension Submit tab + main app participant pickers (offline)
Offline → online recovery on Choose recipient
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_1.mov
android_2.mov
iOS: Native
ios_1.mov
ios_2.mov
ios_3.mov
MacOS: Chrome / Safari
web_1.mov