Skip to content

Deferring & deprioritizing participant search render - #96485

Merged
mjasikowski merged 17 commits into
Expensify:mainfrom
software-mansion-labs:jmgraa/share-participant-activity-freeze
Jul 27, 2026
Merged

mjasikowski merged 17 commits into
Expensify:mainfrom
software-mansion-labs:jmgraa/share-participant-activity-freeze

Conversation

@jmgraa

@jmgraa jmgraa commented Jul 20, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

In the Share Extension submit flow between ShareTabParticipantsSelector and SubmitDetailsPage, ParticipantSearchResults is expensive to render and was competing with navigation transitions.

We now treat that render as low priority. When going back from SubmitDetailsPage to ShareTabParticipantsSelector, the navigation transition completes first, and ParticipantSearchResults mounts only once. That's done using useDeferVisibleUntilFocusTransitionEnd to wait for TransitionTracker before showing the search again.

The same defer applies anywhere MoneyRequestParticipantsSelector is mounted: ShareTabParticipantsSelector, IOURequestStepParticipants, and the confirmation ParticipantPicker in IOURequestStepConfirmation.

DisplayContentsView (previously CustomViewWrapper) was also extracted from ScreenFreezeWrapper so we can reuse the same native underlay during swipe-back without a blank flash.

We didn’t use ScreenFreezeWrapper here. It’s been reverted a few times already and similar attempts haven’t worked out well, so we kept this change small and used the defer hook plus the DisplayContentsView.

ShareTabParticipantsSelector (ParticipantSearchResults ) -> SubmitDetailsPage

forward

Selecting a recipient immediately triggers a high-priority blocking render of top-level navigation components. The remaining render of ParticipantSearchResults and DisplayContentsView is deferred as low-priority background work, executing within the Idle track after an interrupted render phase completes.

SubmitDetailsPage -> ShareTabParticipantsSelector (ParticipantSearchResults )

backward

Navigating back executes initial layout and routing updates across the Blocking and Idle tracks. Once complete, a high-priority Blocking render task triggers to process and render the ParticipantSearchResults view.

Sentry ShareExtensionOpenSubmitFlow

Before After
868ms 423ms
1054ms 575ms
880ms 605ms
801ms 418ms

Fixed Issues

$ #96613
PROPOSAL:

Tests

  1. iOS Native – Share Extension Submit tab (ShareTabParticipantsSelector)

    1. Share a photo or file into Expensify from another app (e.g. Photos, Safari) and open the Submit tab.
    2. Verify the participant list and search input appear after the screen finishes opening (not mid-transition).
    3. Tap a recent chat and verify navigation to submit details is responsive (no multi-second delay).
    4. Go back to the Submit tab, search for a user, select a result, and verify navigation is still responsive.
    5. Repeat steps 2–4 once more to confirm consistent behavior.
  2. iOS Native – Choose recipient step + confirmation participant picker modal (IOURequestStepParticipants + ParticipantPicker)

    1. FAB (+) → Split expense → amount → Choose recipient → verify the participant list loads after the navigation transition completes, then search for and select two participants and tap Next.
    2. Tap the back arrow (swipe-back is not available on this modal step) to return to the amount step, then proceed to Choose recipient again and verify the list reloads correctly with no blank screen or stuck overlay.
    3. Create expense → Manual (routing depends on whether the account has a workspace):
      • With a workspace: FAB (+) → Create expense → Manual → amount → Next → confirmation (workspace auto-assigned). Verify the participant picker modal opens (auto-opens when no recipient is set, or via the recipient field) → select a recipient → verify the modal closes and the recipient appears → re-open the picker and change recipient. Back from confirmation returns to the amount step.
      • Without a workspace: FAB (+) → Create expense → Manual → amount → Next → Choose recipient (full step, not a modal) → select a recipient → confirmation. Verify the list loads after the transition. Back from confirmation returns to Choose recipient; Next from amount again returns to Choose recipient (expected global-create stack: Amount → Choose recipient → Confirmation).
  3. iOS Native – DisplayContentsView swipe-back (ScreenFreezeWrapper)

    1. Open any chat from the LHN and begin an interactive swipe-back gesture — pause mid-gesture and verify the underlying screen remains visible (no blank/opaque area covering the underlay), then complete or cancel the swipe.
  4. Android Native – all three mount points

    1. Share content into Expensify → Submit tab → verify the list loads and selecting a recipient navigates to submit details without noticeable delay.
    2. FAB (+) → Split expense → amount → Choose recipient → verify list loads after transition, search works, multi-select + Next advances the flow, and pressing back + re-entering does not cause a crash or blank screen.
    3. Same Create expense → Manual checks as step 2.iii (workspace → confirmation + modal; no workspace → Choose recipient step). Focus on list load after transition and no blank/stuck overlay — not on changing the Amount ↔ Choose recipient ↔ Confirmation stack.
  5. Web – Choose recipient step, split, and confirmation participant picker modal

    1. FAB (+) → Pay → amount → Choose recipient → verify search autofocuses, list loads, and selecting a recipient advances the flow.
    2. FAB (+) → Split expense → amount → Choose recipient → select two participants → Next → verify the split flow continues.
    3. Same Create expense → Manual checks as step 2.iii (workspace vs no-workspace routing as above).
  • Verify that no errors appear in the JS console

Offline tests

  1. Share Extension Submit tab + main app participant pickers (offline)

    1. Go offline, then share content into Expensify and open the Submit tab.
    2. Verify cached recents load, the offline hint appears in search, and selecting an available offline recipient navigates to submit details.
    3. In the main app (still offline): FAB (+) → Split expense → amount → Choose recipient → verify the same offline list/hint behavior and that selecting cached participants lets the flow continue.
  2. Offline → online recovery on Choose recipient

    1. While on Choose recipient offline, search for a user not in local cache.
    2. Re-enable network connectivity and verify search results update without requiring a full screen reload.

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_1.mov
android_2.mov

iOS: Native

ios_1.mov
ios_2.mov
ios_3.mov

MacOS: Chrome / Safari

web_1.mov

@jmgraa jmgraa changed the title Jmgraa/share participant activity freeze Defer participant search render until navigation transition ends Jul 20, 2026
@codecov

codecov Bot commented Jul 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...rc/hooks/useDeferVisibleUntilFocusTransitionEnd.ts 100.00% <100.00%> (ø)
...atorComponent/ScreenFreezeWrapper/index.native.tsx 100.00% <100.00%> (+5.88%) ⬆️
src/components/DisplayContentsView/index.tsx 0.00% <0.00%> (ø)
...rc/components/DisplayContentsView/index.native.tsx 50.00% <50.00%> (ø)
...s/iou/request/MoneyRequestParticipantsSelector.tsx 0.00% <0.00%> (ø)
... and 11 files with indirect coverage changes

@jmgraa jmgraa changed the title Defer participant search render until navigation transition ends Deferring & deprioritizing participant search render Jul 21, 2026
Comment thread config/eslint/eslint.seatbelt.tsv Resolved
@jmgraa
jmgraa marked this pull request as ready for review July 21, 2026 14:16
@jmgraa
jmgraa requested review from a team as code owners July 21, 2026 14:16
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and linhvovan29546 and removed request for a team and joekaufmanexpensify July 21, 2026 14:16
@melvin-bot

melvin-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 189d7f0915

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@linhvovan29546

Copy link
Copy Markdown
Contributor

I reviewed the PR, but I forgot to request 🤦

@linhvovan29546

Copy link
Copy Markdown
Contributor

@jmgraa The Unit Tests failed

@linhvovan29546

Copy link
Copy Markdown
Contributor

Before
Screenshot 2026-07-24 at 19 20 25
After
Screenshot 2026-07-24 at 19 23 24

@linhvovan29546

linhvovan29546 commented Jul 24, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
telegram-cloud-document-5-6278352909478403655.mp4
Android: mWeb Chrome
telegram-cloud-document-5-6278352909478403656.mp4
iOS: HybridApp
Screen.Recording.2026-07-24.at.21.25.21.mov
Screen.Recording.2026-07-24.at.21.24.38.mov
Screen.Recording.2026-07-24.at.19.56.33.mov
Screen.Recording.2026-07-24.at.19.55.28.mov
iOS: mWeb Safari
Screen.Recording.2026-07-24.at.21.40.07.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-24.at.21.32.27.mov

@melvin-bot
melvin-bot Bot requested a review from mjasikowski July 24, 2026 14:56
@mjasikowski
mjasikowski merged commit 8214852 into Expensify:main Jul 27, 2026
35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.45-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no changes required

I reviewed the changes in this PR against Expensify's help site articles under App/docs/articles and no documentation updates are required.

Why: This PR is a purely internal rendering-performance optimization. It defers and deprioritizes the render of ParticipantSearchResults so it doesn't compete with navigation transitions, via:

  • A new useDeferVisibleUntilFocusTransitionEnd hook and React Activity mode toggling in MoneyRequestParticipantsSelector.
  • A new DisplayContentsView component (extracted from ScreenFreezeWrapper) to avoid a blank flash during swipe-back.

There is no change to user-facing behavior, features, flows, UI labels, tab names, settings, or buttons — the Share Extension Submit flow, Choose recipient step, Split expense, and confirmation participant picker all work exactly as before, just faster. Help site articles document what users can do and how, not the app's internal render scheduling, so nothing in App/docs/articles (e.g. Split-Expenses.md, Create-an-Expense.md) needs to be updated.

Because no docs changes are needed, I did not create a draft help site PR.

@jmgraa, if you believe any user-facing behavior actually did change here that should be documented, let me know what it is and I'll draft the corresponding help site PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants