Repository navigation
Replace getDisplayNameOrDefault with temporaryGetDisplayNameOrDefault - batch 12 - #96586
Conversation
…ion for display names in tooltips. Adjusted related components to utilize the new translation feature, improving user experience in reports and IOU request
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@shubham1206agra over to you |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-22.at.1.25.07.PM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.43-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR and no updates to Expensify's help site files under Why: This is a purely internal code refactor (batch 12 of the There are:
Since the help site describes product behavior and workflows — none of which changed here — there's nothing to update. @cretadn22, since no help site changes are required, there's no linked docs PR to review. If you believe a doc update is warranted, let me know what behavior changed and I'll create one. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.43-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66392
PROPOSAL: #66392
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-22.at.11.30.18.mov