Repository navigation
[No QA] Docs updates for E/A#96603 correct member vs admin room open flow - #96713
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
#96603 removed the
workspaceRoomsPagebeta and released the Workspace Rooms page (the Rooms directory) to all workspace members and admins.The existing help article
Find Rooms in a Workspacealready covers the feature and contained no beta-gating language, so it did not need to be un-gated. However, it described the row-click behavior inaccurately for members.Per
WorkspaceRoomsPage.tsx, selecting a room behaves differently by role:The article previously said everyone opens a details page and then clicks Go to room. This PR corrects the navigation steps and the "What happens after you open a room" section to distinguish the admin and member flows.
Files changed
docs/articles/new-expensify/chat/Find-Rooms-in-a-Workspace.md@sumo-slonik, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.