Repository navigation
Conversation
…Policy/Domain Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc2ef82c42
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…r/no-useOnyx-dependencies-arg
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
# Conflicts: # src/pages/DynamicReportDetailsPage.tsx
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-24.at.06.09.53.mp4 |
|
@sosek108 Eslinter failed on |
| const currentUserPersonalDetails = useCurrentUserPersonalDetails(); | ||
| const filteredPoliciesInfoSelector = useMemo(() => createFilteredPoliciesInfoSelector(currentUserPersonalDetails?.email), [currentUserPersonalDetails?.email]); | ||
| const [filteredPoliciesInfo] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {selector: filteredPoliciesInfoSelector}); | ||
| const [filteredPoliciesInfo] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {selector: createFilteredPoliciesInfoSelector(currentUserPersonalDetails?.email)}); |
There was a problem hiding this comment.
restore the useMemo in DynamicReportDetailsPage.tsx (it doesn't compile, so the compiler won't re-memoize the selector)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.45-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site content under No help site changes are required. This PR is an internal code refactor — part of the useOnyx dependencies-argument removal (Batch G). It drops the deprecated 3rd Since nothing customer-facing changed, there's nothing to document or update on the help site, so I did not create a draft docs PR. @sosek108, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Part of the useOnyx dependencies-argument removal (#94595), Batch G of the split: Workspace / Policy / Domain / Dynamic report. Drops the deprecated 3rd useOnyx argument; selectors kept stable (inline/compiler-memoized). No intended behavior change. The main wrapper still accepts the arg, so this batch is independent.
Fixed Issues
$ #95580
PROPOSAL:
Tests
Have two sessions with two separate users
Workspaces list / Workspace’s members list
Report’s workspace information
Workspace rooms
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Nagranie.z.ekranu.2026-07-22.o.14.12.09.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-07-22.o.14.06.06-kopia.mov