Repository navigation
Fix safe area horizontal padding for CenteredModalLayout - #96859
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@gijoe0295 @truph01 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-07-24.at.15.44.52.movScreen.Recording.2026-07-24.at.15.44.23.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #95954 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.45-0 🚀
|
|
🤖 I reviewed the changes in this PR and no help site changes are required under Why: This is a purely internal UI-rendering fix. It adds a platform-split There is no change to any user-facing feature, setting, label, workflow, or behavior that the help site documents — the affected content (e.g. the Concierge AI promo modal) simply renders with correct padding. HelpDot articles describe what features do and how to use them, not layout/padding rendering details, so nothing needs updating. No draft PR was created, since there are no help site updates to make. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
CenteredModalLayoutlost horizontal safe-area padding on iOS because the modal is presented as a native-stacktransparentModaloutside the app-levelSafeAreaView. Added a platform-splituseSafeAreaHorizontalPaddinghook (iOS appliesStyleUtils.getPlatformSafeAreaPaddinginsets, other platforms no-op to avoid double-padding) and moved the component into a folder to hold the platform files.Fixed Issues
$ #95954
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-23.at.11.11.56.mov
iOS: Native
Screen.Recording.2026-07-23.at.09.52.45.mov