Repository navigation
Fix - Split Expense - Splitting is possible when the sum of splits is not equal to the total - #96875
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-07-26.at.19.47.10.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-07-26.at.19.44.56.moviOS: mWeb SafariScreen.Recording.2026-07-26.at.19.46.23.movMacOS: Chrome / SafariScreen.Recording.2026-07-26.at.19.39.48.movScreen.Recording.2026-07-26.at.19.42.38.mov |
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.45-0 🚀
|
|
🤖 I reviewed the changes in this PR and no help site documentation updates are required, so I did not create a draft PR. Why: This is a purely internal bug fix. The only change is to The Help site articles under @FitseTLT — since no help site changes are needed, there is no linked docs PR to review. If you believe an article should be updated to describe this behavior, let me know and I'll create one. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The merchant live-clear was sharing the focus-reset effect in
useFormErrorManagement, which putisMerchantFieldValidin that effect's dependencies. Saving a merchant therefore re-ran the focus-reset, whose blanket "clear every non-violations.error" wiped the still-valid split error, letting a mismatched split through.Moved the merchant live-clear into its own effect and removed
isMerchantFieldValidfrom the focus-reset dependencies, so a merchant edit can no longer trigger that clear.Fixed Issues
$ #94572
PROPOSAL: #94572 (comment)
Tests
Offline tests
Same as tests.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2026-07-23.16-08-01.mp4
Android: mWeb Chrome
2026-07-23.16-11-46.mp4
iOS: Native
2026-07-23.16-23-51.mp4
iOS: mWeb Safari
2026-07-23.16-14-03.mp4
MacOS: Chrome / Safari
2026-07-23.15-34-45.mp4