Skip to content

Prevent tasks from inheriting a group chatType and showing the Not here page - #97019

Merged
Valforte merged 9 commits into
Expensify:mainfrom
MobileMage:MobileMage/fix-96421-task-leave-notfound
Jul 31, 2026
Merged

Valforte merged 9 commits into
Expensify:mainfrom
MobileMage:MobileMage/fix-96421-task-leave-notfound

Conversation

@MobileMage

@MobileMage MobileMage commented Jul 25, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When an assignee opens a task created inside a group chat, the backend returns the task report carrying the parent group chat's chatType (for example group). That inheritance is intentional, but isRootGroupChat excluded threads using isChatThread, which requires type === CHAT. A task's type is TASK, so it slipped past the exclusion and read as the root group chat.

Once the task counts as a root group chat, canLeaveChat returns true, so a Leave row shows on the task details page, and leaveChat runs the destructive leaveGroupChat instead of leaveRoom. leaveGroupChat nulls the report's reportID; the focused details RHP wraps in withReportOrNotFound, whose gate flips to shouldShowNotFoundPage the moment reportID goes null, so the page renders the full "Not here" screen before the deferred dismissal moves the user away.

This PR swaps that one exclusion to isThread, which is type-agnostic, so a task off a group chat is no longer the root group chat. The inherited chatType is left untouched, matching the backend. canLeaveChat then returns false for the task, the Leave row disappears, and the destructive path becomes unreachable. Unit tests cover this in tests/unit/ReportUtilsTest.ts.

Fixed Issues

$ #96421
PROPOSAL: #96421 (comment)

Tests

  1. Create a task in a group chat.
  2. Open the task.
  3. Open the task report details.
  4. Verify there is no Leave option.
  • Verify that no errors appear in the JS console

Offline tests

No offline-specific behavior. The classification reads local Onyx data only.

  • Verify that no errors appear in the JS console

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Videos will be added in a few hours.

Android: Native
97019-android-native.mp4
Android: mWeb Chrome
97019-android-mweb.mp4
iOS: Native
97019-ios-native.mp4
iOS: mWeb Safari
97019-ios-mweb.mp4
MacOS: Chrome / Safari
97019-macos-chrome.mp4

A task inside a group chat is returned by the backend carrying the
parent's chatType (e.g. group). getChatType now drops that inherited
value for non-#admins tasks, so isGroupChat/isRootGroupChat/canLeaveChat
no longer misclassify the task, the bogus Leave row and destructive
leaveGroupChat path disappear, and the details page stops flashing the
Not-here page. Keeps the intentional POLICY_ADMINS inheritance.
Fixes Expensify#96421.
@codecov

codecov Bot commented Jul 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/ReportUtils.ts 86.54% <100.00%> (+0.39%) ⬆️
... and 662 files with indirect coverage changes

Tasks no longer classify as their parent's chat type, so a wiped
group-inherited task stopped matching isGroupChat in
isRemovalExpectedForReportType and the user would stay on the Not-here
page instead of redirecting. Treat task removals as expected for the
task type itself. Also pin canLeaveChat(task) === false and add a
policy-room-inherited task case to the classification tests.
Give the fixture a visible participant so the assertion exercises the
classification path rather than passing through hidden-membership.
@MobileMage
MobileMage marked this pull request as ready for review July 29, 2026 22:26
@MobileMage
MobileMage requested review from a team as code owners July 29, 2026 22:26
@melvin-bot
melvin-bot Bot requested review from bernhardoj and removed request for a team July 29, 2026 22:26
@melvin-bot

melvin-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team July 29, 2026 22:26
@MobileMage

Copy link
Copy Markdown
Contributor Author

@bernhardoj @trjExpensify ready for review. I've attached recordings for all five platforms.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17f26677ab

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

isAnnounceRoom(prevReport) ||
// Tasks no longer classify as their parent's chat type (see getChatType), so removal
// must be expected for the task type itself to keep the Concierge redirect working.
isTaskReport(prevReport));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate task removals to the current report

When this ReportScreen instance is retargeted to another report before that report's Onyx value has loaded, report is empty while prevReport still points at the previous task. This new task branch then treats the route change as a task removal and calls navigateAwayFromReport() with the old task's parent, hijacking navigation away from the report the user just opened; the deletion hook already has route-change protection, so the task case should also require an actual removal of the current route's report (e.g. wasReportRemoved) before redirecting.

Useful? React with 👍 / 👎.

A retarget to a report whose Onyx value has not loaded yet left prevReport
pointing at the previous task, which read as a removal and redirected away
from the report the user had just opened.
@bernhardoj

Copy link
Copy Markdown
Contributor

@MobileMage I approved the alternative solution, so let's go with that

@MobileMage

Copy link
Copy Markdown
Contributor Author

@bernhardoj Valforte said the inheritance covers any type except policyExpenseChat, selfDM and system. So a task in a #room still comes through as a policy room, canLeaveChat is true, and leaving hits leaveRoom's wiping branch. I think what I can do is the !isThread switch plus an early isTaskReport return in canLeaveChat, so the other inherited types are covered too.

@bernhardoj

Copy link
Copy Markdown
Contributor

Valforte #96421 (comment) the inheritance covers any type except policyExpenseChat, selfDM and system.

Yes, what you are doing right now is the opposite. The BE intentionally set the chatType for a task to its parent chatType, except the parent is policyExpenseChat, selfDM and system. But the current solution updates getChatType to return undefined. It's inconsistent with the BE.

The backend intentionally gives a task its parent's chatType, so stripping it
in getChatType fought that contract. isChatThread only matches type CHAT, which
let a task off a group chat read as the root group chat; excluding via isThread
covers it and leaves the inherited chatType intact.

Also reverts the ReportNavigateAwayHandler change, which was only needed while
getChatType stopped returning the inherited type.
Comment thread tests/actions/TaskTest.ts Outdated
});
});

describe('task chatType classification (#96421)', () => {

@bernhardoj bernhardoj Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have isRootGroupChat test cases in ReportUtilsTest.ts. Let's add more to that instead of creating a new one.

@bernhardoj

bernhardoj commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome image
iOS: HybridApp image
iOS: mWeb Safari image
MacOS: Chrome / Safari image

@bernhardoj

Copy link
Copy Markdown
Contributor

@MobileMage we can simplify the test steps to just create a task in a group chat, open it, open the task report details and verify there is no Leave option.

Comment thread tests/unit/ReportUtilsTest.ts Outdated
expect(isRootGroupChat(report)).toBe(false);
});

it('should return false if the report is a task off an #admins room', () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't touch anything with the admins room type, so let's remove this.

Comment thread tests/unit/ReportUtilsTest.ts Outdated
parentReportActionID: '67890',
};

expect(isGroupChat(report)).toBe(true);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are testing isRootGroupChat here, so let's remove this.

Comment thread tests/unit/ReportUtilsTest.ts Outdated

it('should return false if the report is a task off a group chat', () => {
// The backend gives a task its parent's chatType, so this task reads as a group chat. It is
// still a thread off that chat, and `isChatThread` misses it because a task is not type CHAT.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment isn't needed. We already explain it in the function itself. Let's remove it.

Comment thread tests/unit/ReportUtilsTest.ts Outdated

it('should return false for a task off a group chat', () => {
// A task inherits the parent group chat's chatType, but leaving it would run the
// destructive group-chat path, so the Leave row must stay hidden. See #96421.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this whole comment too. (Note: it's advisable not to leave an issue number/link in a comment)

@bernhardoj bernhardoj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some NAB comments above

@melvin-bot
melvin-bot Bot requested a review from Valforte July 30, 2026 13:27
@MobileMage

Copy link
Copy Markdown
Contributor Author

Thanks @bernhardoj , I'm fixing those now

@Valforte
Valforte merged commit c3c34db into Expensify:main Jul 31, 2026
33 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Valforte has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 1, 2026
60 tasks done
@OSBotify

OSBotify commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Valforte in version: 9.4.48-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is an internal bug fix, not a user-facing feature or workflow change. It swaps one exclusion in ReportUtils.isRootGroupChat from isChatThread to isThread so a task created inside a group chat no longer inherits the parent's chatType and reads as a root group chat. The visible effect is a regression fix: the erroneous Leave row on a task's details page (and the resulting "Not here" screen) is removed.

Why no docs update is needed
  • The change is purely to an internal report-classification helper — no new setting, tab, button, feature name, or workflow is added or renamed.
  • The corrected behavior (tasks are not group chats and have no Leave option) is the intended behavior, so it already matches any help-site description; nothing in docs/articles documents leaving a task or this classification.
  • A search of docs/articles found no article covering a "Leave" action on tasks or the task details page, so there's no content to reconcile.

@MobileMage, no linked help site PR was created since no docs/articles changes are needed. If you believe a help article should be updated to clarify task behavior, let me know and I'll draft one.

@OSBotify

OSBotify commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.48-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants