Repository navigation
[INP] Improve UserListItem-Checkbox INP: paint the checkmark optimistically and run the selection update as a transition #97140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rlinoz
merged 15 commits into
Expensify:main
from
David-2002065:dilshod/fix-94722-checkbox-inp
Aug 12, 2026
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
df2eb9e
perf: paint checkbox optimistically and run the selection update as a…
David-2002065 0bead3c
fix: keep selected radio checked on re-press in ListSelectionButton
David-2002065 d136ff4
chore: re-trigger CI (flaky unrelated SplitTest)
David-2002065 8d4940f
fix: reset optimistic check on row recycle and build group draft from…
David-2002065 865a2b0
fix: make stale-control presses safe during the pending selection window
David-2002065 11ce4d9
fix: gate selectOption on the latest-selection ref during the pending…
David-2002065 48bed78
Merge remote-tracking branch 'origin/main' into dilshod/fix-94722-che…
David-2002065 1bce90f
Simplify comments in own words per review
David-2002065 25db28c
Shorten comments
David-2002065 148175e
Make the optimistic checkmark opt-in so shared list rows are unchange…
David-2002065 4cf7871
Scope the deferred selection update to web so native rapid taps aren'…
David-2002065 a18c743
Revert platform-specific getPlatform gate; keep the deferred update c…
David-2002065 45bb0b4
Keep the self-DM row inert while a group selection is pending
David-2002065 6d948de
Route the confirm shortcut through the pending selection ref
David-2002065 22170c2
Merge remote-tracking branch 'upstream/main' into dilshod/fix-94722-c…
David-2002065 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.