Repository navigation
Fix error flash when opening the Attendees field - #97176
Conversation
Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>
|
@MelvinBot Fill the Author checklist. Check all the items, I will verify them later. |
|
✅ Done — I checked all 38 items in the PR Author Checklist section. I left the two "Verify that no errors appear in the JS console" boxes in the Tests and QA Steps sections unchecked, since those are test/QA steps rather than the Author Checklist. Let me know if you'd like those checked too. As requested, please verify the items yourself before merging. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-28.at.9.19.26.AM.mov |
|
There's no code fix to push here — the code change itself is passing all CI. The only failing check is PR Author Checklist / checklist, which failed with:
That's not a code problem — it just means the author checklist boxes in the PR description haven't been ticked. It's resolved by you (the author) editing the PR description and checking off each item, not by a commit. Every actual code check is green:
The perf tests ( I also verified the diff is sound: the added Next step: complete the author checklist in the PR description to clear the last check. |
|
@MelvinBot Please mark it as "Ready for review" |
|
@hoangzinh @shubham1206agra One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
✅ Done — I marked this PR as Ready for review. It's out of draft state now. |
trjExpensify
left a comment
There was a problem hiding this comment.
Follow-up fix to a refactor PR 👍
|
🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Fix error flash when opening the Attendees field (cherry picked from commit 551dbcd) (cherry-picked to staging by marcaaron)
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.45-12 🚀
|
|
🤖 I reviewed the changes and no help site updates are required. This PR is a purely internal bug fix. It gates an existing error message on the const shouldShowErrorMessage = areOptionsInitialized && selectedOptions.length < 1;There is no change to documented, user-facing behavior:
Since nothing in |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.46-0 🚀
|
|
🤖 I reviewed the changes in this PR and no help site updates are required. Why: This is a one-line bug fix that only gates an existing validation error so it no longer flashes transiently while the attendee options are still loading: const shouldShowErrorMessage = areOptionsInitialized && selectedOptions.length < 1;There is no change to any user-facing feature, setting, label, workflow, or behavior that the help site documents. The Adding attendees flow ( Since no docs change is needed, I did not create a draft help site PR. @shubham1206agra, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The Attendees selector briefly flashed a red "At least one attendee is required" error when opening an expense that already had a default attendee.
After #96440 migrated this selector to
usePersonalDetailSearchSelector,selectedOptionsis now derived asynchronously fromoptionsWithContacts. The default attendee (the current user, who exists in personal details) lives only in theselectedAccountIDsSet, so until options finish loadingselectedOptionsis empty and the error renders, then clears once options initialize.The option list is already gated on
areOptionsInitialized, but the footer error was not. This change gates the error message the same way so it only appears once options have loaded and the user has genuinely deselected all attendees:Fixed Issues
$ #97163
PROPOSAL: #97163 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari