Skip to content

Fix error flash when opening the Attendees field - #97176

Merged
stitesExpensify merged 1 commit into
mainfrom
claude-attendeeErrorFlash
Jul 28, 2026
Merged

stitesExpensify merged 1 commit into
mainfrom
claude-attendeeErrorFlash

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The Attendees selector briefly flashed a red "At least one attendee is required" error when opening an expense that already had a default attendee.

After #96440 migrated this selector to usePersonalDetailSearchSelector, selectedOptions is now derived asynchronously from optionsWithContacts. The default attendee (the current user, who exists in personal details) lives only in the selectedAccountIDs Set, so until options finish loading selectedOptions is empty and the error renders, then clears once options initialize.

The option list is already gated on areOptionsInitialized, but the footer error was not. This change gates the error message the same way so it only appears once options have loaded and the user has genuinely deselected all attendees:

const shouldShowErrorMessage = areOptionsInitialized && selectedOptions.length < 1;

Fixed Issues

$ #97163
PROPOSAL: #97163 (comment)

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>
@shubham1206agra

Copy link
Copy Markdown
Contributor

@MelvinBot Fill the Author checklist. Check all the items, I will verify them later.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ Done — I checked all 38 items in the PR Author Checklist section.

I left the two "Verify that no errors appear in the JS console" boxes in the Tests and QA Steps sections unchecked, since those are test/QA steps rather than the Author Checklist. Let me know if you'd like those checked too.

As requested, please verify the items yourself before merging.

@shubham1206agra

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-28.at.9.19.26.AM.mov

@melvin-bot
melvin-bot Bot requested review from mountiny and stitesExpensify July 28, 2026 03:50
@MelvinBot

Copy link
Copy Markdown
Contributor Author

There's no code fix to push here — the code change itself is passing all CI.

The only failing check is PR Author Checklist / checklist, which failed with:

You completed 0 out of 38 checklist items with 38 unfinished items

That's not a code problem — it just means the author checklist boxes in the PR description haven't been ticked. It's resolved by you (the author) editing the PR description and checking off each item, not by a commit.

Every actual code check is green:

  • ✅ typecheck
  • ✅ test (jobs 1–8)
  • ✅ Bun tests, ESLint check, Oxfmt check, React Compiler Compliance, Check for unused styles, spellcheck, and the rest

The perf tests (baseline-perf-tests / branch-perf-tests) were still running when I checked — those are benchmarks, not correctness failures.

I also verified the diff is sound: the added areOptionsInitialized guard in shouldShowErrorMessage is already destructured from usePersonalDetailSearchSelector and used elsewhere in the same file, so it's in scope and type-safe.

Next step: complete the author checklist in the PR description to clear the last check.

@shubham1206agra

Copy link
Copy Markdown
Contributor

@MelvinBot Please mark it as "Ready for review"

@MelvinBot
MelvinBot marked this pull request as ready for review July 28, 2026 03:52
@MelvinBot
MelvinBot requested a review from a team as a code owner July 28, 2026 03:52
@melvin-bot
melvin-bot Bot requested review from hoangzinh and shubham1206agra and removed request for a team July 28, 2026 03:52
@melvin-bot

melvin-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

@hoangzinh @shubham1206agra One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team July 28, 2026 03:53
@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ Done — I marked this PR as Ready for review. It's out of draft state now.

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up fix to a refactor PR 👍

@stitesExpensify
stitesExpensify merged commit 551dbcd into main Jul 28, 2026
48 of 49 checks passed
@stitesExpensify
stitesExpensify deleted the claude-attendeeErrorFlash branch July 28, 2026 15:17
@github-actions

Copy link
Copy Markdown
Contributor

🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jul 29, 2026
Fix error flash when opening the Attendees field

(cherry picked from commit 551dbcd)

(cherry-picked to staging by marcaaron)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 29, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.45-12 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I reviewed the changes and no help site updates are required.

This PR is a purely internal bug fix. It gates an existing error message on the areOptionsInitialized flag so the "At least one attendee is required" error no longer briefly flashes while the Attendees selector is still loading its options:

const shouldShowErrorMessage = areOptionsInitialized && selectedOptions.length < 1;

There is no change to documented, user-facing behavior:

  • Attendees still work the same way, and at least one attendee is still required.
  • The help article Adding-Attendees.md documents how to add attendees to an expense — it does not describe loading states or validation-error timing, which is all this PR touches.

Since nothing in docs/articles describes the behavior being changed, no draft docs PR was created.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.46-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I reviewed the changes in this PR and no help site updates are required.

Why: This is a one-line bug fix that only gates an existing validation error so it no longer flashes transiently while the attendee options are still loading:

const shouldShowErrorMessage = areOptionsInitialized && selectedOptions.length < 1;

There is no change to any user-facing feature, setting, label, workflow, or behavior that the help site documents. The Adding attendees flow (App/docs/articles/new-expensify/reports-and-expenses/Adding-Attendees.md) still describes the feature accurately — adding/removing attendees and the "at least one attendee is required" validation all work exactly as documented; the fix simply stops that error from briefly appearing before options finish loading.

Since no docs change is needed, I did not create a draft help site PR.

@shubham1206agra, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants