Repository navigation
fix: keep Search Router results above offline indicator #97211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carlosmiceli
merged 23 commits into
Expensify:main
from
nabi-ebrahimi:97182-search-router-offline-scroll
Aug 4, 2026
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
026c099
fix: keep Search Router results above offline indicator
nabi-ebrahimi 95ad39c
fix: constrain Search Router height when keyboard is open
nabi-ebrahimi a578c4c
Merge branch 'main' into 97182-search-router-offline-scroll
nabi-ebrahimi c69f546
fix: scale Spend navigation context for large fonts
nabi-ebrahimi f13bab4
fix: prevent Search Router results from overflowing keyboard padding
nabi-ebrahimi 09226ae
Revert offline Search Router scroll workaround
nabi-ebrahimi 7963b4c
Merge branch 'main' into 97182-search-router-offline-scroll
nabi-ebrahimi 442ac01
fix: constrain native Search Router above keyboard
nabi-ebrahimi 025fbea
fix: normalize Search Router keyboard height
nabi-ebrahimi db09851
fix: scope Search Router height cap to offline mode
nabi-ebrahimi 1964fdd
fix: reserve space for Search Router offline indicator
nabi-ebrahimi 76da89e
docs: explain native Search Router height calculation
nabi-ebrahimi c11ea83
refactor: use StyleUtils for Search Router max height
nabi-ebrahimi 0a4887d
Merge branch 'main' into 97182-search-router-offline-scroll
nabi-ebrahimi cdcf87c
refactor: clarify Search Router keyboard height calculation
nabi-ebrahimi 5b49ac9
docs: clarify Search Router height constraint
nabi-ebrahimi 7bfb2c5
test: cover Search Router available height calculation
nabi-ebrahimi 10d3495
test: cover Search Router offline indicator padding
nabi-ebrahimi 68f00f5
Merge branch 'main' into 97182-search-router-offline-scroll
nabi-ebrahimi 424fe11
refactor: clarify offline keyboard height constraint
nabi-ebrahimi 0b53a71
test: remove redundant padding type assertion
nabi-ebrahimi c7769cc
test: explain Search Router padding snapshot selection
nabi-ebrahimi 1f60a6e
Merge branch 'main' into 97182-search-router-offline-scroll
nabi-ebrahimi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import {getAvailableHeight} from '@components/Search/SearchRouter/SearchRouterPage/index.native'; | ||
|
|
||
| describe('SearchRouterPage', () => { | ||
| it('does not constrain the height when the keyboard is not overlapping', () => { | ||
| expect( | ||
| getAvailableHeight({ | ||
| isKeyboardOverlapping: false, | ||
| keyboardHeight: 300, | ||
| keyboardActiveHeight: 300, | ||
| bottomInset: 0, | ||
| windowHeight: 800, | ||
| paddingTop: 20, | ||
| }), | ||
| ).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('uses the settled keyboard height', () => { | ||
| expect( | ||
| getAvailableHeight({ | ||
| isKeyboardOverlapping: true, | ||
| keyboardHeight: 300, | ||
| keyboardActiveHeight: 350, | ||
| bottomInset: 0, | ||
| windowHeight: 800, | ||
| paddingTop: 20, | ||
| }), | ||
| ).toBe(480); | ||
| }); | ||
|
|
||
| it('falls back to the active keyboard height during animation', () => { | ||
| expect( | ||
| getAvailableHeight({ | ||
| isKeyboardOverlapping: true, | ||
| keyboardHeight: 0, | ||
| keyboardActiveHeight: 300, | ||
| bottomInset: 0, | ||
| windowHeight: 800, | ||
| paddingTop: 20, | ||
| }), | ||
| ).toBe(480); | ||
| }); | ||
|
|
||
| it('clamps transient negative heights to zero', () => { | ||
| expect( | ||
| getAvailableHeight({ | ||
| isKeyboardOverlapping: true, | ||
| keyboardHeight: 500, | ||
| keyboardActiveHeight: 500, | ||
| bottomInset: 0, | ||
| windowHeight: 400, | ||
| paddingTop: 20, | ||
| }), | ||
| ).toBe(0); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.