Repository navigation
Conversation
…tion-over-configuration-feature-training
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…tion-over-configuration-feature-training
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85562f583f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
I'll review since this is a part of #90820 |
| shouldCloseOnConfirm = true, | ||
| shouldUseScrollView = false, |
There was a problem hiding this comment.
Looks like here also we need to use composition instead of config flags.
There was a problem hiding this comment.
I'd have a small push back on shouldUseScrollView:
ScrollViewis not just opted in by consumers but also controlled by provider whileisInLandscapeMode- It also wraps the hidden
ProbePagelayer inFeatureTrainingCarouselso we can't easily extract it - Extracting also causes confusion for future engineers when to use it
I'd categorize it as these exclusion rules:
There was a problem hiding this comment.
It looks like this doesn't exist anymore?
There was a problem hiding this comment.
I removed shouldCloseOnConfirm but kept shouldUseScrollView here
There was a problem hiding this comment.
Ah, I see. The exception is probably OK in this instance.
|
@MelvinBot review |
|
🤖 Reviewed the refactor. Overall this is a clean, well-executed composition-over-config split — the primitives are small and single-purpose, state/actions are cleanly separated into two contexts, and behavior looks preserved against the old ✅ The Codex P2 double-close is resolved. In Two minor, non-blocking notes:
The CONSISTENCY-13 prop-doc nits from the bot look already addressed in commit Note: I reviewed statically and did not run a live smoke test (the CI session couldn't sign in this run); the author's cross-platform screenshots and green CI cover the runtime side. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-08-21.at.4.16.34.PM.movSimulator.Screen.Recording.-.iPhone.16.Pro.-.2026-08-21.at.16.25.04.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-08-21.at.9.16.28.AM.mov |
|
@mjasikowski Gentle bump for review here |
mjasikowski
left a comment
There was a problem hiding this comment.
@gijoe0295 @ShridharGoel there are some small testing gaps that could be improved, but for the sake of not making this PR any larger LGTM
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.4.63-0 🚀
|
|
🤖 No help site changes required — I did not open a docs PR. This PR is a pure code-architecture refactor with no change to customer-facing behavior or copy:
The 40 changed files are all React components, pages, and one test — none introduce or rename a user-facing feature, workspace setting, tab, or button. Help site articles under @gijoe0295, if you believe any of these modals changed user-visible copy or flow that a help article covers, let me know which article and I'll draft the update. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Refactor the
FeatureTrainingContentcomponents to follow composition over configuration rule. Also fix several bugs from theAIFeaturesPromoModal.Fixed Issues
$ #90820
$ #95853
PROPOSAL:
Tests
/home/ai-features-promoOffline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-13.at.03.23.49.mov
Android: mWeb Chrome
Screen.Recording.2026-08-13.at.03.25.00.mov
iOS: Native
Screen.Recording.2026-08-13.at.03.21.57.mov
iOS: mWeb Safari
Screen.Recording.2026-08-13.at.03.20.02.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-13.at.03.19.23.mov