Repository navigation
Make report, expense, and member values copyable - #97277
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b6ff4f686
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@x-dev90 Pls always respond to all codex reviews if you don't agree with the review you should still state it putting 👎 reaction to the comment. |
|
@codex REVIEW |
|
Hi @FitseTLT, I’ve addressed the automated review feedback and pushed the updates. Could you please take another look when you have a chance? Thank you! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90714cc808
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@FitseTLT, Gentle bump. thanks. |
|
@FitseTLT ,Quick bump. Thanks! |
|
When cells are truncated selection doesn't select all text but if you select beyond the current cell it will select whole text 2026-08-03.18-40-57.mp4 |
Hmm I know it is selectable on main but I don't see a use of being selectable. WDYT @JS00001 we are talking about this
|
|
I think it is fine that that isnt selectable |
|
@FitseTLT I'm finishing up my review, do you want to re-review w/ the latest changes? |
|
@JS00001, Please hold off on merging this, i will do another round of testing and let you know. thanks. |
|
Hi @FitseTLT and @JS00001, upstream commit 253253c reverted the report inline-input implementation, so these fields are menu items again. It also removed the selection behavior added by this PR. Screencast.From.2026-10-14.16-19-31.mp4 |
Why is it reverted? if it is temporary then the changes are not necessary they will reapply it. We can ignore it cc @JS00001 |
@FitseTLT, Since you agreed that this label shouldn’t be selectable or copied, I’ll fix the bug I reported in this comment by making the Receipt label non-selectable and non-copyable. I’m working on this now. |
|
lmk when this is re-ready please |
@JS00001 , Thanks! I’ve retested all affected flows, and everything is working as expected on my side. As agreed in this feedback, I did not make any additional changes to the report fields because the upstream revert is temporary and the original implementation is expected to be restored. |
|
lets @x-dev90 please keep an eye out for blockers |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.10-0 🚀
|
|
No help site update needed. This PR lets you select and copy text inside clickable rows, which is how users already expect the app to behave, and no article under |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.12-0 🚀
|
|
No help site update needed. This PR lets you select and copy text inside clickable rows, which is how users already expect the app to behave, and no article under |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
This PR improves copy/paste behavior for values rendered inside interactive rows.
Many amount, report, expense, and member values are displayed inside pressable components. Those components can disable native text selection or intercept the mouse-down and press events required to begin selection, making it difficult to copy individual values without triggering the row action.
The PR introduces an opt-in copyable-text flow that:
The flow is applied across the affected areas, including:
SelectionScraperwas updated to preserve explicitly marked copyable values while continuing to exclude content that should not be copied, such as controls, indicators, and unrelated row metadata.The PR also adds or updates tests for:
Platform behavior is documented separately: desktop web supports mouse-drag selection, while mobile web uses the browser’s native press-and-hold selection flow. The tests that use
window.getSelection()andRangevalidate the web implementation; mobile verification should confirm press-and-hold selection manually or through focused mobile interaction tests.This description reflects the current branch scope, which includes shared selection infrastructure, pressable components, expense/report/member flows, transaction rows, and their related tests.
Fixed Issues
$ #96948
PROPOSAL: #96948 (comment)
Tests
Flow 1: Expense details
Desktop web
Mobile web
Flow 2: Spend Reports and Expenses
Desktop web
Mobile web
Flow 3: Workspace Members
Desktop web
Mobile web
Offline tests
Same as Test
QA Steps
Same as Tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A
Android: mWeb Chrome
Screenrecorder-2026-09-02-23-26-16-923.mp4
Screenrecorder-2026-09-02-21-30-58-235.mp4
iOS: Native
N/A
iOS: mWeb Safari
Screen.Recording.2026-09-03.at.3.26.53.AM.mov
Screen.Recording.2026-09-03.at.3.21.08.AM.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-07-29.at.11.15.05.AM.mov