Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 65 additions & 79 deletions src/pages/workspace/deleteWorkspace/DeleteWorkspaceFlow.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import ConfirmModal from '@components/ConfirmModal';
import {ModalActions} from '@components/Modal/Global/ModalContext';
import RenderHTML from '@components/RenderHTML';

Expand All @@ -22,6 +23,7 @@ import {isSubscriptionTypeOfInvoicing} from '@libs/SubscriptionUtils';
import {getIsTravelInvoicingEnabled, getTravelInvoicingCardSettingsKey} from '@libs/TravelInvoicingUtils';

import CONST from '@src/CONST';
import type {TranslationPaths} from '@src/languages/types';
import ONYXKEYS from '@src/ONYXKEYS';
import {DYNAMIC_ROUTES} from '@src/ROUTES';
import {canDowngradeSelector} from '@src/selectors/Account';
Expand All @@ -32,7 +34,7 @@ import {isEmptyObject} from '@src/types/utils/EmptyObject';
import isLoadingOnyxValue from '@src/types/utils/isLoadingOnyxValue';

import {useIsFocused} from '@react-navigation/native';
import React, {useCallback, useEffect, useRef} from 'react';
import React, {useCallback, useEffect, useRef, useState} from 'react';
import {View} from 'react-native';

type DeleteWorkspaceFlowProps = {
Expand Down Expand Up @@ -118,6 +120,13 @@ function DeleteWorkspaceFlow({policyID, onDismiss, onDeleteComplete}: DeleteWork
const shouldCalculateBillNewDot = !!canDowngrade && ownedPaidPoliciesCounts?.total === 1;
const {shouldBlockDeletion, outstandingBalanceModal} = useOutstandingBalanceGuard(ownedPaidPoliciesCounts?.active ?? 0, onDismiss);

// TODO: temporary fix for https://github.com/Expensify/App/issues/96369 - the error modal is kept as a locally controlled ConfirmModal
// instead of the global useConfirmModal one, because closing the loading delete confirmation modal and immediately pushing another
// global modal leaves the flow latched on iOS, so a second delete attempt never restarts the flow.
// Only the translation key is latched (not the translated copy) so the modal follows the current locale, the raw message is kept
// as-is because it comes from the backend and is cleared from Onyx as soon as the error is dismissed.
const [deleteWorkspaceError, setDeleteWorkspaceError] = useState<{translationKey?: TranslationPaths; message?: string}>();

const hideDeleteWorkspaceErrorModal = useCallback(() => {
dismissWorkspaceError(policyID, policy?.pendingAction);
}, [policyID, policy?.pendingAction]);
Expand All @@ -127,69 +136,45 @@ function DeleteWorkspaceFlow({policyID, onDismiss, onDeleteComplete}: DeleteWork
onDismiss();
}, [hideDeleteWorkspaceErrorModal, onDismiss]);

const closeDeleteWorkspaceErrorModal = useCallback(() => {
setDeleteWorkspaceError(undefined);
dismissDeleteWorkspaceFlow();
}, [dismissDeleteWorkspaceFlow]);

const showDeleteWorkspaceErrorModal = useCallback(() => {
if (!isFocused) {
dismissDeleteWorkspaceFlow();
return;
}

showConfirmModal({
title: translate('workspace.common.delete'),
prompt: (
<View style={[styles.renderHTML, styles.flexRow]}>
<RenderHTML
// When both Expensify Cards and Consolidated Travel Billing are enabled, prioritize the Expensify Cards copy.
html={translate(hasExpensifyCardsEnabledOnWorkspace ? 'workspace.common.deleteOpenExpensifyCardsError' : 'workspace.common.deleteTravelInvoicingError')}
onConciergeLinkPress={() => {
closeModal();
dismissDeleteWorkspaceFlow();
}}
/>
</View>
),
confirmText: translate('common.buttonConfirm'),
shouldShowCancelButton: false,
success: false,
shouldHandleNavigationBack: false,
}).then(() => {
dismissDeleteWorkspaceFlow();
});
}, [closeModal, dismissDeleteWorkspaceFlow, hasExpensifyCardsEnabledOnWorkspace, isFocused, showConfirmModal, styles.flexRow, styles.renderHTML, translate]);

const showGenericDeleteWorkspaceErrorModal = useCallback(
(errorMessage: string) => {
if (!isFocused) {
dismissDeleteWorkspaceFlow();
return;
}

const prompt = CONST.HTML_TAG_REGEX.test(errorMessage) ? (
<View style={[styles.renderHTML, styles.flexRow]}>
<RenderHTML
html={errorMessage}
onConciergeLinkPress={() => {
closeModal();
dismissDeleteWorkspaceFlow();
}}
/>
</View>
) : (
errorMessage
);

showConfirmModal({
title: translate('workspace.common.delete'),
prompt,
confirmText: translate('common.buttonConfirm'),
shouldShowCancelButton: false,
success: false,
shouldHandleNavigationBack: false,
}).then(() => {
dismissDeleteWorkspaceFlow();
});
},
[closeModal, dismissDeleteWorkspaceFlow, isFocused, showConfirmModal, styles.flexRow, styles.renderHTML, translate],
);
// When both Expensify Cards and Consolidated Travel Billing are enabled, prioritize the Expensify Cards copy.
setDeleteWorkspaceError({translationKey: hasExpensifyCardsEnabledOnWorkspace ? 'workspace.common.deleteOpenExpensifyCardsError' : 'workspace.common.deleteTravelInvoicingError'});
}, [dismissDeleteWorkspaceFlow, hasExpensifyCardsEnabledOnWorkspace, isFocused]);

const didCompletePendingDelete = !isOffline && prevIsPendingDelete && !isPendingDelete;
const shouldLatchDeleteWorkspaceErrorModal = didCompletePendingDelete && !!policyLatestErrorMessage && isFocused;

if (shouldLatchDeleteWorkspaceErrorModal && !deleteWorkspaceError) {
setDeleteWorkspaceError(
hasExpensifyCardsEnabledOnWorkspace || hasTravelInvoicingEnabledOnWorkspace
? {translationKey: hasExpensifyCardsEnabledOnWorkspace ? 'workspace.common.deleteOpenExpensifyCardsError' : 'workspace.common.deleteTravelInvoicingError'}
: {message: policyLatestErrorMessage},
);
}

const deleteWorkspaceErrorMessage = deleteWorkspaceError?.translationKey ? translate(deleteWorkspaceError.translationKey) : deleteWorkspaceError?.message;

const deleteWorkspaceErrorPrompt =
!!deleteWorkspaceErrorMessage && CONST.HTML_TAG_REGEX.test(deleteWorkspaceErrorMessage) ? (
<View style={[styles.renderHTML, styles.flexRow]}>
<RenderHTML
html={deleteWorkspaceErrorMessage}
onConciergeLinkPress={closeDeleteWorkspaceErrorModal}
/>
</View>
) : (
deleteWorkspaceErrorMessage
);

// Always invoked after a re-render (from the start effect below for normal deletes, or from usePayAndDowngrade for billed deletes),
// so the workspace being deleted and its derived data are read from the latest state.
Expand Down Expand Up @@ -280,33 +265,34 @@ function DeleteWorkspaceFlow({policyID, onDismiss, onDeleteComplete}: DeleteWork

closeModal();

if (policyLatestErrorMessage && (hasExpensifyCardsEnabledOnWorkspace || hasTravelInvoicingEnabledOnWorkspace)) {
showDeleteWorkspaceErrorModal();
return;
}

if (policyLatestErrorMessage) {
showGenericDeleteWorkspaceErrorModal(policyLatestErrorMessage);
if (!isFocused) {
dismissDeleteWorkspaceFlow();
}
return;
}

onDeleteComplete?.();
onDismiss();
}, [
isOffline,
isPendingDelete,
prevIsPendingDelete,
policyLatestErrorMessage,
hasExpensifyCardsEnabledOnWorkspace,
hasTravelInvoicingEnabledOnWorkspace,
closeModal,
onDeleteComplete,
onDismiss,
showDeleteWorkspaceErrorModal,
showGenericDeleteWorkspaceErrorModal,
]);

return outstandingBalanceModal;
}, [isOffline, isPendingDelete, prevIsPendingDelete, policyLatestErrorMessage, isFocused, closeModal, dismissDeleteWorkspaceFlow, onDeleteComplete, onDismiss]);

return (
<>
{outstandingBalanceModal}
{/* eslint-disable-next-line @typescript-eslint/no-deprecated -- Local modal avoids stacking issues with the global delete confirmation modal on mobile. */}
<ConfirmModal
title={translate('workspace.common.delete')}
isVisible={!!deleteWorkspaceErrorMessage && isFocused}
onConfirm={closeDeleteWorkspaceErrorModal}
onCancel={closeDeleteWorkspaceErrorModal}
prompt={deleteWorkspaceErrorPrompt}
confirmText={translate('common.buttonConfirm')}
shouldShowCancelButton={false}
success={false}
shouldHandleNavigationBack={false}
/>
</>
);
}

export default DeleteWorkspaceFlow;
Loading