Repository navigation
Fix saved search selection in Spend - #97324
nabi-ebrahimi wants to merge 5 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec8aa03707
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@abzokhattab kindly bump, thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-07-31.at.16.11.00.mov |
trjExpensify
left a comment
There was a problem hiding this comment.
Hm, I'm not sure about this. @JS00001 @bernhardoj are working on persisiting filters and it might help resolve whatever bug there was here.
|
oh okay i was reviewing it already :D ... let us know what you think @JS00001 @bernhardoj also cc @carlosmiceli for the visibility |
|
Yeah, this shouldn't be an issue in our PR |
|
Lets close this one in favor of #96466 & pay out for the progress of this issue |
Explanation of Change
This PR fixes incorrect Spend menu selection when a saved search has the same query as a canned tab such as Expenses.
After saving a view, the app now navigates to the named saved-search route. Saved-search selection also requires both the query hash and the route name to match. This allows Expenses and the saved view to share the same query while remaining distinct menu destinations across wide and narrow layouts.
Fixed Issues
$ #97161
PROPOSAL: #97161 (comment)
Tests
test-97161, and select Save View.name=test-97161.name.test-97161saved search.name=test-97161.Offline tests
test-97161.test-97161.QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-29.at.4.16.26.PM.mov
Android: mWeb Chrome
Recording_20260729_154304.mp4
iOS: Native
Screen.Recording.2026-07-29.at.4.12.37.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-07-29.at.3.42.38.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-29.at.3.41.04.PM.mov