Skip to content

[No QA] Clean up unsafe assertions in test targets - #97493

Merged
blimpich merged 3 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt/94739-tests-20260730-03
Aug 4, 2026
Merged

blimpich merged 3 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt/94739-tests-20260730-03

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This test-only cleanup removes 49 @typescript-eslint/no-unsafe-type-assertion findings from the 15 authorized test files. It replaces unsafe assertions with production-derived types, typed mocks and fixtures, and narrow handling for intentional runtime-versus-model boundaries while preserving the existing test scenarios and runtime behavior.

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Count change

Current baseline source:

  • The tracked config/eslint/eslint.seatbelt.tsv at base 8960aa81fd37e54ae2d1493a3c9230b42751814b records the baseline for @typescript-eslint/no-unsafe-type-assertion.

Before:

  • server/victory-chart-renderer/tests/resolveCanvasSize.test.ts: 3 findings
  • tests/actions/IOUTest/GetUpdateMoneyRequestParamsTest.ts: 3 findings
  • tests/actions/IOUTest/UpdateMoneyRequestVendorTest.ts: 3 findings
  • tests/actions/ReplaceOptimisticReportWithActualReportTest.ts: 3 findings
  • tests/actions/connections/SageIntacct.ts: 3 findings
  • tests/navigation/linkToHelpersTests.ts: 3 findings
  • tests/navigation/useDynamicBackPathTests.ts: 3 findings
  • tests/ui/AgentsPromoBannersTest.tsx: 3 findings
  • tests/ui/AssignCardFeed.tsx: 3 findings
  • tests/ui/components/HeaderViewTest.tsx: 3 findings
  • tests/ui/components/SettlementButtonTest.tsx: 3 findings
  • tests/unit/ReportActionsListPaddingViewTest.tsx: 4 findings
  • tests/unit/SearchParserTest.ts: 4 findings
  • tests/unit/SuggestionMentionTest.tsx: 4 findings
  • tests/unit/showReportActionNotificationTest.ts: 4 findings

After:

  • Every authorized target reports 0 findings.

Net reduction:

  • 49 fewer @typescript-eslint/no-unsafe-type-assertion findings across the 15 target files.

TSV evidence:

  • The exact base TSV rows above provide the 49-finding baseline. Complete cleanup-count verification for exact head dc63a8f5a52d4af9c2debb8467419e76fe8e2eec reported zero remaining findings for every target, and the tracked TSV was restored unchanged.

Tests

  1. Deterministic complete verification passed cleanup counting, the verifier-owned project-aware typecheck for every authorized TypeScript path, focused formatting, focused lint, all focused Jest suites through the worktree-aware resolver, restoration of the tracked TSV, changed-path proof, and git diff --check.
  2. Exact-head Fork CI run 30849165059 passed typecheck, lint, format, React Compiler, and Jest for head dc63a8f5a52d4af9c2debb8467419e76fe8e2eec.
  3. The three-commit history is signed and linear from the recorded base; all three commits have verified signature status G, and the cumulative diff contains exactly the 15 authorized files.
  4. Fresh scope, type-safety, and regression reviews all passed for frozen diff sha256:c191462103c8ad0a298105b817aa75c35d2bcdae5ba5c7631b1efa44a3ca021b.
  5. No manual platform testing was performed; the evidence is automated verification only.

Offline tests

N/A — this is a test-only type-safety cleanup; it changes no application runtime or network behavior, and no manual offline test was performed.

QA Steps

N/A — this is a test-only cleanup; no staging or production manual QA was performed.

PR Author Checklist

Each checklist item below is checked because it was considered. Platform, staging or production, offline, screenshot or video, high-traffic, console, and product-component testing are N/A for this test-only cleanup; the automated evidence is listed in ### Tests.

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — no UI or visual behavior changed; no screenshots or videos were produced.

Changed files (15)

  • server/victory-chart-renderer/tests/resolveCanvasSize.test.ts
  • tests/actions/IOUTest/GetUpdateMoneyRequestParamsTest.ts
  • tests/actions/IOUTest/UpdateMoneyRequestVendorTest.ts
  • tests/actions/ReplaceOptimisticReportWithActualReportTest.ts
  • tests/actions/connections/SageIntacct.ts
  • tests/navigation/linkToHelpersTests.ts
  • tests/navigation/useDynamicBackPathTests.ts
  • tests/ui/AgentsPromoBannersTest.tsx
  • tests/ui/AssignCardFeed.tsx
  • tests/ui/components/HeaderViewTest.tsx
  • tests/ui/components/SettlementButtonTest.tsx
  • tests/unit/ReportActionsListPaddingViewTest.tsx
  • tests/unit/SearchParserTest.ts
  • tests/unit/SuggestionMentionTest.tsx
  • tests/unit/showReportActionNotificationTest.ts

@KJ21-ENG KJ21-ENG changed the title Clean up unsafe assertions in test targets [No QA] Clean up unsafe assertions in test targets Jul 31, 2026
@KJ21-ENG
KJ21-ENG marked this pull request as ready for review July 31, 2026 14:27
@KJ21-ENG
KJ21-ENG requested a review from a team as a code owner July 31, 2026 14:27
@melvin-bot
melvin-bot Bot requested a review from ikevin127 July 31, 2026 14:27
@melvin-bot

melvin-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 31, 2026 14:27
@ikevin127

ikevin127 commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Comment thread tests/unit/SearchParserTest.ts Resolved

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM - Only 1 non-blocking comment related to DRY ☝️

49 violations removed across 15 files using the established safe patterns, with strong reuse of the shared TestHelper write-spy helpers and production-derived types.

@melvin-bot
melvin-bot Bot requested a review from blimpich August 2, 2026 02:06

@blimpich blimpich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets address Kevin's feedback

@ikevin127

Copy link
Copy Markdown
Contributor

@blimpich My feedback was addressed ✅, on to you 🙌

@KJ21-ENG
KJ21-ENG marked this pull request as draft August 4, 2026 06:51
@KJ21-ENG
KJ21-ENG marked this pull request as ready for review August 4, 2026 14:34
@blimpich
blimpich merged commit 9489a5b into Expensify:main Aug 4, 2026
38 checks passed
@OSBotify

OSBotify commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Aug 5, 2026
46 tasks done
@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.51-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.51-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants