Repository navigation
[Split #94595] Final PR - Remove useOnyx dependencies arg and bump Onyx - #97594
Conversation
|
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
PR is on hold until #96853 hit staging. |
|
@hoangzinh @nyomanjyotisa One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I'm heading to vacations next week and will return on August 17th, someone will take this over from me. |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-18.at.18.41.10.movAndroid: mWeb ChromeScreen.Recording.2026-08-18.at.18.22.43.moviOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-08-18.at.18.15.04.mov |
hoangzinh
left a comment
There was a problem hiding this comment.
All goods. @fabioh8010 can you check and remove this seatbelt change? TY
mountiny
left a comment
There was a problem hiding this comment.
Thanks! Gonna move this ahead wot avoid conflicts
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.56-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site content under Why: This PR is a purely internal engineering change with no user-facing impact:
None of these files change product features, UI labels, tabs, settings, workflows, pricing, billing, or integrations — so there's nothing in If you believe a specific user-facing behavior changed that I missed, let me know and I'll take another look. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.56-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
react-native-onyxto to 3.0.95:dependenciesparameter (and theDependencyListimport) from the AppuseOnyxwrapper insrc/hooks/useOnyx.ts— it was already never forwarded.src/components/ReportActionItem/MoneyRequestReportPreview/useReportPreviewActionDecision.tssrc/hooks/useReportTransactionViolations.tsrulesdir/no-useOnyx-dependencies-argESLint rule, its config entry, and its seatbelt rows — the 2-argument TypeScript signature now enforces this at compile time, so the lint guard is redundant.Fixed Issues
$ #95582
$ #94595
$ #97050
PROPOSAL:
Tests
For Expensify/react-native-onyx#814:
No tests needed as #96940 implements a FE protection already.
For Expensify/react-native-onyx#800 (Web / Mobile):
Offline tests
N/A
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
For Expensify/react-native-onyx#800:
Screen.Recording.2026-08-07.at.21.48.45.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
For Expensify/react-native-onyx#800:
Screen.Recording.2026-08-07.at.20.27.06.mov