Repository navigation
fix: Add missing autofocus to agents EditNamePage - #97635
Conversation
|
I have opened PR per #97126 (comment) cc: @carlosmiceli |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.4.49-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site articles under This PR only adds autofocus to the name input on the Agents Help site articles (including the AI Agents docs like @Eskalifer1, if you believe this behavior should be documented somewhere specific, let me know and I'll take another pass. |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.49-3 🚀
Bundle Size Analysis (Sentry): |
|
Hi @mallenexpensify, this is ready for payment, no issue was created. It was bug fix as C+, so only 125$ |
Explanation of Change
EditNamePagewas missing autofocus on its name input, unlike other similar edit-name screens in the app. This PR adds theuseAutoFocusInputhook and wires itsinputCallbackRefto theTextInputso the field is automatically focused when the screen opens, matching the existing pattern used elsewhere in the codebase.Fixed Issues
$
PROPOSAL:N/a - caught during C+ review
Tests
Precondition: Be logged in to an account that has at least one agent
Offline tests
N/A - we don't add any offline logic here
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov