Repository navigation
[Payment due @huult] feat: Add Intuit Enterprise Suite integration - #97637
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
4ff22ee to
91fbde0
Compare
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-05.at.23.48.54.movAndroid: mWeb ChromeScreen.Recording.2026-08-05.at.23.47.48.moviOS: HybridAppScreen.Recording.2026-08-05.at.23.51.10.moviOS: mWeb SafariScreen.Recording.2026-08-05.at.23.51.58.movMacOS: Chrome / SafariScreen.Recording.2026-08-05.at.23.29.02.mov |
|
🎯 @huult, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
I didn't want to block on this, the settings screens are covered, but a few export surfaces still show QuickBooks Online for an IES connection because they read |
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.4.51-0 🚀
|
Help site review — no docs changes requiredI reviewed this PR against the help site articles under Why
What to revisit when IES goes GA
@ShridharGoel — I didn't create a help site PR because I don't think one is warranted while the feature is beta-gated and the existing QuickBooks Online article already documents IES support. If you'd like me to draft the GA-facing docs update anyway (or if the beta is closer to rollout than I think), just reply with |
|
@ShridharGoel @JmillsExpensify |
|
Deploy Blocker #97926 was identified to be related to this PR. |
This has now been deployed, can you try again rejection for non-IES companies @huult @ShridharGoel? |
|
checking |
Screen.Recording.2026-08-06.at.15.13.35.mov@ShridharGoel For accounts that don't have access to IES, the connection is correctly blocked as expected. However, there's an issue where nothing happens after Intuit redirects back to the app. I think we should display an error message to inform the user that the connection failed because their account doesn't have access to IES. cc @lakchote |
|
I do agree with what @huult said above, let's show an user friendly message to indicate why it has failed @ShridharGoel |
|
Yes, it is supposed to be shown (was showing when tested in VM env). I'll check why it didn't happen in staging. |
|
@huult Can you try on staging.new.expensify.com while also having the staging server turned on? |
|
I can't test this on staging because my account doesn't have the beta enabled. Could you enable it for either mrtrue955@gmail.com? |
|
It is only a FE beta - so you can just run |
Screen.Recording.2026-08-06.at.21.27.03.movNice, it's working on staging now. Thanks! |
|
🤖 Payment issue created: #98187 |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.51-1 🚀
Bundle Size Analysis (Sentry): |
|
From the payment issue
@lakchote and/or @ShridharGoel can you make sure that QA has these credentials and can test? Posted in the #qa room too |
Explanation of Change
Adds Intuit Enterprise Suite as a separate accounting integration option while reusing the QuickBooks Online backend connection.
Collect workspaces see the option and enter the Control upgrade flow when they select it. Control workspaces can start the IES OAuth flow. Development environments show production and sandbox connection options. Other environments continue directly to production OAuth.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/658857
PROPOSAL:
Tests
intuitEnterpriseSuitebeta.Offline tests
QA Steps
intuitEnterpriseSuitebeta.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-08-05.at.12.44.44.AM.mov