Skip to content

[Payment due @huult] feat: Add Intuit Enterprise Suite integration - #97637

Merged
lakchote merged 28 commits into
Expensify:mainfrom
ShridharGoel:feat/ies-integration-option
Aug 5, 2026
Merged

lakchote merged 28 commits into
Expensify:mainfrom
ShridharGoel:feat/ies-integration-option

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented Aug 1, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds Intuit Enterprise Suite as a separate accounting integration option while reusing the QuickBooks Online backend connection.

Collect workspaces see the option and enter the Control upgrade flow when they select it. Control workspaces can start the IES OAuth flow. Development environments show production and sandbox connection options. Other environments continue directly to production OAuth.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/658857
PROPOSAL:

Tests

  1. Enable the intuitEnterpriseSuite beta.
  2. Open Workspace settings > Accounting in a Collect workspace.
  3. Verify Intuit Enterprise Suite appears as a separate option.
  4. Select Connect for Intuit Enterprise Suite and verify the Control upgrade flow opens.
  5. Open Workspace settings > Accounting in a Control workspace in a development environment.
  6. Select Connect for Intuit Enterprise Suite.
  7. Verify a menu shows Connect and Connect to sandbox.
  8. Select Connect and verify the production Intuit OAuth flow opens.
  9. Repeat the flow, select Connect to sandbox, and verify the sandbox Intuit OAuth flow opens.
  10. Cancel OAuth and verify no accounting connection is added.
  11. Connect an IES company and verify the accounting connection is shown as Intuit Enterprise Suite.
  12. Start a normal QuickBooks Online connection and verify it does not request the IES scope.
  13. Start the IES flow but connect a non-IES company in the Intuit flow.
  14. Verify that the connection does not succeed and shows an error in NewDot.
  • Verify that no errors appear in the JS console

Offline tests

  1. Disable the network connection.
  2. Open Workspace settings > Accounting.
  3. Verify the Connect buttons are disabled and no OAuth flow opens.

QA Steps

  1. Enable the intuitEnterpriseSuite beta.
  2. Open Workspace settings > Accounting in a Collect workspace.
  3. Verify Intuit Enterprise Suite appears and selecting it opens the Control upgrade flow.
  4. Open Workspace settings > Accounting in a Control workspace.
  5. Select Connect for Intuit Enterprise Suite and verify the production Intuit OAuth flow opens directly.
  6. Cancel OAuth and verify no accounting connection is added.
  7. Connect an IES company and verify the connection is shown as Intuit Enterprise Suite.
  8. Connect a normal QuickBooks Online company and verify it is shown as QuickBooks Online.
  9. Start the IES flow but connect a non-IES company in the Intuit flow.
  10. Verify that the connection does not succeed and shows an error in NewDot.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2026-08-05.at.12.44.44.AM.mov

@melvin-bot

melvin-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot
melvin-bot Bot requested a review from dannymcclain August 1, 2026 19:00
@codecov

codecov Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

@ShridharGoel
ShridharGoel force-pushed the feat/ies-integration-option branch from 4ff22ee to 91fbde0 Compare August 4, 2026 14:01
@ShridharGoel
ShridharGoel requested a review from huult August 4, 2026 14:04
@ShridharGoel
ShridharGoel marked this pull request as ready for review August 4, 2026 14:04
@ShridharGoel
ShridharGoel requested review from a team as code owners August 4, 2026 14:04
@melvin-bot
melvin-bot Bot requested review from eVoloshchak and joekaufmanexpensify and removed request for a team August 4, 2026 14:04
@melvin-bot

melvin-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 4, 2026 14:04
@ShridharGoel
ShridharGoel removed the request for review from eVoloshchak August 4, 2026 14:04
@huult

huult commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-08-05.at.23.48.54.mov
Android: mWeb Chrome
Screen.Recording.2026-08-05.at.23.47.48.mov
iOS: HybridApp
Screen.Recording.2026-08-05.at.23.51.10.mov
iOS: mWeb Safari
Screen.Recording.2026-08-05.at.23.51.58.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-05.at.23.29.02.mov

@ShridharGoel ShridharGoel mentioned this pull request Aug 4, 2026
55 tasks done

@huult huult left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@melvin-bot melvin-bot Bot changed the title feat: Add Intuit Enterprise Suite integration [Payment due @huult] feat: Add Intuit Enterprise Suite integration Aug 5, 2026
@melvin-bot

melvin-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

🎯 @huult, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/658857.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@lakchote lakchote left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lakchote

lakchote commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

I didn't want to block on this, the settings screens are covered, but a few export surfaces still show QuickBooks Online for an IES connection because they read NAME_USER_FRIENDLY directly, can you handle this in a follow-up @ShridharGoel?

@lakchote
lakchote merged commit 85eb374 into Expensify:main Aug 5, 2026
39 of 41 checks passed
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 5, 2026
46 tasks done
@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/lakchote in version: 9.4.51-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no docs changes required

I reviewed this PR against the help site articles under docs/articles, and no help-site changes are required at this time. I did not open a draft PR.

Why

  • This PR adds Intuit Enterprise Suite as a separate accounting option, but it's gated behind the intuitEnterpriseSuite beta (WorkspaceAccountingPage uses isBetaEnabled(CONST.BETAS.INTUIT_ENTERPRISE_SUITE)), so it isn't generally available to customers yet. The public help site should document GA behavior — adding a beta-only tile would confuse the majority of Admins who don't see the option.
  • The existing article Connect-to-QuickBooks-Online.md already covers Intuit Enterprise Suite accurately — it states "The QuickBooks Online connection also works with Intuit Enterprise Suite" and lists Intuit Enterprise Suite as a supported tier in the features table. That reflects the reality here, since IES reuses the QuickBooks Online backend connection.

What to revisit when IES goes GA
Once the beta is removed and the dedicated Intuit Enterprise Suite tile ships to everyone, the Step 2: Connect section of that article should be updated to describe:

  • Selecting the separate Intuit Enterprise Suite option (instead of only Set up next to QuickBooks Online), and
  • The Collect → Control upgrade prompt Collect workspaces hit when selecting it.

@ShridharGoel — I didn't create a help site PR because I don't think one is warranted while the feature is beta-gated and the existing QuickBooks Online article already documents IES support. If you'd like me to draft the GA-facing docs update anyway (or if the beta is closer to rollout than I think), just reply with @MelvinBot create the docs PR and I'll put one together.

@kavimuru

kavimuru commented Aug 5, 2026

Copy link
Copy Markdown

@ShridharGoel @JmillsExpensify
Are the applause.expensifail.com domain are added to beta?

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #97926 was identified to be related to this PR.

@lakchote

lakchote commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Agree, no need to hold this PR. The rejection for non-IES companies is entirely backend, it happens in the sync job (Expensify/Integration-Server#9165, merged today but not deployed yet). The App side just shows the standard sync error once the backend fails, so waiting here wouldn't buy us anything.

Everything is behind the intuitEnterpriseSuite beta too, so nobody outside the beta can even start the IES flow in the meantime.

This has now been deployed, can you try again rejection for non-IES companies @huult @ShridharGoel?

@huult

huult commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

checking

@huult

huult commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Agree, no need to hold this PR. The rejection for non-IES companies is entirely backend, it happens in the sync job (Expensify/Integration-Server#9165, merged today but not deployed yet). The App side just shows the standard sync error once the backend fails, so waiting here wouldn't buy us anything.
Everything is behind the intuitEnterpriseSuite beta too, so nobody outside the beta can even start the IES flow in the meantime.

This has now been deployed, can you try again rejection for non-IES companies @huult @ShridharGoel?

Screen.Recording.2026-08-06.at.15.13.35.mov

@ShridharGoel For accounts that don't have access to IES, the connection is correctly blocked as expected. However, there's an issue where nothing happens after Intuit redirects back to the app. I think we should display an error message to inform the user that the connection failed because their account doesn't have access to IES.

cc @lakchote

@lakchote

lakchote commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

I do agree with what @huult said above, let's show an user friendly message to indicate why it has failed @ShridharGoel

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

Yes, it is supposed to be shown (was showing when tested in VM env). I'll check why it didn't happen in staging.

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

@lakchote @huult Seeing this experience on the current staging:

Screen.Recording.2026-08-06.at.7.43.05.PM.mov

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

@huult Can you try on staging.new.expensify.com while also having the staging server turned on?

@huult

huult commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

I can't test this on staging because my account doesn't have the beta enabled. Could you enable it for either mrtrue955@gmail.com?

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

It is only a FE beta - so you can just run Onyx.set('betas', ['all']) in the console.

@huult

huult commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
Screen.Recording.2026-08-06.at.21.27.03.mov

Nice, it's working on staging now. Thanks!

@melvin-bot

melvin-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #98187

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.51-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@mallenexpensify

Copy link
Copy Markdown
Contributor

From the payment issue

We need credentials to connect Intuit Enterprise Suite integration to validate the steps.

@lakchote and/or @ShridharGoel can you make sure that QA has these credentials and can test? Posted in the #qa room too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants