Skip to content

[No QA] Update iOS build workflows to Xcode 26.6 - #97774

Merged
Julesssss merged 5 commits into
Expensify:mainfrom
software-mansion-labs:war-in/update-xcode
Aug 10, 2026
Merged

Julesssss merged 5 commits into
Expensify:mainfrom
software-mansion-labs:war-in/update-xcode

Conversation

@war-in

@war-in war-in commented Aug 4, 2026 •

Copy link
Copy Markdown

Explanation of Change

Re-applies the Xcode 26.6 toolchain bump (#97452, reverted in #97580), extracting the version into a single getXcodeVersion composite action that exports DEVELOPER_DIR and adding it to the Pods cache key. Also drops -T from scripts/strip-ios-debug-symbols.sh — that flag was the real cause of the dyld launch crash on Xcode 26.6.

Root cause and verification

strip -T removes every _$s… (Swift) entry from the Mach-O symbol table. Our script ran it on the app binary, and Xcode's own install-strip (STRIP_INSTALLED_PRODUCT = YES, STRIP_STYLE = all) then runs after that build phase and rebuilds the export trie from the symbol table — so the Swift weak-def exports disappeared.

Xcode 26.6's linker emits bind <weak-def-coalesce> fixups in __DATA __objc_data for fileprivate members of Swift classes coming from static pods. Those binds survived the strip while their exported definitions did not, so dyld aborted at launch:

Symbol not found: _$s6FloatyAAC28setBottomFrameAccordingToRTL33_…LLyy12CoreGraphics7CGFloatVF
Expected as weak-def export from some loaded dylib

Xcode 26.2 did not emit those binds, which is why the same script was harmless before the bump. Floaty was not at fault — it was simply the lowest-addressed of 42 orphaned symbols (26 Floaty, 15 ExpoModulesCore, 1 ForkInputMask), so dyld named it first.

Measured on an Expensify AdHoc archive by applying each strip pipeline to the same linked binary:

main-binary strip exports orphaned Swift binds size
strip -rSTx then Xcode strip -D (before) 1369 42 55,553,072
strip -rSx then Xcode strip -D (after) 1451 0 55,876,984
Xcode strip -D alone 1451 0 55,876,984

A full archive on this branch produces 0 orphaned binds and exports setBottomFrameAccordingToRTL correctly.

Size cost of keeping the Swift symbols: 323,912 bytes uncompressed (0.58% of the binary, 0.17% of the .app), which compresses to ~70 kB in the IPA (~0.08%). -T saved 0 bytes on the embedded frameworks — Xcode already strips those before our script runs — so it was removed from both strip calls. The script's ~22 MB saving comes from -S/-x and is unaffected.

Fixed Issues

$ #97450
PROPOSAL:

Tests

  1. Build an iOS adhoc build and verify app works without any crashes

Offline tests

N/A — iOS build-pipeline change only, no app runtime behavior.

QA Steps

N/A — iOS build-pipeline change only

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@war-in
war-in requested a review from a team as a code owner August 4, 2026 09:09
@melvin-bot
melvin-bot Bot requested review from linhvovan29546 and removed request for a team August 4, 2026 09:09
@melvin-bot

melvin-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@war-in
war-in marked this pull request as draft August 4, 2026 09:10
@war-in

war-in commented Aug 4, 2026

Copy link
Copy Markdown
Author

@linhvovan29546 PR is not yet ready for the final review. We need to confirm builds are working as expected
sorry for the ping

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eeb1f36393

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@mountiny

mountiny commented Aug 5, 2026

Copy link
Copy Markdown

@MelvinBot can you make internal copy of this branch and post the branch name here

@MelvinBot

Copy link
Copy Markdown

Done — pushed an internal copy of this branch to Expensify/App:

war-in/update-xcode

It points at the exact PR head (075b14b), so CI workflows that need repo secrets can now be dispatched against it. It'll go stale as new commits land on the fork PR — ping me to re-sync if you push more.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@war-in

war-in commented Aug 5, 2026

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 075b14bbb2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/buildIOS.yml Resolved
@war-in
war-in marked this pull request as ready for review August 6, 2026 09:00
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@mountiny

mountiny commented Aug 6, 2026

Copy link
Copy Markdown

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@mountiny
mountiny requested review from mountiny and removed request for linhvovan29546 August 6, 2026 13:44
@mountiny

mountiny commented Aug 7, 2026

Copy link
Copy Markdown

We have a deploy freeze so waiting, there are conflicts now

@mountiny mountiny closed this Aug 7, 2026
@mountiny mountiny reopened this Aug 7, 2026
@Julesssss
Julesssss self-requested a review August 7, 2026 20:53
@Julesssss

Copy link
Copy Markdown

@war-in some conflicts 🙃

@mountiny

mountiny commented Aug 9, 2026

Copy link
Copy Markdown

Confirmed that the ios build is working

# Conflicts:
#	rock.config.mjs
@war-in

war-in commented Aug 10, 2026

Copy link
Copy Markdown
Author

@Julesssss @mountiny conflicts resolved

@mountiny mountiny left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mountiny

Copy link
Copy Markdown

We had a deploy freeze now so I sort of want to wait for the next app deploy before testing this out

@roryabraham roryabraham left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat trick with the composite action and including it in the rock fingerprint 👍🏼

@Julesssss
Julesssss merged commit 7ad89cb into Expensify:main Aug 10, 2026
25 of 26 checks passed
@github-actions

Copy link
Copy Markdown

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97774.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7ad89cbb22a-7d586de-0d7ec3a17c27bd752f5d3eae4a35cfaed16ad8c7/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Web 🕸️
https://97774.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@roryabraham roryabraham mentioned this pull request Aug 11, 2026
38 tasks done
truph01 pushed a commit to truph01/App that referenced this pull request Aug 12, 2026
The patch worked around a Swift type-inference bug specific to Xcode 26.2.
The iOS build pipeline now uses Xcode 26.6 (Expensify#97774), so this
workaround should no longer be needed. Removing it to verify a clean build.

Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
@OSBotify

Copy link
Copy Markdown

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.53-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.53-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants