Repository navigation
[No QA] Update iOS build workflows to Xcode 26.6 - #97774
Conversation
This reverts commit fd2d276.
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@linhvovan29546 PR is not yet ready for the final review. We need to confirm builds are working as expected |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eeb1f36393
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot can you make internal copy of this branch and post the branch name here |
|
Done — pushed an internal copy of this branch to
It points at the exact PR head ( |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 075b14bbb2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
We have a deploy freeze so waiting, there are conflicts now |
|
@war-in some conflicts 🙃 |
|
Confirmed that the ios build is working |
# Conflicts: # rock.config.mjs
|
@Julesssss @mountiny conflicts resolved |
|
We had a deploy freeze now so I sort of want to wait for the next app deploy before testing this out |
roryabraham
left a comment
There was a problem hiding this comment.
neat trick with the composite action and including it in the rock fingerprint 👍🏼
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
The patch worked around a Swift type-inference bug specific to Xcode 26.2. The iOS build pipeline now uses Xcode 26.6 (Expensify#97774), so this workaround should no longer be needed. Removing it to verify a clean build. Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.53-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.53-10 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Re-applies the Xcode 26.6 toolchain bump (#97452, reverted in #97580), extracting the version into a single
getXcodeVersioncomposite action that exportsDEVELOPER_DIRand adding it to the Pods cache key. Also drops-Tfromscripts/strip-ios-debug-symbols.sh— that flag was the real cause of thedyldlaunch crash on Xcode 26.6.Root cause and verification
strip -Tremoves every_$s…(Swift) entry from the Mach-O symbol table. Our script ran it on the app binary, and Xcode's own install-strip (STRIP_INSTALLED_PRODUCT = YES,STRIP_STYLE = all) then runs after that build phase and rebuilds the export trie from the symbol table — so the Swift weak-def exports disappeared.Xcode 26.6's linker emits
bind <weak-def-coalesce>fixups in__DATA __objc_dataforfileprivatemembers of Swift classes coming from static pods. Those binds survived the strip while their exported definitions did not, sodyldaborted at launch:Xcode 26.2 did not emit those binds, which is why the same script was harmless before the bump. Floaty was not at fault — it was simply the lowest-addressed of 42 orphaned symbols (26
Floaty, 15ExpoModulesCore, 1ForkInputMask), sodyldnamed it first.Measured on an
Expensify AdHocarchive by applying each strip pipeline to the same linked binary:strip -rSTxthen Xcodestrip -D(before)strip -rSxthen Xcodestrip -D(after)strip -DaloneA full
archiveon this branch produces 0 orphaned binds and exportssetBottomFrameAccordingToRTLcorrectly.Size cost of keeping the Swift symbols: 323,912 bytes uncompressed (0.58% of the binary, 0.17% of the
.app), which compresses to ~70 kB in the IPA (~0.08%).-Tsaved 0 bytes on the embedded frameworks — Xcode already strips those before our script runs — so it was removed from bothstripcalls. The script's ~22 MB saving comes from-S/-xand is unaffected.Fixed Issues
$ #97450
PROPOSAL:
Tests
Offline tests
N/A — iOS build-pipeline change only, no app runtime behavior.
QA Steps
N/A — iOS build-pipeline change only
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari