Repository navigation
Signer info - "This field is required" error is shown by default on job title screen - #97775
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.mov |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Review — LGTM ✅The one-line change is correct, minimal, and matches the established pattern. Adding Why it fixes the bug: Scope check — consistency across the signer-info stepsThe only two Validation on submit is untouched (the empty-field error still appears correctly when tapping Next without input), so the fix removes only the premature default error. Since the repro depends on a workspace with a pending bank account in the "Signer info needed" state, I reviewed this at the code level rather than driving the live flow, but the change is unambiguous and low-risk. |
|
@rinej author checklist failing. Please add and fill missing checklist items. |
|
@aimane-chnaif I added the checklists |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.4.50-0 🚀
|
Help site review: no changes requiredI reviewed the changes in this PR against the help site files under Why: This is a purely behavioral bug fix. It passes The Signer info flow is mentioned in the Global Reimbursement help articles (e.g. Global-Reimbursement-United-States.md), but only at the level of "a Signer info needed task appears in Time sensitive and the signer selects Begin to enter their information." None of those articles document the Job title field's autofocus or validation behavior, so this fix doesn't affect what's documented. No draft docs PR was created since there's nothing to update. @rinej, let me know if you expected a specific article to be updated and I'll take another look. |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.50-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fix: pass
shouldDelayAutoFocusto theJobTitleSingleFieldStepso autofocus waits until the transition completes (matchingNameand the establisheduseSubPagepattern)Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-08-04.at.11.13.30.mp4
Fixed Issues
$ #97725
PROPOSAL:
Tests
Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari