Skip to content

[CP Staging] Revert "Allow moving all matching expenses to a report from Search" - #97989

Merged
arosiclair merged 1 commit into
mainfrom
revert-96482-claude-moveExpensesAllMatching
Aug 6, 2026
Merged

arosiclair merged 1 commit into
mainfrom
revert-96482-claude-moveExpensesAllMatching

Conversation

@arosiclair

Copy link
Copy Markdown
Contributor

Reverts #96482

$ #97923
$ #97943

@arosiclair arosiclair self-assigned this Aug 6, 2026
@mountiny mountiny changed the title Revert "Allow moving all matching expenses to a report from Search" [CP STaging] Revert "Allow moving all matching expenses to a report from Search" Aug 6, 2026
@mountiny mountiny changed the title [CP STaging] Revert "Allow moving all matching expenses to a report from Search" [CP Staging] Revert "Allow moving all matching expenses to a report from Search" Aug 6, 2026
@arosiclair
arosiclair marked this pull request as ready for review August 6, 2026 15:10
@arosiclair
arosiclair requested review from a team as code owners August 6, 2026 15:10
@melvin-bot
melvin-bot Bot requested review from Valforte and joekaufmanexpensify and removed request for a team August 6, 2026 15:10
@melvin-bot

melvin-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

@Valforte Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Aug 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.81% <ø> (ø)
src/components/Search/SearchQueryProvider.tsx 100.00% <100.00%> (+5.00%) ⬆️
src/libs/actions/Transaction.ts 76.54% <100.00%> (-0.31%) ⬇️
...rc/pages/Search/SearchTransactionsChangeReport.tsx 0.00% <0.00%> (ø)
src/hooks/useSearchBulkActions.ts 55.88% <80.00%> (+0.13%) ⬆️
... and 7 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d51ada0d57

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +44 to 46
const rawQueryParam = useRootNavigationState((state) => selectSearchRawQueryParam(state ?? navigation.getState()));
const definedQueryParam = usePreviousDefined(queryParam) ?? buildSearchQueryString();
const currentSearchQueryJSON = buildSearchQueryJSON(definedQueryParam, rawQueryParam);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve rawQuery when leaving Search root

When a user opens an RHP from a manually typed search, such as search/save, the focused screen is no longer SCREENS.SEARCH.ROOT, so selectSearchRawQueryParam() returns undefined while definedQueryParam still keeps the previous q. That rebuilds currentSearchQueryJSON without the rawFilterList; SearchSavePage then calls saveSearch({queryJSON: currentSearchQueryJSON}), so saved/manual searches lose the raw filter order/default filters/display values even though they came from the current search. Keep q and rawQuery in lock-step when carrying the previous search across RHP navigation.

Useful? React with 👍 / 👎.

@arosiclair
arosiclair merged commit ae20d46 into main Aug 6, 2026
60 of 62 checks passed
@arosiclair
arosiclair deleted the revert-96482-claude-moveExpensesAllMatching branch August 6, 2026 15:18
OSBotify pushed a commit that referenced this pull request Aug 6, 2026
…nsesAllMatching

[CP Staging] Revert "Allow moving all matching expenses to a report from Search"

(cherry picked from commit ae20d46)

(cherry-picked to staging by arosiclair)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Aug 6, 2026
46 tasks done
@OSBotify

OSBotify commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.51-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 abandoned ❌
🍎 iOS 🍎 failure ❌

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required — no draft PR created.

This PR reverts #96482, which made the Move expenses bulk action available when a user chose Select all matching in Search (so all matching expenses were moved server-side rather than just the loaded page). The revert restores the prior behavior: Move expenses is offered for normal selections but not for a "Select all matching" selection.

I reviewed App/docs/articles and the reverted behavior was never documented on the help site:

Since the feature this PR reverts (#96482) was recent, CP'd to staging, and had no corresponding help site content, there's nothing to update.

@arosiclair, if you believe any help article did describe the "Select all matching → Move expenses" behavior and should be reverted too, let me know and I'll open a docs PR.

@OSBotify

OSBotify commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.51-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against the help site content under App/docs/articles.

No help site changes are required.

This PR reverts #96482, which had added the ability to move all matching expenses to a report when using the "Select all matching X expenses" banner in Search (moving the full matched set server-side rather than just the loaded page of ~50).

That behavior was never documented on the help site. The articles that cover moving expenses describe the generic flow only — select expenses, then Move to report / Move expenses — and never mention the "Select all matching" banner or the per-page selection limit:

Since these articles make no claim about the "all matching" behavior, the revert doesn't contradict any documented content, and there's nothing to update. No draft PR was created.

cc @arosiclair — flagging in case you'd still like a docs note clarifying the current per-selection move behavior; if so, let me know and I'll draft one.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.51-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.52-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no changes required.

This PR reverts Expensify/App#96482, which had made the Move expenses action available for "Select all matching" selections in Search so that all matching expenses (not just the loaded page of 50) could be moved server-side via the search query/hash.

I reviewed App/docs/articles against HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md, and none of the help articles document this reverted behavior:

The "Select all matching" + Move-expenses interaction being reverted was an edge-case, technical capability that was never surfaced in the public help site, so nothing becomes inaccurate as a result of this revert and no draft docs PR is needed.

@arosiclair, if you believe this behavior should be documented (either the current post-revert state or the previous one), let me know and I'll draft the article.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants