Repository navigation
[CP Staging] Revert "Allow moving all matching expenses to a report from Search" - #97989
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d51ada0d57
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const rawQueryParam = useRootNavigationState((state) => selectSearchRawQueryParam(state ?? navigation.getState())); | ||
| const definedQueryParam = usePreviousDefined(queryParam) ?? buildSearchQueryString(); | ||
| const currentSearchQueryJSON = buildSearchQueryJSON(definedQueryParam, rawQueryParam); |
There was a problem hiding this comment.
Preserve rawQuery when leaving Search root
When a user opens an RHP from a manually typed search, such as search/save, the focused screen is no longer SCREENS.SEARCH.ROOT, so selectSearchRawQueryParam() returns undefined while definedQueryParam still keeps the previous q. That rebuilds currentSearchQueryJSON without the rawFilterList; SearchSavePage then calls saveSearch({queryJSON: currentSearchQueryJSON}), so saved/manual searches lose the raw filter order/default filters/display values even though they came from the current search. Keep q and rawQuery in lock-step when carrying the previous search across RHP navigation.
Useful? React with 👍 / 👎.
…nsesAllMatching [CP Staging] Revert "Allow moving all matching expenses to a report from Search" (cherry picked from commit ae20d46) (cherry-picked to staging by arosiclair)
|
🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.51-1 🚀
|
|
🤖 No help site changes required — no draft PR created. This PR reverts #96482, which made the Move expenses bulk action available when a user chose Select all matching in Search (so all matching expenses were moved server-side rather than just the loaded page). The revert restores the prior behavior: Move expenses is offered for normal selections but not for a "Select all matching" selection. I reviewed
Since the feature this PR reverts (#96482) was recent, CP'd to staging, and had no corresponding help site content, there's nothing to update. @arosiclair, if you believe any help article did describe the "Select all matching → Move expenses" behavior and should be reverted too, let me know and I'll open a docs PR. |
|
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.51-1 🚀
|
|
🤖 I reviewed the changes in this PR against the help site content under No help site changes are required. This PR reverts #96482, which had added the ability to move all matching expenses to a report when using the "Select all matching X expenses" banner in Search (moving the full matched set server-side rather than just the loaded page of ~50). That behavior was never documented on the help site. The articles that cover moving expenses describe the generic flow only — select expenses, then Move to report / Move expenses — and never mention the "Select all matching" banner or the per-page selection limit:
Since these articles make no claim about the "all matching" behavior, the revert doesn't contradict any documented content, and there's nothing to update. No draft PR was created. cc @arosiclair — flagging in case you'd still like a docs note clarifying the current per-selection move behavior; if so, let me know and I'll draft one. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.51-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.52-0 🚀
|
|
🤖 Help site review: no changes required. This PR reverts Expensify/App#96482, which had made the Move expenses action available for "Select all matching" selections in Search so that all matching expenses (not just the loaded page of 50) could be moved server-side via the search query/hash. I reviewed
The "Select all matching" + Move-expenses interaction being reverted was an edge-case, technical capability that was never surfaced in the public help site, so nothing becomes inaccurate as a result of this revert and no draft docs PR is needed. @arosiclair, if you believe this behavior should be documented (either the current post-revert state or the previous one), let me know and I'll draft the article. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |
Reverts #96482
$ #97923
$ #97943