Skip to content

Align Cancel payment gate with the pay gate for paid-elsewhere reports - #98082

Merged
Beamanator merged 13 commits into
Expensify:mainfrom
David-2002065:fix/97577-cancel-payment-revert-state
Sep 1, 2026
Merged

Beamanator merged 13 commits into
Expensify:mainfrom
David-2002065:fix/97577-cancel-payment-revert-state

Conversation

@David-2002065

@David-2002065 David-2002065 commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This fixes the gating defect behind Cancel payment on a manually-paid ("paid elsewhere") report.

Cancel payment didn't surface for every admin/payer who could mark the report paid. isCancelPaymentAction gated on isAdmin && isPayer. On a manual-reimbursement workspace isPayer narrows to the single designated reimburser, and the extra isAdmin requirement further excluded non-admin payers. But the pay gate (canIOUBePaid.canPay) admits any payer, or on a manual workspace any member with WORKFLOWS_PAYMENTS write access, with no admin requirement. So a non-admin payments admin, or a non-reimburser admin, could mark a report paid yet was blocked from cancelling it — the two gates disagreed.

The cancel gate now mirrors canIOUBePaid.canPay exactly:

const canCancelPayment =
    isPayerUtils(currentAccountID, currentUserEmail, report, bankAccountList, policy, false) ||
    (policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_MANUAL &&
        canMemberWrite(policy, currentUserEmail, CONST.POLICY.POLICY_FEATURE.WORKFLOWS_PAYMENTS));

Whoever could mark the report paid can now cancel it, and no one else.

Scoped per review discussion: this PR now covers the gating half of the issue only. The optimistic revert-to-correct-state work was dropped here since that calculation is being removed as offline mode is killed for this flow.

Fixed Issues

$ #97577
PROPOSAL: #97577 (comment)

Tests

  1. On a manual reimbursement ("Pay elsewhere") workspace, submit an expense and mark the report as paid.
  2. Sign in as an admin who is not the designated reimburser (or as a non-admin member who has Payments write access).
  3. Open the report header menu.
  4. Verify Cancel payment is now offered for that user (previously it was hidden even though the same user could mark the report paid).
  5. Sign in as a member who has neither reimburser rights nor Payments access and verify Cancel payment is not offered.
  • Verify that no errors appear in the JS console

Offline tests

The Cancel payment gate does not depend on connectivity.

  1. Go offline.
  2. As a non-reimburser admin (or a member with Payments access) on a manual-reimbursement workspace, open a paid report's header menu.
  3. Verify Cancel payment is offered, matching the online behavior.
  • Verify that no errors appear in the JS console

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-10.at.12.35.36.mp4
Android: mWeb Chrome
Screen.Recording.2026-08-10.at.12.26.17.mp4
iOS: mWeb Safari
Screen.Recording.2026-08-10.at.12.16.41.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-10.at.12.08.17.mp4
Screen.Recording.2026-08-10.at.12.38.41.mov

cancelPayment guessed the post-cancel state from policy.approvalMode alone,
always landing on APPROVED. That is wrong for reports paid from Outstanding
(instant submit without approvals, or payments-disabled workspaces) and cannot
distinguish an instant-submit report (should return to Outstanding) from a
delayed-submit report auto-closed to Done via SUBMITTED_AND_CLOSED (should
return to Done).

Derive the pre-payment state from the report's own action history instead:
find the last workflow action before the latest PAY action and map it back to
the state the report was in. Falls back to the policy-based guess when there is
no action history.
@David-2002065

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db69435cdc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/IOU/PayMoneyRequest.ts Resolved
…TTED action

A submit-and-close report (approvals and payments off) auto-closes to Done on
submit, but its optimistic action is a plain SUBMITTED action — the server
reconciles it to SUBMITTED_AND_CLOSED later. Paying and cancelling in that
window (offline or slow API) previously reverted the report to Outstanding
because the SUBMITTED action was read as an instant-submit. Distinguish the two
by the policy's own close behavior (payments disabled -> Done).
@David-2002065

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d6352e5da

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/IOU/PayMoneyRequest.ts Resolved
…orkflow

cancelPayment distinguished a submit-and-close report (auto-closed to Done)
from an instant-submit report (Outstanding) by the policy's reimbursementChoice
via arePaymentsEnabled. That misfires on a submit-and-close workspace that has
payments enabled: submitReport still closes such a report to Done and stamps its
optimistic SUBMITTED action with originalMessage.workflow = OPTIONAL, but the
payments check flipped it back to Outstanding on cancel.

Read the workflow off the SUBMITTED action instead, matching how submitReport
decides the state. This anchors the report to Done regardless of payments and no
longer depends on reimbursementChoice.
@David-2002065
David-2002065 marked this pull request as ready for review August 9, 2026 11:20
@David-2002065
David-2002065 requested review from a team as code owners August 9, 2026 11:20
@melvin-bot
melvin-bot Bot requested review from shubham1206agra and trjExpensify and removed request for a team and shubham1206agra August 9, 2026 11:21
@melvin-bot

melvin-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ab4b2c7de

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/IOU/PayMoneyRequest.ts Resolved
The optimistic revert can now move the report's stateNum away from APPROVED
(e.g. to SUBMITTED when reverting to Outstanding), but the cancelPayment
failureData only restored statusNum to REIMBURSED. On a failed or rolled-back
CancelPayment that left the paid report in a mixed SUBMITTED/REIMBURSED state.

Restore stateNum to the report's pre-cancel value in the failure update so a
rollback returns it to the paid APPROVED/REIMBURSED state. Added a regression
test that fails the request after an Outstanding revert.
@shubham1206agra

Copy link
Copy Markdown
Contributor

@dilshodmackbook-sketch I believe this PR is not complete. Please double check

@shubham1206agra

Copy link
Copy Markdown
Contributor

@dilshodmackbook-sketch Also, test this PR on actual env, not the simulated ideal state.

…admins

isCancelPaymentAction gated on isPayer, which on a manual-reimbursement
workspace narrows to the single designated reimburser. But the pay gate
(canIOUBePaid / isPayer with onlyShowPayElsewhere semantics) admits any admin
with WORKFLOWS_PAYMENTS write access, so a non-reimburser admin could mark a
report paid yet was blocked from cancelling it — the two gates disagreed.

Admit that same admin in the cancel gate: keep the admin check, then allow the
designated reimburser OR (manual reimbursement AND WORKFLOWS_PAYMENTS write
access). This completes the gating half of the issue alongside the revert-state
change; without it Cancel payment never surfaces for those admins.
Comment thread src/libs/ReportSecondaryActionUtils.ts Resolved
The cancel gate kept an isAdmin guard, but the pay gate (canIOUBePaid) has none:
its canPay is isPayer || (manual reimbursement && WORKFLOWS_PAYMENTS write). So a
non-admin who could mark the report paid — e.g. a payments admin, or a non-admin
designated reimburser — was blocked from cancelling, re-introducing the same
pay/cancel asymmetry this change set out to fix.

Gate cancel on the exact canPay predicate instead, with no separate admin check.
Added a test for a non-admin payments admin.
@David-2002065

Copy link
Copy Markdown
Contributor Author

@shubham1206agra ready to review

@shubham1206agra

Copy link
Copy Markdown
Contributor

@dilshodmackbook-sketch Again, test this PR on actual env, not the simulated ideal state. Also, please show the entire browser in screenshot/video please

@David-2002065

Copy link
Copy Markdown
Contributor Author

@shubham1206agra I re-recorded the web flow on dev.new.expensify.com with the whole browser in frame — updated in the MacOS: Chrome / Safari section, one online and one offline. Mark as paid then Cancel payment reverts the report to its pre-payment state on the real env. Please take another look.

The fix is pure JS with no native changes, so iOS native behaves identically and is covered by the web and mWeb recordings.

trjExpensify
trjExpensify previously approved these changes Aug 10, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed product change 👍

@shubham1206agra

Copy link
Copy Markdown
Contributor

Let's put this PR on hold on #97556 (comment)

Policies always load on OpenApp and nothing is allowed on a deleted
policy, so the unresolvable-policy fallback the guard blocked can't
happen in practice. Retarget the manager negative test at a real
paid-group policy and trim the verbose comments.
@David-2002065

Copy link
Copy Markdown
Contributor Author

@shubham1206agra friendly bump on this one. All the review comments from last week are addressed and pushed, the extra isPaidGroupPolicy guard is removed as requested, and the manager negative test now blocks via isPayer on a real paid-group policy so we keep the toBe(false) coverage. CI is green. Could you take another look when you have a moment?

@shubham1206agra

Copy link
Copy Markdown
Contributor

@dilshodmackbook-sketch Can you please test all the scenarios stated here #98082 (review) and send the screenshot as a comment for one platform only?

@David-2002065

Copy link
Copy Markdown
Contributor Author

@shubham1206agra Ran the full matrix from your review on web (Chrome). Screenshots are grouped below — the "More" menu is open on a paid-elsewhere expense report in each case, so you can see directly whether Cancel payment is offered. Every case matches the expected result.

# Setup Actor Expected Result
A1 Indirect (manual) WS, reimburser = owner Second admin, not the reimburser Visible Shown
A2 Control WS, Indirect Payments Admin (not a workspace admin) Visible Shown
A3 Indirect WS The designated reimburser Visible Shown
B1 Indirect WS Member (user role) Hidden Hidden
B2 Control WS, Indirect Auditor Hidden Hidden
B3 Direct WS, not reimburser, no bank access Admin Hidden Hidden
B4 Indirect WS Report manager who isn't the payer Hidden Hidden
C1 Direct WS, bank (ACH) payment, before 23:45 UTC cutoff Reimburser Visible Shown
C2 Same, after the cutoff Reimburser Hidden Hidden

B3 confirms the widening doesn't leak to Direct workspaces, and B4 stays hidden without needing the paid-group-policy guard. C1/C2 confirm bank eligibility follows the latest pay action and its NACHA cutoff.

Cancel payment now offered (A1, A2, A3, C1)

RESULT-shown

Cancel payment stays hidden (B1, B2, B3, B4, C2)

RESULT-hidden

A few notes on the rest of the list:

  • E3 (offline): every shot above was taken offline (see the offline indicator at the bottom) — the gate doesn't depend on connectivity, so the result is identical to online, no console errors.
  • D1 (P2P send money): untouched — the IOU branch returns before this guard, so the sender still sees Cancel payment as before.
  • C3 / E1 / E2: C3 is the behaviour change you already flagged for @Beamanator (a decision, not a pass/fail), and E1/E2 are the revert-state flow that was descoped from this PR, so they're out of scope for the gating change here.

No JS console errors in any case.

@David-2002065
David-2002065 force-pushed the fix/97577-cancel-payment-revert-state branch 2 times, most recently from f9cc28b to 06dae9b Compare August 26, 2026 08:55
Upstream removed the isProduction parameter from getSecondaryReportActions/
getSecondaryTransactionThreadActions (now read from the runtime module), so the
branch's added test cases no longer type-check when passing isProduction: false.
@David-2002065
David-2002065 force-pushed the fix/97577-cancel-payment-revert-state branch from fb551ec to 2240e58 Compare August 26, 2026 09:55
@garrettmknight

Copy link
Copy Markdown
Contributor

@shubham1206agra can you review the test results when you get a chance?

@trjExpensify

Copy link
Copy Markdown
Contributor

Bump @shubham1206agra. This has been waiting on you for a week.

@shubham1206agra

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-09-01.at.9.00.11.PM.mov

@melvin-bot
melvin-bot Bot requested a review from Beamanator September 1, 2026 15:31
@Beamanator
Beamanator merged commit feaab17 into Expensify:main Sep 1, 2026
36 of 39 checks passed
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.66-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Yes — help site changes were required. Draft docs PR: #100105

This PR widened who is offered Cancel payment (previously workspace admin and payer; now anyone who could mark the report paid). Three help articles described the old, narrower rule.

What I changed

File Change
docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md Added a Payments admin role entry, a new ## Who can cancel a payment on a report section, and updated the role column on both Cancel payment table rows
docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md Dropped the inaccurate (Admins only) qualifier, fixed Cancel Payment → Cancel payment, added who-can-cancel note
docs/articles/new-expensify/reports-and-expenses/Attach-and-edit-receipts-on-expenses.md Same three fixes
How I checked the behavior and the labels

Gate the docs now describe, from src/libs/ReportSecondaryActionUtils.ts:481-484:

isPayer || (reimbursementChoice === REIMBURSEMENT_MANUAL && canMemberWrite(policy, email, WORKFLOWS_PAYMENTS))

This matches the pay gate at src/libs/actions/IOU/ReportWorkflow.ts:249-253, so the docs now say the same people who can pay a report can cancel it.

WORKFLOWS_PAYMENTS write access maps to the workspace owner, Workspace admin, and Payments admin roles — which is why Payments admin now appears in the role list. Payments admin was already documented in Managing Workspace Members, so the terminology is consistent.

Labels verified in the live web UI, not from memory: Cancel payment (report More menu), Mark as paid and Pay with business account (pay dialog), and the Payments section plus Payer row in Workflows.

Not documented: the latest-pay-action change (a superseded pay action no longer keeps Cancel payment around after a cancel-and-repay). That is a correctness fix to an internal calculation with no separate user-facing rule to describe.

I could not run npm run spell-changed in this environment — cspell wasn't executable from the sandbox. CI on the docs PR will catch anything.

One thing I couldn't do: GitHub rejected assigning you to #100105 (dilshodmackbook-sketch is not assignable on Expensify/App — read access only, and no prior activity on that new PR). The HelpDot label is applied and PullerBear is requested as reviewer. Please self-assign, or leave any comment on the PR and I can assign you on a retry.

@dilshodmackbook-sketch, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.68-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

emkhalid pushed a commit to emkhalid/App that referenced this pull request Sep 22, 2026
Aligns the help site with the Cancel payment gate change in Expensify#98082.

Co-authored-by: Dilshod Bunyodov <dilshodmackbook-sketch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants