Skip to content

[NoQA] HeaderWithBackButton migration - primitives introduction - #98160

Merged
mountiny merged 67 commits into
Expensify:mainfrom
software-mansion-labs:Guccio163/header/headerComposedImplementation
Aug 31, 2026
Merged

mountiny merged 67 commits into
Expensify:mainfrom
software-mansion-labs:Guccio163/header/headerComposedImplementation

Conversation

@Guccio163

@Guccio163 Guccio163 commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

First step of the HeaderWithBackButton composition over configuration migration; This branch is the "build the replacement" phase; swapping real callers over is a later PR.

Current HeaderWithBackButtonComposed/index.tsx form is not the end goal — it's scaffolding. It reassembles the legacy render from small named primitives while keeping the exact same flat prop API as the original, so:

  • it's visible, block by block, which composed piece replaces which part of the legacy render,
  • each piece can be verified independently to prove it reproduces the original correctly,
  • it pressure-tests what API each primitive actually needs, so the eventual free-composition API (Header.Left/Header.Right + block children) can be designed with minimal wrapper overhead.

Introduced primitives:

  • HeaderBackButton, HeaderIcon, HeaderTitle, HeaderThreeDotsMenu, HeaderCloseButtonTooltip, HeaderDownloadButton, HeaderMenuItemButtonTooltip.
  • Later deduped: HeaderTooltipIconButton — Back/Download/Close/MenuItem were all Tooltip+Pressable+Icon differing only in onPress-wrapping, fill, and ref logic, so the shared skeleton got extracted and the four now delegate to it.
  • zones/HeaderRight + zones/HeaderActions wrap the right-side cluster: outer separates it from the center content, inner packs custom children + download together and applies its padding unconditionally so the gap to whatever follows never needs to know what that is.

Parts kept inline, not extracted: AvatarWithDisplayName (report avatar), Avatar (policy avatar), SearchButton, SidePanelButton are rendered directly in index.tsx, not through dedicated primitives, because extracting them into separate primitives would be either a no-op wrapper or they are used only once so it's redundant to create a separate primitive wrapper just for this.

Parts removed entirely (confirmed via census across all 531 real legacy call sites that these never actually render/apply, then deleted along with their plumbing):

  • HeaderRotateButton/shouldShowRotateButton/isRotating/onRotateButtonPress — the one real caller passes it as a prop that always resolves to false.
  • HeaderPinButton/shouldShowPinButton — always explicit false or absent, never true.
  • shouldOverlay, shouldNavigateToTopMostReport, shouldDisableThreeDotsButton, threeDotsMenuIcon/threeDotsMenuIconFill — each 100% unused across every call site.
  • The whole progress-bar path (progressBarPercentage, stepCounter-driven bar, HeaderProgressBar) — already removed upstream on main while this PR was being developed.

Parts restructured (ensuring unchanged behavior):

  • Back button's left padding: used to be a conditional pl2 on the outer header container (a leftover from when the progress bar also needed container-level padding logic). Now that the progress bar is gone, it's a negative margin (mln3) on HeaderBackButton itself — self-contained, doesn't need the container to coordinate with anything.
  • SearchButton/SidePanelButton moved from being siblings outside the right-side wrapper View to siblings inside it. Verified with DOM measurements and screenshots: zero visual difference either way, because the gap between them and whatever precedes them comes from padding on the actions-wrapper regardless of where they sit. Moved purely so the whole right side is one visibly single group in the tree, instead of "half of it is wrapped, half isn't" — easier to explain and reason about, not a rendering change.

Tooling accommodation: knip.json got index.tsx added as an entry point, since nothing imports this folder yet — without it, Knip would flag the whole thing as dead code.

Fixed Issues

$ #96611
PROPOSAL:

Tests

  1. Log into New Expensify on a workspace with tags enabled (Workspace Settings > More features > Tags, at least one tag list configured).
  2. Create expense > Per diem > pick destination, dates, subrates.
  3. On the confirmation screen, select a Tag.
  4. Submit the expense.
  5. Open the created expense — verify the Tag you picked is saved on it.

NoQA PR, so tests are code-wise: check if the whole HeaderWithBackButton component's pieces are swapped correctly with primitive components in the new HeaderWithBackButtonComposed/index.tsx file.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

@Guccio163 Guccio163 changed the title Guccio163/header/header composed implementation [NoQA] HeaderWithBackButton migration - primitives introduction Aug 13, 2026
@gijoe0295

Copy link
Copy Markdown
Contributor

Sorry. On my list tomorrow morning.

@Guccio163

Copy link
Copy Markdown
Contributor Author

Hi @gijoe0295, thank you for your review! I applied some of your suggestions and responded to some (if I don't fully agree). I'm not sure how we should name the Actions/Right folder, so I'm leaving this for discussion. If you don't mind I think we should go forward with this PR like I suggested here and once it's ready for @mountiny I'll start with the follow-up. WDYT @gijoe0295 ?

@mountiny

Copy link
Copy Markdown
Contributor

@gijoe0295 thanks for a thorough review! Can you please continue? thank you

@gijoe0295

gijoe0295 commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-31.at.13.20.16.mov

@gijoe0295 gijoe0295 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from mountiny August 31, 2026 06:21
…-fork into Guccio163/header/headerComposedImplementation
…b.com:software-mansion-labs/expensify-app-fork into Guccio163/header/headerComposedImplementation

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mountiny
mountiny merged commit 70db780 into Expensify:main Aug 31, 2026
34 of 35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.65-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR, so I did not create a draft docs PR.

This is an internal refactor with no user-facing surface:

  • Every file is new scaffolding under src/components/HeaderWithBackButtonComposed/, plus a knip.json entry point and one spacing utility. Nothing imports the new folder yet, which is exactly why knip.json needed the entry.
  • No behavior or layout change ships to users. The PR description documents DOM-measurement and screenshot checks confirming the SearchButton / SidePanelButton regrouping and the back-button padding move are visually identical.
  • No new copy. The only strings are existing translation keys reused as-is: common.back, common.close, common.download, and stepCounter. No src/languages/* files changed.
  • The removed props (shouldShowRotateButton, shouldShowPinButton, shouldOverlay, threeDotsMenuIcon, and the rest) were confirmed dead across all call sites, so no documented behavior disappears.

docs/articles describes product features and workflows, not component internals. There is nothing in it that this PR makes inaccurate.

Since no docs PR exists, there is nothing to label HelpDot, assign, or mark Ready for review. If the follow-up PR that swaps real callers over changes any visible header behavior, ping me on that one and I will write the docs updates then.


view run

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants