Repository navigation
[No QA] Docs updates for E/A#97853 Add Canadian Multiple Tax Export template - #98478
Conversation
Co-authored-by: Nguyen Van Duc <dukenv0307@users.noreply.github.com>
|
There's nothing to fix here — no code check is failing. The only red check is Check independent approval ( Every actual CI check ( |
|
@MelvinBot please open the PR |
|
🤖 Done — this PR is now marked Ready for review. |
|
|
||
| ## Why don't I see the Canadian Multiple Tax Export template? | ||
|
|
||
| The **Canadian Multiple Tax Export** template only appears when the workspace's output currency is set to CAD. If you export reports from a workspace that uses any other output currency, this template is hidden. When you bulk export reports from more than one workspace, the template only appears if every selected report belongs to a workspace that outputs in CAD. |
There was a problem hiding this comment.
UI terminology violation: "output currency" (used twice here) is internal wording, not the UI label. Users see this setting as Workspace currency. Per HELPSITE_NAMING_CONVENTIONS.md (use exact UI text, avoid internal language), replace "output currency" with "workspace currency."
HelpDot Documentation ReviewOverall AssessmentThis PR makes small, well-scoped additions to two New Expensify export articles (How to Export Expenses and How to Export Reports), documenting the new Canadian Multiple Tax Export template. Each file gets one new list item in the "What export templates can I choose from?" list and one new FAQ entry explaining the CAD output-currency condition (including multi-workspace bulk-export behavior). The changes are consistent across both files and align cleanly with the existing article structure and the governance standards.Scores Summary
Key Findings
Recommendations
Files Reviewed
|
|
The only failing check is Check independent approval, and it's not something I can fix by pushing code. This check stays red until the PR gets an independent human approval — it's not evaluating the diff. Every other check (build, What to do: this PR just needs a reviewer to approve it. Once you've reviewed the doc changes and confirmed they reflect current behavior, an independent approval will turn this check green — there's no code fix required. |
This comment has been minimized.
This comment has been minimized.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@VictoriaExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://c4b8598d.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.69-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀
Bundle Size Analysis (Sentry): |
Docs updates for E/A#97853
PR #97853 adds a new default export template, Canadian Multiple Tax Export, to New Expensify. It appears in the export template menu (for both expenses and reports) when the workspace's output currency is set to CAD, producing a CSV with a separate column per tax (such as GST and PST). For bulk exports spanning multiple workspaces, it only appears when every selected item belongs to a workspace that outputs in CAD.
What changed in the help site
Updated the two New Expensify export articles that list the available export templates:
Notes
export.multipleTaxExportinen.tsandCONST.REPORT.EXPORT_OPTION_LABELS.MULTIPLE_TAX_EXPORT), which is the source of truth for the rendered label.@dukenv0307, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.