Repository navigation
[No QA] Docs updates for E/A#98164 show Expensify Card monthly settlement date - #98685
Conversation
Co-authored-by: Brandon Stites <stitesExpensify@users.noreply.github.com>
|
The only failing check is Check independent approval, and there's nothing to fix by pushing code. That check isn't a build/test failure — it fails simply because the PR doesn't yet have an independent approval (an approving review from someone other than the author). It will pass on its own once a reviewer approves the PR. Every other check is passing or skipped: Check results
No push is needed here. Once this PR is reviewed and approved, that check will clear. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2c4431c75
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| When your settlement frequency is set to **Monthly**, the **Settings** page shows the recurring day of the month your cards settle. On the Expensify Card **Settings** page, the **Settlement frequency** row displays supporting text below it, such as *Expensify cards will settle on the 27th of each month.* | ||
|
|
||
| This date is shown for reference only and cannot be changed. If your settlement frequency is set to **Daily**, no monthly settlement date is shown because balances settle automatically every business day. |
There was a problem hiding this comment.
Explain how re-enabling Monthly changes the settlement date
For admins eligible for monthly settlement, saying this date “cannot be changed” is inaccurate. The frequency screen allows switching to Daily and back to Monthly, and updateSettlementFrequency() assigns new Date() whenever Monthly is selected (src/libs/actions/Card.ts:667), changing the recurring settlement day to the day of that switch. Clarify that users cannot select a specific date directly, and explain that re-enabling Monthly resets the date.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall Assessment This PR adds a single, focused 6-line section (When your Expensify Cards settle each month) to the existing US Expensify Card article, documenting the monthly settlement date supporting text surfaced in New Expensify (parity with OldDot). The change is tightly scoped, factually clear, and does not expand the article beyond its single workflow. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
@stephanieelliott @stitesExpensify No QA steps, OK to check off this one? |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.64-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.64-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Documents the user-facing behavior added in #98164, which surfaces the Expensify Card's current monthly settlement date as supporting text under the Settlement frequency row on the workspace's Expensify Card Settings page in New Expensify (parity with OldDot).
This PR adds a new task-based section, When your Expensify Cards settle each month, to
Set-Up-and-Manage-the-Expensify-Card-US.md. The section explains that:The wording mirrors the in-product hint text (
workspace.expensifyCard.monthlySettlementDate) added in the code PR, and all UI labels (Settings, Settlement frequency, Monthly, Daily) match the current NewDot UI exactly. Authored perHELPSITE_NAMING_CONVENTIONS.md,HELP_AUTHORING_GUIDELINES.md, andTEMPLATE.md(task-based##heading, sentence-case bold UI labels, single workflow).Related PR
@stitesExpensify, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.