Skip to content

[No QA] Docs updates for E/A#98164 show Expensify Card monthly settlement date - #98685

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsCardMonthlySettlementDate
Aug 28, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsCardMonthlySettlementDate

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Documents the user-facing behavior added in #98164, which surfaces the Expensify Card's current monthly settlement date as supporting text under the Settlement frequency row on the workspace's Expensify Card Settings page in New Expensify (parity with OldDot).

This PR adds a new task-based section, When your Expensify Cards settle each month, to Set-Up-and-Manage-the-Expensify-Card-US.md. The section explains that:

  • When settlement frequency is Monthly, the Settlement frequency row shows the recurring day of the month cards settle (e.g. Expensify cards will settle on the 27th of each month.).
  • The date is read-only and cannot be changed.
  • When settlement frequency is Daily, no monthly settlement date is shown.

The wording mirrors the in-product hint text (workspace.expensifyCard.monthlySettlementDate) added in the code PR, and all UI labels (Settings, Settlement frequency, Monthly, Daily) match the current NewDot UI exactly. Authored per HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md (task-based ## heading, sentence-case bold UI labels, single workflow).

Related PR


@stitesExpensify, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Brandon Stites <stitesExpensify@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 14, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check is Check independent approval, and there's nothing to fix by pushing code.

That check isn't a build/test failure — it fails simply because the PR doesn't yet have an independent approval (an approving review from someone other than the author). It will pass on its own once a reviewer approves the PR.

Every other check is passing or skipped:

Check results
  • ✅ CLA, check, dryRun, spellcheck, verify, validate, verifySignedCommits — all passing
  • ⏭️ actionlint, validateImmutableActionRefs, review, approveAndMerge, etc. — skipped (not applicable to this docs-only change)
  • ❌ Check independent approval — fails only because no independent approval exists yet

No push is needed here. Once this PR is reviewed and approved, that check will clear.

@stephanieelliott
stephanieelliott marked this pull request as ready for review August 27, 2026 05:58
@stephanieelliott
stephanieelliott self-requested a review as a code owner August 27, 2026 05:58

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2c4431c75

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


When your settlement frequency is set to **Monthly**, the **Settings** page shows the recurring day of the month your cards settle. On the Expensify Card **Settings** page, the **Settlement frequency** row displays supporting text below it, such as *Expensify cards will settle on the 27th of each month.*

This date is shown for reference only and cannot be changed. If your settlement frequency is set to **Daily**, no monthly settlement date is shown because balances settle automatically every business day.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Explain how re-enabling Monthly changes the settlement date

For admins eligible for monthly settlement, saying this date “cannot be changed” is inaccurate. The frequency screen allows switching to Daily and back to Monthly, and updateSettlementFrequency() assigns new Date() whenever Monthly is selected (src/libs/actions/Card.ts:667), changing the recurring settlement day to the day of that switch. Clarify that users cannot select a specific date directly, and explain that re-enabling Monthly resets the date.

Useful? React with 👍 / 👎.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single, focused 6-line section (When your Expensify Cards settle each month) to the existing US Expensify Card article, documenting the monthly settlement date supporting text surfaced in New Expensify (parity with OldDot). The change is tightly scoped, factually clear, and does not expand the article beyond its single workflow.

Scores Summary

  • Readability: 9/10 - Two concise, well-flowing paragraphs. Clear explanation of both the Monthly and Daily behavior, including why no date shows for Daily. Example hint text is italicized appropriately.
  • AI Readiness: 8/10 - Heading is topic/task-based and searchable, includes the full feature name (Expensify Card), and uses correct level-two heading hierarchy. Minor: the "When your..." heading reads more as a topic phrase; an explicit question form would sharpen retrieval.
  • Style Compliance: 9/10 - UI labels (Settings, Settlement frequency, Monthly, Daily) are bold, sentence-cased, and match the UI exactly. No prohibited vague navigation phrasing. Consistent with the surrounding article.

Key Findings

  • Single, clearly-defined workflow addition, no scope creep, no multi-feature coverage.
  • All UI terminology is bolded and matches the product exactly per HELPSITE_NAMING_CONVENTIONS.md.
  • Correctly documents the read-only, cross-platform nature (shown for reference only and cannot be changed).
  • Minor: the illustrative sentence uses lowercase "Expensify cards" inside the italic example. This mirrors verbatim in-product hint text, so it is acceptable, but differs from the capitalized Expensify Card used elsewhere.

Recommendations

  • No blocking issues. Optionally tighten the heading toward an explicit question form (e.g. "When do your Expensify Cards settle each month") for stronger alignment with Section 6.
  • Confirm the verbatim hint text ("Expensify cards will settle on the 27th of each month.") matches the exact product string, since it is presented as example UI copy.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-US.md - Clean, compliant 6-line addition. Approved with minor optional suggestions.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott merged commit b44d61d into main Aug 28, 2026
20 of 21 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsCardMonthlySettlementDate branch August 28, 2026 03:32
@OSBotify OSBotify mentioned this pull request Aug 28, 2026
45 tasks done
@m-natarajan

Copy link
Copy Markdown

@stephanieelliott @stitesExpensify No QA steps, OK to check off this one?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.64-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.64-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#98164 show Expensify Card monthly settlement date [No QA] Docs updates for E/A#98164 show Expensify Card monthly settlement date Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants