Repository navigation
[No QA] Consume react-native dSYMS in CI workflows - #98853
roryabraham merged 13 commits into
Conversation
deploy.yml workflowdeploy.yml workflow
deploy.yml workflow|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6033111017
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@MelvinBot could you create a follow-up issue for this one: #98853 (comment) |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@roryabraham Does this need review? |
|
no thanks @mananjadhav |
|
@codex review |
|
@MelvinBot review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d2de43c78
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ReviewThe mechanism works — I confirmed it end-to-end in the adhoc build log for this PR (run 32876161295): both dSYM tarballs downloaded, verified, and merged into the framework tarball for the 1. The cache key's version segment came out empty, and the step can't tell youIn that adhoc run the key was 2. Is the artifacts cache a net win?From the same log, all four tarballs downloaded and SHA-verified in ~15s total. Meanwhile the other caches in that job are ~1045 MB and ~394 MB against a 10 GB repo-wide budget with LRU eviction. A few-hundred-MB entry per (version × dsyms) combination competes with the node and Pods caches, whose misses cost minutes rather than seconds. Worth measuring restore-vs-download before keeping the step. 3.
|
|
I addressed point
This one seems to be the only reasonable / not opinionated one. Let me know @roryabraham if you'd like to address more of those points. I think 2 and 3 should be ignored. I vaguely remember that when I was profiling Android builds on CI in the past, downloading large Maven artifacts could be a bottleneck, so I cached those artifacts now. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.73-0 🚀
|
|
@collectioneur @mateuuszzzzz We had to revert one line from this Pr as the testflight was failing to be uploaded, can you take a look please? #100507 |
|
Sure, taking a look now |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
PR enables dSYMs consumption for staging, production and adhoc builds. During creating Xcode archive those dSYMs are consumed by Sentry build phase so later we can read
react-nativeframes in crash reports.Additionally, this PR removed redundancy from artifacts utility script and now package name is picked based on platform and hybrid flags.
dSYMs are large files so cache step was added for them so we could retrieve them quickly during workflow run.
For clarification:
xcframework. Finally, Xcode archive extracts those dSYMs into a directory that Sentry build phase reads.Fixed Issues
$ #99186
PROPOSAL:
Tests
Trigger an AdHoc build with workflow changes from this PR
buildIOSjob, verify theResolve react-native artifact versionstep outputs a real version (notsource)Cache react-native artifactsstep uses key…-rn-artifacts-react-hybrid-<version>Cache miss: downloading reactnative-core-dSYM-debug.tar.gz …andAdding symbols … to framework tarball …Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari