Repository navigation
Conversation
|
@codex please review |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@dukenv0307 could you review as this is part of the GPS project? |
|
on it now |
|
|
||
| /** | ||
| * Empty layers whose only purpose is to give other layers a stable position to anchor to via `belowLayerID`/`aboveLayerID`. | ||
| * This is needed as `belowLayerID`and `aboveLayerID` don't work well on native when they target layers that may not be |
There was a problem hiding this comment.
| * This is needed as `belowLayerID`and `aboveLayerID` don't work well on native when they target layers that may not be | |
| * This is needed as `belowLayerID` and `aboveLayerID` don't work well on native when they target layers that may not be |
|
Code looks good |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-20.at.22.53.07.mp4Android: mWeb ChromeiOS: HybridAppScreen.Recording.2026-08-20.at.22.45.47.mp4iOS: mWeb SafariMacOS: Chrome / Safari |
|
1 minor comment @GCyganek |
|
@heyjennahay in case you missed it |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.65-0 🚀
|
|
No help site changes are required, so I did not create a draft PR. This PR is an internal rendering fix only. It changes how Mapbox layers are ordered on the GPS map — it adds empty anchor layers ( Nothing user-facing changes:
Docs I checkedThe only articles that mention GPS tracking are:
The Distance Expenses article documents the flow (➕ Create → Track distance → GPS → Start / Stop / Resume / Save → Create expense), background tracking, and what the GPS receipt looks like. None of that is affected by this diff, and the article never describes map layer stacking. Every statement in it stays accurate after this change. I did not run a UI test for this. GPS tracking is iOS/Android only, and this run's test platform is web, so a web run could not exercise the changed code path.
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixes layer ordering in
GPSMapView. Drops the current fragile logic (onDidFinishRenderingFrameFully+ remounting viakey) in favour of a newLayerOrderAnchorscomponent rendering empty anchor layers. Waypoints and route now anchor to stable layer ids, keeping LocationPuck > Waypoints > Route order. Removes the platform-specificlocationPuckLayerIdfiles. This should fix bug where we don't show route & waypoints on the GPS map on iOS whenbelowLayerIDpoints to a layer that has not been mounted yet.Fixed Issues
$ #98965
PROPOSAL: N/A
Tests
backgrounded app:
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-19.at.08.45.55.mp4
iOS: Native
Screen.Recording.2026-08-19.at.08.33.23.mp4