Skip to content

[No QA] Docs updates for E/A#99015 rename Subscription empty-state button to Add card - #99366

Merged
stephanieelliott merged 1 commit into
mainfrom
docs-subscription-add-card-label
Sep 4, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
docs-subscription-add-card-label

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Follow-up to #99015, which restyled the Account > Subscription > Payment empty state (no billing card added) and, in doing so, renamed the empty-state button on web from "Add payment card" to "Add card" (new string subscription.cardSection.addCard).

The help article Add-or-Update-a-Payment-Card.md still told users to select Add payment card in step 2 of "How to add a payment card" — the first-time / empty-state flow that this PR changed. This updates that one step to the exact new button label, Add card.

Scope notes:

  • Only step 2 of "How to add a payment card" was changed. Step 4 ("Accept the terms and select Add payment card") refers to the add-payment-card form's submit button, which E/A#99015 did not change, so it is left as-is.
  • The "How to replace the payment card on file" flow (three-dots ⋮ → Change payment card) is unaffected and unchanged.

Related Issues

$ #99014

Tests / QA

Docs-only change. Verify the rendered article at Billing and Subscriptions > Manage your subscription and billing > Add or Update a Payment Card reads "In the Payment section, select Add card." in step 2, and that all links still resolve.


@shawnborton, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 24, 2026
@shawnborton

Copy link
Copy Markdown
Contributor

Seems good to me 👍

@shawnborton

Copy link
Copy Markdown
Contributor

@MelvinBot mark draft as ready for review please.

@MelvinBot
MelvinBot marked this pull request as ready for review August 24, 2026 23:31
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now marked Ready for review.


view run

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, focused, one-line change to Add-or-Update-a-Payment-Card.md: in the "How to add a payment card" procedure, the button label in step 2 was changed from Add payment card to Add card. This is a UI-terminology correction intended to match the exact text shown in the product. It is a small, low-risk edit that improves style compliance.

Scores Summary

  • Readability: 9/10 - The changed step remains clear, sequential, and action-oriented. Shortening the label does not affect flow or scannability.
  • AI Readiness: 9/10 - No impact on heading structure, metadata, or retrieval quality. The surrounding article already uses task-based headings, full feature names, and valid YAML. The change keeps UI-exact labels, which aids precise retrieval.
  • Style Compliance: 8/10 - The edit aligns with HELPSITE_NAMING_CONVENTIONS.md (use the exact UI text, bold, Sentence case). The one caveat is internal consistency (see below).

Key Findings

  • Positive: The change follows the Core UI Referencing Rules. It matches the exact product label, keeps bold formatting, and preserves Sentence case. No quotation marks or synonyms were introduced.
  • Positive: The edit is correctly scoped to a single line and does not expand scope or touch unrelated content.
  • Consistency to verify: Step 2 now reads Add card, but the final confirmation button in step 4 of the same procedure still reads Add payment card, and the replace-card procedure also uses Add payment card. If the UI genuinely uses two different labels (an initial Add card entry point and a final Add payment card confirm button), this is correct as written. If the UI actually uses one consistent label, the other references should be updated to match so the article stays deterministic per the naming conventions.

Recommendations

  • Confirm against the live UI whether the entry-point button is Add card while the confirmation button is Add payment card. If they are actually the same label, align all references in this file for consistency.
  • No other action required. Headings, metadata, navigation phrasing, and FAQ structure in the surrounding article already comply with the governance files and are unchanged by this PR.

Files Reviewed

  • Add-or-Update-a-Payment-Card.md: One-line button label correction (Add payment card to Add card). Compliant; verify label consistency across the two procedures.

Note: This PR contains a single-line change; a top-level summary is the appropriate level of detail.

@stephanieelliott
stephanieelliott merged commit 1562cf9 into main Sep 4, 2026
19 of 21 checks passed
@stephanieelliott
stephanieelliott deleted the docs-subscription-add-card-label branch September 4, 2026 00:54
@stephanieelliott stephanieelliott changed the title Docs updates for E/A#99015 rename Subscription empty-state button to Add card [No QA] Docs updates for E/A#99015 rename Subscription empty-state button to Add card Sep 4, 2026
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants