Repository navigation
Conversation
# Conflicts: # src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
# Conflicts: # src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx # src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
This was referenced Sep 1, 2026
Contributor
Author
|
This was interim PR. It's now splitted into smaller chunks, so can be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
MoneyRequestReportTransactionListhad grown into a single ~1300-line component mixing data derivation (sorting, grouping, spend totals, column visibility, layout/breakpoints, selection state, active transaction IDs, pending-expense handling) with rendering. This made it hard for the React Compiler to memoize the component as a whole, since any local mutation anywhere in the tree could invalidate downstream memoization.This PR decomposes that logic into focused, single-purpose hooks and presentational sub-components so each derivation chain can be memoized independently by the React Compiler, and the top-level component becomes a thin composition layer:
useMoneyRequestReportSortedTransactions— sorting logic (sort column/order, comparator selection)useMoneyRequestReportGroupedTransactions— grouping transactions by category/tag for the "group by" layoutuseMoneyRequestReportTransactionSelection— selection-mode state and bulk-selection actionsuseMoneyRequestReportActiveTransactionIDs— tracking/persisting the active transaction IDs for navigationuseMoneyRequestReportColumns— visible-column computation for the table layoutuseMoneyRequestReportLayout— report layout/breakpoint derivationsuseMoneyRequestReportPendingExpense— pending-expense-related derivationsMoneyRequestReportGroupByButton,MoneyRequestReportListFooter,MoneyRequestReportTableHeaderRow— extracted presentational sub-componentsNo behavioral change is intended; this is a structural refactor to improve memoization boundaries and readability.
Note: this branch is stacked on top of the still-open draft PR #99307 (Decompose MoneyRequestReportActionsList into hooks) and on unopened follow-up work extracting
useMoneyRequestReportData, so the diff shown here includes those ancestor commits until they land onmain.Fixed Issues
$ N/A
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari