Repository navigation
Cleanup for Decompose Avatar component - #99553
roryabraham merged 4 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
ReviewOverall: Clean, faithful refactor — replacing the ✅ Verified equivalence
🔸 Minor: lost
|
| Step | Status | Observation |
|---|---|---|
| Workspace chat: LHN row + header show subscript avatar; senders show round avatars | ✅ pass | LHN & header show a rounded-square main avatar with a circular subscript badge; Concierge sender avatar is a full circle |
| Workspace room (#admins) header → details page shows workspace avatar as rounded square | ✅ pass | Details page renders a large rounded-square workspace avatar |
| Hover sender avatar → user details tooltip shows avatar, name, email | Hover could not be simulated in the headless session (automation limitation, not shape-related) — please spot-check in a real browser |
Attendee stacked-avatar steps (5–6) weren't run because the headless composer wouldn't accept typed input to create the expense; worth a manual pass.
Screenshots
Workspace chat LHN and header showing subscript avatar overlay
Zoomed LHN row: rounded-square workspace avatar with circular subscript badge
Concierge chat showing round avatar for message sender
Zoomed crop confirming circular message-sender avatar
#admins report details page showing rounded-square workspace avatar
Note: I wasn't able to run
jest/tsclocally in this environment, so I reviewed the test changes (AvatarTest.tsx,GroupChatNameTests.tsx) by reading — theAvatarFromIcon/UserAvatar/WorkspaceAvatarmock migration looks correct. Rely on CI for the definitive pass.
Regression huntVerdict: no functional or build regressions found. The refactor is faithful — I traced every migrated call site and the border-radius math, and ran a runtime avatar sweep on web. One genuinely-changed behavior (a lost What I checked (all clean)
🔸 One real behavioral change (low impact)
🧪 Runtime sweep (web) — 3/4 pass, 1 inconclusive
ScreenshotsLHN rows — workspace rounded-square + circular subscript badge, Concierge circular Workspace Members list — circular member avatar Account profile — circular user avatar Workspace Overview — rounded-square workspace avatar Hover attempt — no tooltip (hover not registering in headless session)
|
|
@aimane-chnaif all updated |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.65-0 🚀
|
|
No help site changes are required. I did not create a docs PR. This PR is an internal refactor of the How I checkedWhat the PR actually changes
The PR's own test steps only ask a reviewer to confirm avatars still render the same way they do today — round for people, rounded square for workspaces. That is the existing behavior, not new behavior. Docs I ruled out Five articles mention avatars. None of them describe the component internals this PR touches:
Other signals
@jmusial, there is no linked help site PR because no article needs updating. If you think a doc should change anyway, reply with what you'd like documented and I'll open the draft PR. Evidence (1)Recordings- [▶ Session recording of the verification run](https://melvinbot-assets.exops.io/session-33427886495-1-6c96d648-9912-4c92-80b6-562778e45319.webm) |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀
Bundle Size Analysis (Sentry): |






Explanation of Change
AvatarFromIconthat renders a user or workspace avatar from an Onyx Icon entry.Avatar/index.tsxfacade and removed the type prop from the public avatar APIAvatarFromIcon, collapsing repeated props spreads into a single icon propCONST.AVATAR_SHAPE(CIRCLE/ROUNDED_SQUARE). Avatar primitives now take shape instead of type.Fixed Issues
$ #95600
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-26.at.14.26.24.mov
Android: mWeb Chrome
Screen.Recording.2026-08-26.at.14.27.37.mov
iOS: Native
Screen.Recording.2026-08-26.at.14.22.57.mov
iOS: mWeb Safari
Screen.Recording.2026-08-26.at.14.24.42.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-26.at.13.53.12.mov