Skip to content

[No QA] Docs updates for E/A#98509 linking existing card feed to non-USD workspace - #99706

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docs-cardFeedNonUsdWorkspace
Sep 4, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docs-cardFeedNonUsdWorkspace

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Follow-up docs update for Expensify/App#98509 ($ Expensify/App#98503), which allows linking an existing Expensify Card feed to a workspace on any currency — the supported-currency requirement now only applies when enrolling a brand-new card program.

The published guide Set Up and Manage the Expensify Card in the US already mentioned linking an existing feed across workspaces, but did not clarify that this works when the target workspace uses a currency other than USD. This PR adds that clarification.

Changes:

  • Expanded the "Select a Bank Account" step to note that linking an existing feed works even when the current workspace uses a non-USD currency, and that the currency requirement only applies to enrolling a brand-new program.
  • Added an FAQ entry: Can I link an existing card feed to a workspace that isn't set to USD?

Only docs/articles was touched. No product/code changes.

UI terminology note: button and feature labels reused here (Issue new card, Expensify Card, More features, Settings > Workspaces) are unchanged from the currently published guide, so no new UI labels were introduced.

Fixed Issues

Docs follow-up for #98509

Tests

N/A — documentation only. Rendered Markdown reviewed for structure and formatting.

QA Steps

N/A — documentation only.


@chuckdries, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…rkspace

Co-authored-by: Chuck Dries <chuckdries@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 27, 2026
@chuckdries
chuckdries marked this pull request as ready for review August 27, 2026 22:26
@chuckdries

Copy link
Copy Markdown
Contributor

The copy melvin proposed does read a little like slop, but it's true and accurate. @stephanieelliott what do you think?

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes two small, well-scoped additions to the article Set-Up-and-Manage-the-Expensify-Card-US.md: (1) a clarifying sentence appended to the "Select a Bank Account" step explaining that linking an existing card feed works even when the current workspace uses a non-USD currency, and (2) a new FAQ entry answering whether an existing feed can be linked to a non-USD workspace. Both changes are accurate follow-ups to E/A#98509, reuse existing UI terminology, and introduce no new labels.

Scores Summary

  • Readability: 8/10 - The appended step sentence is clear and correctly uses an em dash to separate the clarification. The new FAQ answer is accurate but dense, packing the linking rule, the enrollment-currency exception, and a fallback instruction into one long paragraph. Splitting into two shorter sentences or a brief list would improve scannability.
  • AI Readiness: 8/10 - The new FAQ heading is a natural, searchable question ("...a workspace that isnt set to USD?") that matches real query intent and correctly sits under the FAQ section (exempt from task-based heading rules). Full feature name "Expensify Card feed" is used and heading hierarchy stays at ##. Note: the articles internalScope still frames the doc as US-only, so the added non-USD guidance is a slight scope stretch, though acceptable as clarification.
  • Style Compliance: 9/10 - Reuses exact, already-published UI labels (Issue new card, Expensify Card, More features, Settings > Workspaces) with correct bolding and introduces no new UI terms. Currency terms (USD, GBP, EUR) are consistent. The FAQ format matches sibling entries (plain question heading, direct "Yes." answer).

Key Findings

  • Both additions are factually aligned with the referenced product change and avoid inventing new UI labels.
  • The new FAQ answer is the only real weak point: it is information-dense and would read better as two sentences or a short list.
  • The change is confined to docs/articles with no code or product impact.

Recommendations

  • Consider lightly breaking up the new FAQ answer for readability (linking rule / enrollment exception / fallback action).
  • Optional: confirm whether the articles internalScope (currently US-focused) should acknowledge the cross-currency linking nuance now documented.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-US.md - Approve with minor suggestions. Additions are accurate and style-compliant; only readability of the new FAQ answer could be improved.

Note: This review is based solely on the added/modified lines in the PR diff.

@stephanieelliott
stephanieelliott merged commit acf82f8 into main Sep 4, 2026
18 of 20 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docs-cardFeedNonUsdWorkspace branch September 4, 2026 00:58
@stephanieelliott stephanieelliott changed the title Docs updates for E/A#98509 linking existing card feed to non-USD workspace [No QA] Docs updates for E/A#98509 linking existing card feed to non-USD workspace Sep 4, 2026
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants